[RESOLVED] yet another preg_replace question

kikki

Hi!
I wonder how to get everything between two tags?
(I've got bunch of texts and tags in $content vars.. but only one <pre>X</pre> tag)

I've tried something like this.. but didn't work at all.. :p
$goodinfo = preg_replace("#<pre>(.*?)</pre>#si", "\1", $content);
echo $goodinfo;

Any suggestion is appreciated 🙂

TIA

NogDog

What exactly do you want to happen. The code you provided should end up removing all <pre>...</pre> tags from the string while leaving the intervening text in place. Is that your intention, or are you trying to do something else?

(PS: your regex works, but it's really not necessary to escape the "<" and ">" characters with a backslash.)

kikki

NogDog wrote:
What exactly do you want to happen.

Thanks for the reply NogDog,
I'm trying to grab everything inside between <pre> and </pre> tags... and assign it to $str variable so I can use it later..

TIA

NogDog

Use preg_match() or preg_match_all(), using the 3rd parameter to specify an array variable to hold the matches:

if(preg_match('#<pre>(.*?)</pre>#si', $text, $matches))
{
   echo $matches[1];  // array index 1 == first sub-pattern
}

kikki

NogDog wrote:
Use preg_match() or preg_match_all(), using the 3rd parameter to specify an array variable to hold the matches:
if(preg_match('#<pre>(.*?)</pre>#si', $text, $matches))
{
   echo $matches[1];  // array index 1 == first sub-pattern
}


//$count = lines... 
if(preg_match('#<pre>(.*?)</pre>#si', $garbage, $matches))
{

for($i=0; $i<$count; $i++)
{
	echo $matches[$i];  // array index
}

}

thanks but it doesn't do anything yet,.. what can be wrong? 😕

bradgrafelman

Do a print_r() on the $matches array to see the structure of it.

Also note that you'll only get the first match. If you want to know the data in ALL of the <pre> tags, you'll want to use [man]preg_match_all/man.

kikki

bradgrafelman wrote:
Do a print_r() on the $matches array to see the structure of it.

Also note that you'll only get the first match. If you want to know the data in ALL of the <pre> tags, you'll want to use [man]preg_match_all/man.

Hi bradgrafelman,
thanks for the reply, have tried following but still nothing.. output is empty.. I wonder whats wrong..

if(preg_match('#<pre>(.*?)</pre>#si', $webcontent, $matches))
{

	print_r($matches[1]);  // array index 1 == first sub-pattern

}

bradgrafelman

Can you show us the contents of $webcontent ?

kikki

bradgrafelman wrote:
Can you show us the contents of $webcontent ?

sure.. it's a source of a website... (I've removed unnecessary texts, still watch out it's a mess... )
These all will be in $webcontent, what I'm trying to do is to grab the text between <pre> tags...

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD><TITLE>News</TITLE>
<META http-equiv=Content-Language content=en-us>
<META http-equiv=Content-Type content="text/html; charset=utf-8">
<META name="revisit-after" content="1 days">
</HEAD>
<BODY>
<DIV class=iehackwrap>
<DIV class=boxwrap>
<DIV class=boxheader>
<!--advertising on samair -->

<div style="margin-top:5" align="center">

</div>
<!--advertising on samair -->
</DIV>
<DIV class=boxheader2>
<DIV class=right>
<br>
<p>
<b>
color="#FF0000">new!</font></b></sup>
</b>
</p>
<br>

</DIV>

</DIV>
<!--start boxbody-->
<DIV class=boxbody>
<DIV class=boxcenter>
<H2>NewsList</H2>
<DIV class=box>
<div>
</div>


<b>#1</b>
<pre>
Here comes News(listed)
</pre>
<div> 
...
...

bradgrafelman

Works fine for me:

<?php
$webcontent = <<<EOF
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD><TITLE>News</TITLE>
<META http-equiv=Content-Language content=en-us>
<META http-equiv=Content-Type content="text/html; charset=utf-8">
<META name="revisit-after" content="1 days">
</HEAD>
<BODY>
<DIV class=iehackwrap>
<DIV class=boxwrap>
<DIV class=boxheader>
<!--advertising on samair -->

<div style="margin-top:5" align="center">

</div>
<!--advertising on samair -->
</DIV>
<DIV class=boxheader2>
<DIV class=right>
<br>
<p>
<b>
color="#FF0000">new!</font></b></sup>
</b>
</p>
<br>

</DIV>

</DIV>
<!--start boxbody-->
<DIV class=boxbody>
<DIV class=boxcenter>
<H2>NewsList</H2>
<DIV class=box>
<div>
</div>


<b>#1</b>
<pre>
Here comes News(listed)
</pre>
<div> 
...
...
EOF;

if(preg_match('#<pre>(.*?)</pre>#si', $webcontent, $matches)) 
{ 

    print_r($matches[1]);  // outputs "\nHere comes News(listed)\n" where \n = newline

}

kikki

bradgrafelman wrote:

Works fine for me:

<?php
$webcontent = <<<EOF
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD><TITLE>News</TITLE>
<META http-equiv=Content-Language content=en-us>
<META http-equiv=Content-Type content="text/html; charset=utf-8">
<META name="revisit-after" content="1 days">
</HEAD>
<BODY>
<DIV class=iehackwrap>
<DIV class=boxwrap>
<DIV class=boxheader>
<!--advertising on samair -->

<div style="margin-top:5" align="center">

</div>
<!--advertising on samair -->
</DIV>
<DIV class=boxheader2>
<DIV class=right>
<br>
<p>
<b>
color="#FF0000">new!</font></b></sup>
</b>
</p>
<br>

</DIV>

</DIV>
<!--start boxbody-->
<DIV class=boxbody>
<DIV class=boxcenter>
<H2>NewsList</H2>
<DIV class=box>
<div>
</div>


<b>#1</b>
<pre>
Here comes News(listed)
</pre>
<div> 
...
...
EOF;

if(preg_match('#<pre>(.*?)</pre>#si', $webcontent, $matches)) 
{ 

    print_r($matches[1]);  // outputs "\nHere comes News(listed)\n" where \n = newline

}

that works perfectly.. but now I know why my example didn't work at all.. darn it... when I got the websource... I've used htmlspecialchars 😛 and forgot all about it.. that was stupid.. sorry bro, but thanks a lot.. really appreciate it.. I guess NogDog's example would have worked just fine in the first place if it wasn't for the htmlspecialchars...