[RESOLVED] code output

182x

Hey guys,

I am trying to make a table which displays links if the record has a file that can be downloaded but the code I have is wrong. Just wondering how to fix it?

Thanks.

<?php

while($display=mysql_fetch_array($q))
{
     if (empty($display['p'])) {
          $f = "<td></td>";

 }
 else {
      $f = "<td><a href=\"$display['p']\">".$display['p']."</a></td>";
 }

 echo "<tr class='style4'><td>".$display['Id']."</td><td>".$display['f']."</td></tr>";
}
?>

NogDog

Looks like maybe you want to add $f to your echo?

echo "<tr class='style4'><td>".$display['Id']."</td><td>".$display['f']."</td>$f</tr>";

182x

Thanks for your reply.

This line of code also seems to be wrong any suggestions?

 $f = "<td><a href=\"$display['p']\">".$display['p']."</a></td>";

abc123

What is it doing wrong? Any details? Does it cause an error message to appear?

182x

displays the following error:

Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in C:\xampp\htdocs\a\tec.php on line 83

abc123

Try this to see if it works.

$disp = $display['p'];

$f = "<td><a href = '$disp'>$disp</a></td>";

It at least looks a lot clearer than before.

Also some good advice is to post any error messages along with the code that is being the problem. It helps people to help you.

Hope this helps.

NogDog

A couple options to deal with the array elements in a string literal:

// concatenation:
$f = "<td><a href=\"".$display['p']."\">".$display['p']."</a></td>";
// complex (curly brace) notation:
$f = "<td><a href=\"{$display['p']}\">{$display['p']}</a></td>";
// sprintf:
$f = sprintf("<td><a href=\"%s\">%s</a></td>", $display['p'], $display['p']);

bradgrafelman

abc123 wrote:
It at least looks a lot clearer than before.

And also adds an extra variable that isn't needed.

Here's yet another way to reference an array:

$f = "<td><a href=\"$display[p]\">$display[p]</a></td>";

abc123

bradgrafelman: That's a fair point about my solution for the problem. It is neater to have without the extra variable. There is just so many different (and in this case better ways) to do things.