Help, please!!!

XzorZ

Ok, I really, really need help.

<html><body>
<?php
$company = $_REQUEST['company'];
$version = $_REQUEST['version'];
$quantity = $_REQUEST['quantity'];
$name = $_REQUEST['name'];
$phone = $_REQUEST['phone'];
$email = $_REQUEST['email'];
$notes = $_REQUEST['notes'];


mail("email@example.com", "Ink Cartridge Order",
$company, "From: $email"
$quantity, "From: $email"
$name, "From: $email"
$phone, "From: $email"
$email, "From: $email"
$notes, "From: $email" );
}
header("Location: http://www.exapleforyou.ca");
?>
</body></html>

.....I get this:

Parse error: parse error, unexpected T_VARIABLE in /home/www/example.com/geeks/geeks.php on line 14

If ANYONE could help, I would be very, very appreciative!

NogDog

Your call of the mail() function is pretty messed up (hope that's not too technical 🙂 ). It should have at most only 5 parameters. I think you want something like:

<?php
$company = $_REQUEST['company'];
$version = $_REQUEST['version'];
$quantity = $_REQUEST['quantity'];
$name = $_REQUEST['name'];
$phone = $_REQUEST['phone'];
// some basic email header injection prevention:
$email = preg_replace('/[\r\n]+/', ' ', $_REQUEST['email']);
$notes = $_REQUEST['notes'];

$msg = "$company
$quantity
$name
$phone
$email
$notes";

mail("email@example.com", "Ink Cartridge Order", $msg, "From: $email" );
}
header("Location: http://www.exapleforyou.ca");
?>

XzorZ

Nope. I get:

Parse error: parse error, unexpected '}' in /home/www/example.com/geeks/geeks.php on line 19

Hm..I got the error That the } on line 19 was unexpected, so I removed it. Then, I tried it, and it redirected me to the right page like it worked, and I didn't get the email! Then I googled it, and downloaded a couple scripts that I knew would work, and changed the Email and it still didn't email me!! .....

bpat1434

Is the sendmail line configured correctly in your php install?

XzorZ

In my PHP install? Hmm....I don't know, I don't have it installed on my PC. I'm using Freehostia.com.....

NogDog

The "From:" email address usually has to be a valid email account on the web host. If you want the user-supplied email address to be the one used for replies, then use it in a "Reply-To:" header (while using a "From:" email address that is a valid one on your host).

$headers = "From: email@yourhost.com\r\nReply-To: $email";
mail("email@example.com", "Ink Cartridge Order", $msg, $headers);

XzorZ

Uhm, I don't see what you mean. I don't have $headers anywhere on my page. Did you want me to replace:

header("Location: http://www.exapleforyou.ca");

With what you posted?

bradgrafelman

No, he's saying modify your mail() call to look like his and also add the new $headers variable.

If you still don't receive the e-mail, you may need to add more headers (such as: Subject, MIME-Version, Content-Type, etc. - search the board for something like "email headers" to see how additional headers are usually added to e-mails).

XzorZ

Nope. 🙁 I tried what you guys said, aded that and stuff and it didn't work. What did you mean by add more headers? Like what?

bradgrafelman

XzorZ wrote:
What did you mean by add more headers? Like what?

Like the ones I listed, for starters. For examples, you can search the board, as I said.

XzorZ

Ok, I found some headers:

$headers = 'From: webmaster@example.com' . "\r\n" .
    'Reply-To: webmaster@example.com' . "\r\n" .
    'X-Mailer: PHP/' . phpversion();

I want to add them, but What do I put in the X-Mailer section?

NogDog

XzorZ wrote:
Ok, I found some headers:
$headers = 'From: webmaster@example.com' . "\r\n" .
    'Reply-To: webmaster@example.com' . "\r\n" .
    'X-Mailer: PHP/' . phpversion();
I want to add them, but What do I put in the X-Mailer section?

Exactly what you already have there. Remember to set the email address which follows "From:" to be a valid email address on your web host, and the email address which follows "Reply-To:" to whatever email address you would like replies to be sent to.

XzorZ

I'll repost my whole code:

<?php
$headers = "X-Mailer: PHP\n" . 
"Reply-to: exaple@host.com\n"; 
$company = $_REQUEST['company'];
$version = $_REQUEST['version'];
$quantity = $_REQUEST['quantity'];
$name = $_REQUEST['name'];
$phone = $_REQUEST['phone'];
// some basic email header injection prevention:
$email = preg_replace('/[\r\n]+/', ' ', $_REQUEST['email']);
$notes = $_REQUEST['notes'];

$msg = "$company
$quantity
$name
$phone
$email
$notes";

mail("example@ehost.com", "Ink Cartridge Order", $msg, $headers); 
header("Location: http://www.host.com");
?>

It works and takes me to the right site, without ANY errors, but I don't get the email still!

NogDog

<?php
// turn on all error messages:
ini_set('display_errors', 1);
error_reporting(E_ALL);

// get values from input form:
$company = $_REQUEST['company'];
$version = $_REQUEST['version'];
$quantity = $_REQUEST['quantity'];
$name = $_REQUEST['name'];
$phone = $_REQUEST['phone'];
// some basic email header injection prevention:
$email = preg_replace('/[\r\n]+/', ' ', $_REQUEST['email']);
$notes = $_REQUEST['notes'];

// define body of mail message:
$msg = "$company
$quantity
$name
$phone
$email
$notes";

// define email headers:
$headers  = "From: example@host.com\r\n";
$headers .= "Reply-To: $email\r\n";
$headers .= "X-Mailer: PHP/" . phpversion(); 

// add some debugging by checking return value:
$result = mail("example@ehost.com", "Ink Cartridge Order", $msg, $headers);
if(!$result)
{
   die("mail() call failed");
}

// if no error from mail, redirect to success page:
header("Location: http://www.host.com");
?>

Once again: Remember to set the email address which follows "From:" to be a valid email address on your web host.

XzorZ

Hey NogDog. I tried that and got:

Notice: Undefined index: company in /home/www/example.com/geeks/geeks.php on line 7

Warning: Cannot modify header information - headers already sent by (output started at /home/www/xzorz.com/geeks/geeks.php:7) in /home/www/example.com/geeks/geeks.php on line 37

So, I try to make sure everything in the html file is right, and it is, but I still get the error. So what I did is take the $Company part out, and it takes me to the page like it works, and I still don't get the email. hmmm

XzorZ

And I am pretty sure the From: email is on my web host. I am using Freehostia, and I have my domain, and domain name set up their. I have an email account by freehostia that is admin@thedomainiboughtfromfreehostia.com. I'm sure that's what you mean.

bpat1434

I don't think you're getting what he's saying. Your code doesn't set the "FROM" header. So the email can never be sent. Your code should look like:

<?php
$headers  = "From: admin@thedomainboughtfromfreehostia.com\r\n";
$headers .= "Reply-to: exaple@host.com\r\n";
$headers .= "X-Mailer: PHP/" . phpversion();

$company = $_REQUEST['company'];
$version = $_REQUEST['version'];
$quantity = $_REQUEST['quantity'];
$name = $_REQUEST['name'];
$phone = $_REQUEST['phone'];
// some basic email header injection prevention:
$email = preg_replace('/[\r\n]+/', ' ', $_REQUEST['email']);
$notes = $_REQUEST['notes'];

$msg = "$company
$quantity
$name
$phone
$email
$notes";

if(mail("example@ehost.com", "Ink Cartridge Order", $msg, $headers))
    header("Location: http://www.host.com");
else
    print_r(debug_backtrace());
?>

Now... what does that spit out at you?

One issue you had was the "From" header never being set in your script. The other is that you assumed that the mail() call would be completed successfully. What if the server rejects the email? How will you know? So wrapping that in an if() statement helps. The print_r(debug_backtrace()) just allows us to see what calls were made. Obviously we'll know... but it's better than nothing.

rulian

put

echo "<pre>";
print_r($_REQUEST);
echo "</pre>";

look at the output make sure everything is coming okay

XzorZ

Ok, I tried this: (Pay attention to the emails with domains)

<?php
$headers  = "From: admin@MYDOMAIN.com\r\n";
$headers .= "Reply-to: example@GMAIL.com\r\n";
$headers .= "X-Mailer: PHP/" . phpversion();

$company = $_REQUEST['company'];
$version = $_REQUEST['version'];
$quantity = $_REQUEST['quantity'];
$name = $_REQUEST['name'];
$phone = $_REQUEST['phone'];
// some basic email header injection prevention:
$email = preg_replace('/[\r\n]+/', ' ', $_REQUEST['email']);
$notes = $_REQUEST['notes'];

$msg = "$company
$quantity
$name
$phone
$email
$notes";

if(mail("example@GMAIL.com", "Ink Cartridge Order", $msg, $headers))
   header("Location: http://www.MYDOMAIN.com");
else
   print_r(debug_backtrace());
?>

And it looked like it worked, and it took me to the right site, but I didn't get the email. I then tried this, like rulian said:

<?php
$headers  = "From: admin@MYDOMAIN.com\r\n";
$headers .= "Reply-to: example@GMAIL.com\r\n";
$headers .= "X-Mailer: PHP/" . phpversion();

$company = $_REQUEST['company'];
$version = $_REQUEST['version'];
$quantity = $_REQUEST['quantity'];
$name = $_REQUEST['name'];
$phone = $_REQUEST['phone'];
// some basic email header injection prevention:
$email = preg_replace('/[\r\n]+/', ' ', $_REQUEST['email']);
$notes = $_REQUEST['notes'];

$msg = "$company
$quantity
$name
$phone
$email
$notes";

if(mail("example@GMAIL.com", "Ink Cartridge Order", $msg, $headers))
   header("Location: http://www.MYDOMAIN.com");
else
   print_r(debug_backtrace());
echo "<pre>";
print_r($_REQUEST);
echo "</pre>"; 
?>

On that, I added the:

echo "<pre>";
print_r($_REQUEST);
echo "</pre>";

I still didn't get the email. Is something with the email From: and Reply To: still wrong?

bpat1434

Take away the header redirect and give us the output of the script