Help me shorten this down

Undrium

I have a kind of complex (which I don't think should be that complex) code snippet occuring several of times on my homepage. What I want to do is to shorten it down, I just don't know how.Here it is:

$sql2 = "UPDATE boats SET click = $click, latest_ip = '$latest_ip', isp = '$isp' WHERE id = '$id'";
		@mysql_query($sql2);

Sincerely,

Undrium

edit: Figured I don't need a large part of it so I removed it. Is there anymore way to shorten it down?

maxpup979

$sql2 = "UPDATE boats SET click = $click, latest_ip = '$latest_ip', isp = '$isp' WHERE id = '$id'";
$result = @mysql_query($sql2) or die (mysql_error());

That should do the trick--you are running the query 3 times in that code--
if you need to test that the $result is valid, test on $restul, not by running the query again.

Hope that helps.

Undrium

Thanks, maxpup979. That looks even better, error reporting included and all! 🙂

rulian

Undrium wrote:
I have a kind of complex (which I don't think should be that complex) code snippet occuring several of times on my homepage. What I want to do is to shorten it down, I just don't know how.Here it is:
$sql2 = "UPDATE boats SET click = $click, latest_ip = '$latest_ip', isp = '$isp' WHERE id = '$id'";
		@mysql_query($sql2);
		
Sincerely,

Undrium

I would reocmment you not @mysql_quereis
it's better to:
if (!mysql_query($query)) echo mysql_error();
To handle actual erros. or set mysql_query to a variable, if the query goes through but finds thoughthing it should return false not error.