Fetch MIN and MAX from while open file

kumschick

Hi,

I want to fetch data from a text file with 2 col. and then to get once the MAX() and MIN() data out.

file.txt content:
2007-07-22 22:00|25,4
2007-07-22 22:05|29,0
2007-07-22 22:10|25,4
2007-07-22 22:15|20,8
2007-07-22 22:20|23,4

the output is once "23,4" and for the MAX it should be 29,0.
One part of the code works, but not the other one. I get get the MIN and MAX. I don't understand what wrong?. Could someone help me please?

$fp        = fopen("c:\\test\\file.txt", "r");
$last_line = count(file("c:\\test\\file.txt"));

if($fp>=1)
  {

   $i=0;
    while(feof($fp)==0)
      {
        $i++;
        $servertemp=chop(fgets($fp,256));


      if($i == $last_line)
        {
          if(!empty($servertemp))
            {
			  $the_last_entry = $servertemp;
			  $explode_last_entry = explode("|",$servertemp);
            }
        }

     $get_max = max($explode_last_entry[1]);
     $get_min = min($explode_last_entry[1]);

  }



  }
fclose($fp);

echo "Date & Time: $explode_last_entry[0]"; //this works
echo "Temperature: $explode_last_entry[1]"; //this works
echo "Max. Temp. : $get_max"; //this doesn't work
echo "Max. Temp. : $get_min"; //this doesn't work

NogDog

I'd probably do something like this:

<?php
$text = file("c:\\test\\file.txt");
$max = NULL;
$min = NULL;
$last = array();
foreach($text as $line)
{
   list($time, $temp) = explode('|', trim($line));
   $temp = str_replace(',', '.', $temp);
   if($max === NULL or $temp > $max)
   {
      $max = $temp;
   }
   if($min === NULL or $temp < $min)
   {
      $min = $temp;
   }
   $last['time'] = $time;
   $last['temp'] = $temp;
}
printf(
   "<p>Date &amp; Time: %s<br />Temperature: %s&deg;C<br />High: %s&deg;C<br />Low: %s&deg;C</p>\n",
   $last['time'],
   str_replace('.', ',', $last['temp']),
   str_replace('.', ',', $max),
   str_replace('.', ',', $min)
);

kumschick

I just tried your script, it works but doesn't do the right stuff.

in your script:
the max value is the first entry of my text file
the min value is the last entry of my text file

I do not want to first and last, but the biggest and smallest entry... 🙁

NogDog

I guess I'm confused. When I tested it, using this data...

2007-07-22 22:00|25,4
2007-07-22 22:05|29,0
2007-07-22 22:10|25,4
2007-07-22 22:15|20,8
2007-07-22 22:20|23,4

...I got this result:

Date & Time: 2007-07-22 22:20
Temperature: 23,4°C
High: 29,0°C
Low: 20,8°C

If that is not correct, then you will need to give me a better explanation as to what the data represents and what constitutes "max" and "min" values.

kumschick

Yes that's what I want, the High: is the highest temp and low the lowest temp.

But if I run your script that's not what I get. I receive a result something diffrent. I receive instead of the highest, the first of the list

and instead of the lowest, i get the last entry of the list...

script url: http://mrm.kumschicknw.com/test.mrm (your script)
text file: http://mrm.kumschicknw.com/data.txt

You will see by opening the link, that the result is wrong.... (for some reason that I don't understand...)

NogDog

See if this modification of the loop helps:

foreach($text as $line)
{
   list($time, $temp) = explode('|', trim($line));
   if($temp == 'err')
   {
      continue;
   }
   // rest of loop here as before
}

kumschick

yes, now it works, thx a lot