Invalid Table Join

user55

Hi,

I have this table join below and I am getting an invalid query. How can I put the 15th line ($sql .= " group.id = master.id\n"; and the 17th line ($sql .= " where ".$currentrow_sql ; together. Is it even possible to do that? Any help would be appreciated.

$sql .= " Select\n";
    $sql .= "     group.`id`,\n";
    $sql .= "     group.`amount`,\n";
    $sql .= "     group.`company`,\n";
    $sql .= "     group.`otherfee`,\n";
    $sql .= "     group.`total`,\n";
    $sql .= "     master.`id`,\n";
    $sql .= "     master.`section`,\n";
    $sql .= "     master.`year`,\n";
    $sql .= "     master.`location`\n";
    $sql .= " From\n";
    $sql .= "     group   group,\n";
    $sql .= "     master   master\n";
    $sql .= " Where\n";
    $sql .= "             group.id = master.id\n";
    if ($currentrow_sql != "") {
    $sql .= " where ".$currentrow_sql ;
  }
    $result =  mysql_query($sql) or die("Invalid query");
    $row = mysql_fetch_array($result);
}

Sara

alimadzi

I don't even know what you're asking. And why are you making so much work for yourself in your code? Have you heard of heredoc syntax?

http://us.php.net/manual/en/language.types.string.php#language.types.string.syntax.heredoc

I use it all the time for long queries.

And why do you define table aliases that match the table names? That doesn't make any sense.

Also instead of using die() with a useless error message, you should output mysql_error() and get some useful information.

Hope this helps.

rulian

also, if your if statement is true, you'll have 2 WHERE clauses, that will produce an error. if a second condition must be met, use AND or OR
exacmple

Select from foo WHERE a = b AND c = d
--- or ---
Select from foo WHERE a = b OR a = c

or a bunch of other combinations

Crowly

A simpler version of your select

$sql="SELECT g.id, g.amount, g.company, g.otherfee, g.total, m.id, m.section,  

m.year, m.location 
FROM group g, master m 
WHERE g.id = m.id";

if ($currentrow_sql != "") { 
// not sure what you want here, what is the value of $currentrow_sql ???
// might need to modify this more to get to work as intended
    $sql .= " AND ".$currentrow_sql ;

//print out $sql to check that it looks correct
// remove/comment out this when it is working as intended
echo "<div>".$sql."</div>";

//rest of your code