[RESOLVED] If, Elfe if statements

[raider00321]

Hey guys. I have another problem if some else if statements. I have a coding which should pass everything ok, and come say the end result Purchase complete, but instead it comes up with my other defined message 'This is not a number'. I beleive this is because of the ereg coding i am using, but am unsure to why it isnt working.

My code for this is:

<?php include "session.php";
	  include "Connect.php";
	  include "buildinginfo.php";
?>

<title>Building Transaction</title>

<?php
$userid=mysql_real_escape_string($userid);
$password=mysql_real_escape_string($password);
$userid=$_SESSION['userid'];
$password=$_SESSION['password'];
	  $_SESSION['userid']=$userid;
	 $_SESSION['password']=$password;
if($rec=mysql_fetch_array(mysql_query("SELECT * FROM $table WHERE userid='$userid' AND password = '$password'"))){
	if(($rec['userid']==$userid)&&($rec['password']==$password)){
	 $_SESSION[userid]=$userid;
	 $_SESSION[password]=$password;

 mysql_connect($servername,$dbusername,$dbpassword);
@mysql_select_db("$dbname");
$userstats="SELECT * FROM $table WHERE userid='$_SESSION[userid]'";
$userstats2=mysql_query($userstats);
$userstats3=mysql_fetch_array($userstats2);
$Sturdytentcost2=$Sturdytentcost*$SturdyTent;


if ($SturdyTent<0){ print "<CENTER><br><br>You cant build less than one building. Its just physically impossible<br><a href=buildings.php>click here to return</a></CENTER>";}
	 else if ($userstats3[gold]<$Sturdytentcost){print "<CENTER><br><br><br>Insufficient funds for this purchase ot you cannot order under   					0 buildings<br><a href=buildings.php>click here to return</a></CENTER>";}
	 else if (ereg ("([0-9]{1,9})", $SturdyTent, $regs)){ 
$updatetotalpop2="UPDATE $table SET SturdyTent=SturdyTent+'$SturdyTent', gold=gold-$Sturdytentcost2,middleclasspop=middleclasspop+'$sturdytentpop'*'$SturdyTent',middleclassunemployent =middleclassunemployent +'$sturdytentpop'*'$SturdyTent' WHERE userid='$_SESSION[userid]'";
           mysql_query($updatetotalpop2) or die("error with SturdyTent. Please report to Admin");
	print "<CENTER><br><br><br>Purchase complete<br><a href=buildings.php>click here to return</a></CENTER>";
	}else{
		print "<CENTER><br><br><br>This is not a number<br><a href=buildings.php>click here to return</a></CENTER>";}

}}


?><style type="text/css">
<!--
body,td,th {
	color: #990000;
}
body {
	background-color: #000000;
}
-->
</style>

Like is said before, i think its because of the ereg statement but im really not too sure, Thanks for any help given

[NogDog]

The way your code is structured, that error message will be displayed if the IF condition and each of the two ELSE IF condtions above that ELSE evaluate as false; so it is not necessarily the ereg() condition where the problem is occurring.

My first suggestion would be to echo out each of the variables being used in those conditions and make sure they all have the values you are expecting them to have.

[raider00321]

ok, the first if statement is meant is meant to make it so that the user cannot build less than0 buildings.
The first else if statment is mean to make sure that you have more gold than the cost of the specified buildings
The second statement is to ensure that you can only add a numerical value and up to nine numeral numbers... From what i checked it is set up to be like that. The reason i know that it is the ereg is because if the person had less money, it would display another message stating you dont have enough money..... I also changed it to echo, but it still didnt seem to work..

[NogDog]

As far as I can tell, the ereg should work. I'd probably use this logic (and use the faster preg function):

if(preg_match('/^\d{1,9}$/', $SturdyTent)
{
   if($SturdyTent >= 0)
   {
      if($userstats3[gold] >= $Sturdytentcost)
      {
         // everything is OK, so update DB
      }
      else
      {
         // error message for not enough gold
      }
   }
   else
   {
      // error message for $SturdyTent < 0
   }
}
else
{
   // error message for non-numeric $SturdyTent value
}

[raider00321]

Ok, i changed it to how you said like:

if(preg_match('/^\d{1,9}$/', '$SturdyTent'))
{
   if($SturdyTent >= 0)
   {
      if($userstats3[gold] >= $Sturdytentcost)
      {
         $updatetotalpop="UPDATE $table SET gold=gold-'$Basictentcost'*'$SimpleTent',SimpleTent=SimpleTent+'$SimpleTent',lowerclasspop=lowerclasspop+'$basictentpop'*'$SimpleTent',lowerclassunemployment=lowerclassunemployment+'$basictentpop'*'$SimpleTent' WHERE userid='$_SESSION[userid]'";
           mysql_query($updatetotalpop) or die("error With Simple Tent. Please report to Admin");
	echo "<CENTER><br><br><br>Purchase complete<br><a href=buildings.php>click here to return</a></CENTER>";
      }
      else
      {
        echo "<CENTER><br><br><br>Insufficient funds for this purchase</CENTER>";
      }
   }
   else
   {
     echo "<CENTER>you cannot order less than 1 buildings<br><a href=buildings.php>click here to return</a></CENTER>";
   }
}
else
{
  echo "<CENTER><br><br><br>thats not a number<br><a href=buildings.php>click here to return</a></CENTER>";
}}}

but the thing is still appearing...

[NogDog]

Just a hunch: try trimming $SturdyTent before using it, in case there are any spaces, newlines, etc. around it:

$SturdyTent = trim($SturdyTent);

[raider00321]

hmm i just put that infront of the if statement and still nothing...

[NogDog]

Have you echoed out the variables yet to see if they really are set and with the expected values? For instance, at least while debugging you could make the error message:

echo "<CENTER><br><br><br>'$SturdyTent' is not a number<br><a href=buildings.php>click here to return</a></CENTER>";

This way you don't continue spending time on this part of the code if the actual problem is wherever the value of $SturdyTent is supposed to get set.

[raider00321]

well, the varibles werent appearing properly so i fixed it by declaring the post from the previous page so now it is, but now they are saying things such as '1 is not a number'

[NogDog]

Last idea, still just to see if it's some sort of input data problem, try adding this line right before the whole if/else thing begins:

$SturdyTent = (int) $SturdyTent;

This will cast whatever value $SturdyTent contains to an integer type, being sure to get rid of any non-printing characters that may be stored in its value for some reason. If you still get the "not a number" error message after that, I give up. 😉

[raider00321]

Ok, thanks m8! even if ya haven't fully hit the nail on the head, u always seem to help me get my brain moving and find an answer! You've been a great help 😃