[RESOLVED] Why is my code by-passing the while loop?

[wcboyd]

Hello all,

In the following code I have a nested while loop (the one in red) which is being ignored. Any ideas why?

<?php
$fp1 = fopen('input.xml', 'r'); /*this is the CMI file */
$fp2 = fopen('output.txt','w');
$ClassTableName = ' ';
$CharArr01 = array();
$RootFlag=0;
$count=0;

/*write XML file header */

while($count<4) {
	$cmi_read = fgets($fp1, 999);
	fwrite($fp2, $cmi_read);
	$count = $count + 1;
}


while (!feof($fp1)) /*loop thru til end of file */
{
	$cmi_read = fgets($fp1, 999);
	if (strstr($cmi_read, '<class>'))
	{
	fwrite($fp2, $cmi_read);
		[COLOR="Red"]While ($EndOfClass = 0)[/COLOR]
	    {
		$cmi_read = fgets($fp1, 999);
        fwrite($fp2, $cmi_read);
        if (strstr($cmi_read, '</class>'))
	        {     

        $EndOfClass = 1;
	        }
	    }
    }
    $EndOfClass = 0;
}
fclose($fp1);
fclose($fp2);
?>

Thanks,

Craig

PHP v5.2.3 / Windoze / Using PHP from the Command Prompt

[rulian]

While ($EndOfClass = 0) sets $EndOfClass to 0 - so will loop indefinately
While ($EndOfClass == 0) compares $EndsOfClass to zero will loop until you change the value of $EndOfClass

[laserlight]

You should use [man]strpos/man instead of strstr(). For example:

while (!feof($fp1))
{
	$cmi_read = fgets($fp1, 999);
	if (strpos($cmi_read, '<class>') !== false)
	{
		fwrite($fp2, $cmi_read);
		do
		{
			$cmi_read = fgets($fp1, 999);
			fwrite($fp2, $cmi_read);
		} while (strpos($cmi_read, '</class>') === false);
	}
}

Just to clarify on what rulian wrote: it is not the loop highlighted in red that is the infinite loop, it is the outer loop that is the infinite loop since the body of the inner loop is never entered.

[wcboyd]

Rulian & Laserlight,

Thank you very much! I will make the suggested changes and see what happens.

Laserlight, being the noob that I am, why should I use strpos() over strstr()?

[NogDog]

From the [man]strstr[/man] page:

Note: If you only want to determine if a particular needle occurs within haystack, use the faster and less memory intensive function strpos() instead.

[wcboyd]

That did it!!!!
Thank you all!!!