[RESOLVED] Inserting values through a form

naskar

Hi there, I managed to roughly code a form whereby I can enter values through the form into a datbase. It doesnt work (not suprisingly, I was in a hurry)

Anybody know whats wrong?

<?php
if(isset($_POST['button']))
{
$model = $_POST['model'];
$c3insert = $_POST['c3insert'];
$reviewer = $_POST['reviewer'];
$complete = $_POST['complete'];
$comments = $_POST['comments'];

$connection = mysql_connect("localhost","root","root");
mysql_select_db("test", $connection);

$query = "INSERT INTO Reviews VALUES (".$model." , ".$c3insert." , ".$reviewer." , ".$complete." , ".$comments." )";


$result = $connection->query($query);

}
else
{
?>

 <form name="form1"  method="POST" action="<?php $_SERVER[PHP_SELF] ?>">

Model
<input type="text" name="model" value="All"> 
C3 Insert
<input type="text" name="c3insert" value="All"> 
Reviewer
<input type="text" name="reviewer" value="All"> 
Complete
 <input type="text" name="complete" value="All"> 
Comments
 <input type="text" name="comments" value="All"> 


<br><input type="submit" value="Update list">
<input type="text" name="text1" /> <input type="submit" name="button" />
  </form>
<?php }  ?>

tams

$query = "INSERT INTO Reviews VALUES (".$model." , ".$c3insert." , ".$reviewer." , ".$complete." , ".$comments." )";

Before you enter the values you need to specify the fields/columns it is supposed to go into. For example

$query = "INSERT INTO Reviews (model, insert, reviewer, complere, comments) VALUES (".$model." , ".$c3insert." , ".$reviewer." , ".$complete." , ".$comments." )";

You could do it without the fields too but it might cause some confusion if you more columns and you are only inserting into a few of those columns.

bradgrafelman

You also have to surround the values with quotes if they are text (just like you do in PHP).

In addition, if you're having problems with MySQL queries, you should paste the error message returned by the MySQL server for us.

naskar

When i click the submit button it gives me this error

Fatal error: Call to a member function query() on a non-object in C:\Program Files\Apache Software Foundation\Apache2.2\htdocs\database_add.php on line 33

Line 33 :

$result = $connection->query($query);

Just wondering, How do i code the If !query die connection statement?

naskar

Brad, I'm not quite sure I follow you

$query = "INSERT INTO Reviews (model, C3 insert, reviewer, complete, comments) VALUES (".$model." , ".$c3insert." , ".$reviewer." , ".$complete." , ".$comments." )";

1) Surrounded by single quotes or double
2) One of the fields in the Table has a space in its name, Do i surround that field with quotes, "C3 Insert" ?

NogDog

naskar wrote:
Brad, I'm not quite sure I follow you
$query = "INSERT INTO Reviews (model, C3 insert, reviewer, complete, comments) VALUES (".$model." , ".$c3insert." , ".$reviewer." , ".$complete." , ".$comments." )";
1) Surrounded by single quotes or double
2) One of the fields in the Table has a space in its name, Do i surround that field with quotes, "C3 Insert" ?

Since the query is in double-quotes, you can just put your variable names in there without having to concatenate with periods. The table name with a space must be enclosed in "back-tick" quotes (usually the key to the left of the "1" key), though this sort of indicates that it's probably better to use underscores instead of spaces in such names.

$query = "INSERT INTO Reviews (model, `C3 insert`, reviewer, complete, comments) VALUES ('$model', '$c3insert', '$reviewer', '$complete', '$comments')";

naskar

Gotcha, thanks NogDog!

Although the values are still not getting entered

I get the error

Fatal error: Call to a member function query() on a non-object in C:\Program Files\Apache Software Foundation\Apache2.2\htdocs\database_add.php on line 33

NogDog

Looks like you are trying to mix in some object-oriented calls within procedural-style mysql() functions. Since most of it is using mysql functions, the quickest change would be to change the line where you execute the query to:

$result = mysql_query($query);
// and for some debug info if needed:
if(!$result)
{
   die("Query failed ($query): " . mysql_error());
}

naskar

It seems to be working now!

I have my while loop set up as follows:

 while ($row = mysql_fetch_array($result, MYSQL_NUM))
{


  foreach ($row as $attribute)
  {
	print "<td>{$attribute}</td>";
	print "";
  }



 print "</tr>";
}

I am planning to include a Link on each row called Delete, anyone know how I would access the identifier for each row to send it to another page to be deleted?

e.g.

What would I use in my case to differentiate each row?