[RESOLVED] dynamic row height

[assgar]

Hi

I am having a problem with the height of my dynamically create rows.
The data is retrived properly form the database, the issue is displaying the rows.

When there are alot of results to dusplay the rows are displayed correctly.
If there are a few rows the hight can be 3 times the height as when there alot of rows.

Note: Below is a simplified version of the code.

<?php	
     $query = "SELECT  event_id, event_date, event_time
 	       FROM cal_appointment
 	       WHERE status = 'A'
 	       ORDER BY event_date, event_time";


 $result = mysqli_query($mysqli, $query) or die('Error, query failed');

   /************************ this section displays the events*************************/


   echo "<table width=\"100%\"  border=\"0\">";
    echo"<tr align=\"center\" bgcolor=\"#FFFFFF\">";
     echo" <td width=\"100%\" >
     <div id=\"Layer2\" style=\"position:absolute; width:100%; height:100px; z-index:2; left: 8px; top: 310px;\">
     <div id=\"scroll-box2\" style=\"overflow: auto; float: left; width: 100%; height: 240px;  margin: 5px; \">\n";

  //table begins
  echo "<table width=\"98%\" height=\"310\" left =\"4\" border=\"0\" font face =\"arial\">\n";

  $result = mysqli_query($mysqli,$query) or die('Error, query failed');
  $num_rows = mysqli_num_rows($result);
  for($i=0; $i < $num_rows; $i++)
{

    $row = mysqli_fetch_array($result);

    list($event_id, $event_date, $event_time) = $row;


    /**convert 24hr time to 12 hr**/
    list($hour, $min, $sec) = split(":",$event_time);

     if($hour > 12)
       {
       	 $time_hour = $hour - 12;
       }
       else
	   {
		$time_hour = $hour;
	   }

     //format time of day
      if($hour < 12)
          {
	     $tod = "AM";
	  }
	  else
	      {
		  $tod = "PM";
	      }

     $time = "$hour:$min $tod";

     echo "<tr>";
     echo"<td width=\"18%\" height=\"15\" align=\"center\">$time</td>
	  <td width=\"12%\"  height=\"15\">$event_date</td>\n";
         echo "</tr>";

  }//end for

 echo "</table>";
 echo "</td>";
 echo "</tr>";
 echo "</div>";
 echo "</div>";
 echo "</table>";

}

?>

[assgar]

assgar wrote:

Hi

I am having a problem with the height of my dynamically create rows.
The data is retrived properly form the database, the issue is displaying the rows.

When there are alot of results to dusplay the rows are displayed correctly.
If there are a few rows the hight can be 3 times the height as when there alot of rows.

Note: Below is a simplified version of the code.

<?php	
     $query = "SELECT  event_id, event_date, event_time
 	       FROM cal_appointment
 	       WHERE status = 'A'
 	       ORDER BY event_date, event_time";


 $result = mysqli_query($mysqli, $query) or die('Error, query failed');

   /************************ this section displays the events*************************/


   echo "<table width=\"100%\"  border=\"0\">";
    echo"<tr align=\"center\" bgcolor=\"#FFFFFF\">";
     echo" <td width=\"100%\" >
     <div id=\"Layer2\" style=\"position:absolute; width:100%; height:100px; z-index:2; left: 8px; top: 310px;\">
     <div id=\"scroll-box2\" style=\"overflow: auto; float: left; width: 100%; height: 240px;  margin: 5px; \">\n";

  //table begins
  echo "<table width=\"98%\" height=\"310\" left =\"4\" border=\"0\" font face =\"arial\">\n";

  $result = mysqli_query($mysqli,$query) or die('Error, query failed');
  $num_rows = mysqli_num_rows($result);
  for($i=0; $i < $num_rows; $i++)
{

    $row = mysqli_fetch_array($result);

    list($event_id, $event_date, $event_time) = $row;


    /**convert 24hr time to 12 hr**/
    list($hour, $min, $sec) = split(":",$event_time);

     if($hour > 12)
       {
       	 $time_hour = $hour - 12;
       }
       else
	   {
		$time_hour = $hour;
	   }

     //format time of day
      if($hour < 12)
          {
	     $tod = "AM";
	  }
	  else
	      {
		  $tod = "PM";
	      }

     $time = "$hour:$min $tod";

     echo "<tr>";
     echo"<td width=\"18%\" height=\"15\" align=\"center\">$time</td>
	  <td width=\"12%\"  height=\"15\">$event_date</td>\n";
         echo "</tr>";

  }//end for

 echo "</table>";
 echo "</td>";
 echo "</tr>";
 echo "</div>";
 echo "</div>";
 echo "</table>";

}

?>

Hi

🆒

The problem is solved.

I removed the explicitly set the table height.
This prevents the rows from filling
the available height.

<?php
 echo "<table width=\"100%\"  border=\"0\">";
    echo"<tr align=\"center\" bgcolor=\"#FFFFFF\">";
     echo" <td width=\"100%\" >
     <div id=\"Layer2\" style=\"position:absolute; width:100%; height:100px; z-index:2; left: 8px; top: 310px;\">
     <div id=\"scroll-box2\" style=\"overflow: auto; float: left; width: 100%; height: 240px;  margin: 5px; \">\n";

  //table begins
  echo "<table width=\"98%\" height=\"\" left =\"4\" border=\"0\" font face =\"arial\">\n";

?>

[paulnaj]

Hi there,

Wrote this before seeing your second post ... might help anyway.

It was very difficult to actually read your code.

I couldn't resist tarting up your code to be a bit more readable. I noticed a couple of things ...

(1) You had a 'font face' attribute and a 'left' attribute in the TABLE tag
(2) You put the closing < /TR > in the wrong order ( at the end of the table).

Anyway, the row-height thing could just be a problem of HTML itself. I notice that you are using both HTML attributes and CSS ... often a major source of TABLE headaches. Try using one method or the other, not both.

Here's the cleaned up code:

<?php 
$query = "SELECT  event_id, event_date, event_time
FROM cal_appointment
WHERE status = 'A'
ORDER BY event_date, event_time";


$result = mysqli_query($mysqli, $query) or die('Error, query failed');

/************************ this section displays the events*************************/


echo '
<table width="100%" border="0">
	<tr align="center" bgcolor="#FFFFFF">
		<td width="100%">
			<div id="Layer2" style="position:absolute; width:100%; height:100px; z-index:2; left: 8px; top: 310px;">
				<div id="scroll-box2" style="overflow: auto; float: left; width: 100%; height: 240px;  margin: 5px;">
					<table width="98%" height="310" border="0">';

$result = mysqli_query($mysqli,$query) or die('Error, query failed');
$num_rows = mysqli_num_rows($result);
for($i=0; $i < $num_rows; $i++){
	$row = mysqli_fetch_array($result);
	list($event_id, $event_date, $event_time) = $row;

list($hour, $min, $sec) = split(":",$event_time);
/**convert 24hr time to 12 hr**/
$time_hour = $hour > 12? $hour - 12: $hour;
//format time of day
$tod = $hour < 12? "AM": "PM";
$time = $hour.':'.$min.' '.$tod;

echo '
					<tr>
						<td width="18%" height="15" align="center">'.$time.'</td>
						<td width="12%" height="15">'.$event_date.'</td>
					</tr>';
}//end for

echo '
					</table>
				</td>
		        </div>
	        </div>
	</tr>
</table>
'; 
?>