A php/Javascript submition issue

CadeHuff

Ok folks, here is the skinny. I am putting multiple links down that are dependent on the name of a licensee. I am trying to be able to submit the one clicked on and the page is submitted to itself.

PHP Code:

//create the text display area
<td colspan="9" rowspan="3" width="950">
//form that calls itself
<form name="calllink" action="<? $_SERVER['PHP_SELF']?>">
<?
//Automatically pulls the matching callsigns and places them in the Links field
 $query = "SELECT Callsign FROM fcc WHERE LicenseeName = '" .  

	 str_replace("\\'","\'",str_replace("'","\'",$row['LicenseeName'])) . "'";
$result2 = mysql_query($query);

//create the needed links in the Links area.
while($row2 = mysql_fetch_array($result2,MYSQL_NUM))
{
 $output .= "<input type=hidden name=callsign><input type=button onclick=getlink(calllink, callsign, \"$row2[0]\") value=submit1>
<a href=javascript:getlink(calllink, callsign, \"$row2[0]\")>$row2[0]</a>" . ", ";
        }
$output = substr($output,0,-2);

?>

//output all the text links in the links text area
<? echo str_replace("\\'","\'",str_replace("'","\'",$output)); ?>
//end of calllink form
</form>
//end of link text area
</td>

Header Script:

<script>
function getlink(form,name,link)
{
form.name.value=link;
form.submit();
}
</script>

As it stands, the links appear as they should, but when I click on the link, I get an error on page.

I am asking for any feedback on what I may be doing wrong. I am a total beginner with javascript and I am just trying to do this instead of buttons as it takes less space and maintains the form layout and style.

Any suggestions would be welcome and appreciated.

Thank you,

Cade

P.S. I have tried several different methods to accomplish my ends, but so far all are a failure. I am thinking that my javascript may be the culprit in this. Though at this time, it could be either the php or javascript.

slindstr

I haven't had a chance to actually try this so it's kind of a shot in the dark, but if it doesn't work maybe it will help get you in the right direction 🙂

<form name="calllink" action="<? $_SERVER['PHP_SELF']?>"> 

<? 
	$query = "SELECT Callsign FROM fcc WHERE LicenseeName = '" .   

     			str_replace("\\'","\'",str_replace("'","\'",$row['LicenseeName'])) . "'"; 

$result2 = mysql_query($query); 


while($row2 = mysql_fetch_array($result2,MYSQL_NUM)) 
{ 
	$output .= "<input type=hidden name=callsign>".
	           "<input type=button onclick=getlink('calllink', 'callsign', '{$row2[0]}') value=submit1>". 
 	           "<a href=javascript:getlink('calllink', 'callsign', '{$row2[0]}')>{$row2[0]}</a>" . ", "; 
} 

$output = substr($output,0,-2); 

?> 


<? echo str_replace("\\'","\'",str_replace("'","\'",$output)); ?> 

</form>

<script> 
function getlink(form,name,link) 
{ 
	document.form.name.value=link; 
	document.form.submit(); 
} 
</script>

The only things I changed (aside from taking out the comments and the formatting a little bit) was to add single quotes around your javascript function arguments and sticking 'document' in your function getlink. I also put {curly braces} around your array values because as far as I know you need to have them whenever you are referencing an array within double quotes.

Also, you should really put quotes around your html tag attributes - it makes for less confusion which makes it easier to maintain and there is also no chance of messing something up like this:

<a href=www.google.comonClick=getlink('stuff', 'goes', 'here')>google</a>

Hope this helps
Steve

CadeHuff

Thanks for your advices Steve. I will remember it for future use.

Unfortunately, I am still having errors with the link submission. It does not submit the form as expected. Just gives an error on page message.

The normal submit button, of course, still works. I have both available on my test setup so that I can try them both, just so you know why I have the button then the link in the output.

If you or anyone else might be able to help me with the script to submit the link, I would appreciate it.

Cade

P.S. Without the submit1 button, the link still has the error on page. From this point on, it looks like the javascript to submit the form is the culprit. I have followed examples, so I am not sure where I might have gone wrong.

paulnaj

Hi Cade,

Is there any special reason why are using a form here? ... you could just append the required variables to a url ...

<?php /* Don't use the short opening php tags */

// Not quite sure *why* you're doing these str_replaces()
$ln = str_replace("\\'","\'",str_replace("'","\'",$row['LicenseeName']));

// I always layout SQL to make it as readable as poss
$query = "
	SELECT Callsign 
	FROM fcc 
	WHERE LicenseeName = '".$ln."'
"; 
$result2 = mysql_query($query);

while($row2 = mysql_fetch_row($result2)){ 
	$callsign = $row2[0];
	$href = $_SERVER['PHP_SELF'].'?callsign='.$callsign;
?>
	<a href="<?php echo $href; ?>"><?php echo $callsign; ?></a> 
<?php
}
?>

Is that any help?
(Can't actually debug it that easy as I can't connect to your db!!)

Paul. 🙂

PS If you do need to use forms then there's quite a few things to clear up on the form itself, as well as the javascript.

NogDog

If I'm understanding things correctly, each button will need to be in a separate form; so the <form> and </form> tags would be moved inside of the loop, adding them to the output string for each iteration.