better way to code this

[jasondavis]

Below is the most commonly used function on my site, its used hundreds of times per minute probably thousands, Just curious if it could be improved to perform even better?

// show user photo
function show_user_photo($user_id,$photo_type='big',$user_name='yes',$online='yes'){
$LOCALIP=$_SERVER['REMOTE_ADDR'];
$sql_check="select * from friend_reg_user where auto_id='$user_id'";
$result_check=executeQuery($sql_check);  

if($line_check=mysql_fetch_array($result_check)){
// checking for user exist 
$sql_photo="select * from friend_user_photo  where userid='$user_id' and defaultphoto='yes' order by auto_id desc";
$result_photo=executeQuery($sql_photo);  

$pic1=''; $pic=''; $file='';
if($photo_type=='big'){
$noimg='nopic.gif';
} else {
$noimg='noimagesmall.jpg';
}
if($line_photo=mysql_fetch_array($result_photo)){
$file="uploded_files/userphoto/".$line_photo['photo_name'];
if($line_photo['photo_name']!='' && file_exists($file)){
$fil_ext1 = pathinfo($file);
$fil_ext = $fil_ext1["extension"];
$fil_explode='.'.$fil_ext;
$arr=explode($fil_explode,$line_photo['photo_name']);
if($photo_type=='big'){
$pic1=$arr[0]."_thumb".$fil_explode; 
$height=130;
$width=160;

} else {
$pic1=$arr[0]."_thumb1".$fil_explode;
$height=80;
$width=90;
}
if(file_exists("uploded_files/userphoto/".$pic1)){ 
$img_name=$pic1;
} else {
$img_name=$noimg;
} } else {
$img_name=$noimg;
} } else {
$img_name=$noimg;
}
echo "<div style='height:$height;width:$width; overflow:hidden' align='center'><a href='index.php?action=memberprofile&type=common&userid=$user_id&unid=$_GET[unid]'><img src='uploded_files/userphoto/$img_name'    border=0></a></div>";
if($user_name=='yes'){
   $sql="select disp_name from friend_reg_user where auto_id='$user_id'";
   $name=getSingleResult($sql);
   echo "<div align='center' class='boldblue' valign='middle'>";
   if(check_online_status($user_id,$LOCALIP) && $online=='yes'){ 
	echo "<img src='images/online.gif' >"; } echo $name; 
	   echo "</div>";
 } else {
	 if(check_online_status($user_id,$LOCALIP) && $online=='yes'){ 
	  echo "<div align='center' class='boldblue' valign='middle'><img src='images/online.gif' ></div>";
   	}  

 }
} else {
   if($photo_type=='big'){ $noimg='noexist.jpg'; }
   else { $noimg='noexist1.jpg'; }
   echo "<div style='height:$height;width:$width; overflow:hidden' align='center'><img src='uploded_files/userphoto/$noimg'    border=0></div>";

 }

[alimadzi]

Hard to follow due to lack of indentation, but a cursory glance reveals two "SELECT *" queries. Do you really need every column returned? Minor performance gain, but worthwhile if this is high traffic.

[Shrike]

Could the first two queries be reduced to just one?

select t1.auto_id, t2.photo_name from friend_reg_user t1
inner join friend_user_photo t2 on t1.userid = t2.userid
where t1.auto_id='$user_id'

You only seem to be using one row from the table friend_user_photo, so the order by clause might be redundant?

You might apply the same idea to the third query. But I agree the lack of formatting is hurting my head now 🙂

[xblue]

I re-indented your code to make it easier to read. I do not quite understand the need for the last query, didn't you select everything from table friend_reg_user for that auto_id in the first query? Maybe I'm overlooking something anyway.

// show user photo
function show_user_photo($user_id,$photo_type='big',$user_name='yes',$online='yes')
{
    $LOCALIP=$_SERVER['REMOTE_ADDR'];
    $sql_check="select * from friend_reg_user where auto_id='$user_id'";
    $result_check=executeQuery($sql_check);
    if ($line_check=mysql_fetch_array($result_check)) {
        // checking for user exist
        $sql_photo="select * from friend_user_photo  where userid='$user_id' and defaultphoto='yes' order by auto_id desc";
        $result_photo=executeQuery($sql_photo);
        $pic1='';
        $pic='';
        $file='';
        if ($photo_type=='big') {
            $noimg='nopic.gif';
        } else {
            $noimg='noimagesmall.jpg';
        }
        if ($line_photo=mysql_fetch_array($result_photo)) {
            $file="uploded_files/userphoto/".$line_photo['photo_name'];
            if ($line_photo['photo_name']!='' && file_exists($file)) {
                $fil_ext1 = pathinfo($file);
                $fil_ext = $fil_ext1["extension"];
                $fil_explode='.'.$fil_ext;
                $arr=explode($fil_explode,$line_photo['photo_name']);
                if ($photo_type=='big') {
                    $pic1=$arr[0]."_thumb".$fil_explode;
                    $height=130;
                    $width=160;

            } else {
                $pic1=$arr[0]."_thumb1".$fil_explode;
                $height=80;
                $width=90;
            }
            if (file_exists("uploded_files/userphoto/".$pic1)) {
                $img_name=$pic1;
            } else {
                $img_name=$noimg;
            }
        } else {
            $img_name=$noimg;
        }
    } else {
        $img_name=$noimg;
    }
    echo "<div style='height:$height;width:$width; overflow:hidden' align='center'><a href='index.php?action=memberprofile&type=common&userid=$user_id&unid=$_GET[unid]'><img src='uploded_files/userphoto/$img_name'    border=0></a></div>";
    if ($user_name=='yes') {
        $sql="select disp_name from friend_reg_user where auto_id='$user_id'";
        $name=getSingleResult($sql);
        echo "<div align='center' class='boldblue' valign='middle'>";
        if (check_online_status($user_id,$LOCALIP) && $online=='yes') {
            echo "<img src='images/online.gif' >";
        }
        echo $name;
        echo "</div>";
    } else {
        if (check_online_status($user_id,$LOCALIP) && $online=='yes') {
            echo "<div align='center' class='boldblue' valign='middle'><img src='images/online.gif' ></div>";
        }
    }
} else {
    if ($photo_type=='big') {
        $noimg='noexist.jpg';
    } else {
        $noimg='noexist1.jpg';
    }
    echo "<div style='height:$height;width:$width; overflow:hidden' align='center'><img src='uploded_files/userphoto/$noimg'    border=0></div>";      
}
}

[jasondavis]

Somebody tried to change it to this which almost worked except if a user had no image set as default it would not show there name anymore

// show user photo
function show_user_photo($user_id,$photo_type='big',$user_name='yes',$online='yes'){
$LOCALIP=$_SERVER['REMOTE_ADDR'];
$UINFO=mysql_fetch_array(mysql_query("select * from friend_reg_user f,friend_user_photo p where p.userid=f.auto_id and f.auto_id='$user_id'"));
//$sql_check="select * from friend_reg_user where auto_id='$user_id'";
//$result_check=executeQuery($sql_check); 
				if($photo_type=='big'){
				$noimg='nopic.gif';
				} else {
				$noimg='noimagesmall.jpg';
					} 
				$img_name=$noimg;	
//if($line_check=mysql_fetch_array($result_check)){
if($UINFO){
			// checking for user exist 
			$sql_photo="select * from friend_user_photo  where userid='$user_id' and 		defaultphoto='yes' order by auto_id desc";
			$result_photo=executeQuery($sql_photo);  

    		$pic1=''; $pic=''; $file='';
		//if($UINFO=mysql_fetch_array($result_photo)){
				$file="uploded_files/userphoto/".$UINFO['photo_name'];
					if($UINFO['photo_name']!='' && file_exists($file)){
							$arr=explode(".",$UINFO['photo_name']);
				if($photo_type=='big'){
					$pic1=$arr[0]."_thumb.".$arr[1]; 
					$height=130;
					$width=160;
				} else {
				$pic1=$arr[0]."_thumb1.".$arr[1];
				$height=80;
				$width=90;
				}
					if(file_exists("uploded_files/userphoto/".$pic1)){ 
					$img_name=$pic1;
						}
					}
		//}				
echo "<div style='height:$height;width:$width; overflow:hidden' align='center'><a href='index.php?action=memberprofile&type=common&userid=$user_id&unid=$_GET[unid]'><img src='uploded_files/userphoto/$img_name'    border=0></a></div>";
    	if($user_name=='yes'){
//   $sql="select disp_name from friend_reg_user where auto_id='$user_id'";
 //  $name=getSingleResult($sql);
   echo "<div align='center' class='boldblue' valign='middle'>";
		   if(check_online_status($user_id,$LOCALIP) && $online=='yes'){ 
			echo "<img src='images/online.gif' >"; } echo $UINFO[disp_name]; 
	   echo "</div>";
	 	} else {
		 if(check_online_status($user_id,$LOCALIP) && $online=='yes'){ 
	  echo "<div align='center' class='boldblue' valign='middle'><img src='images/online.gif' ></div>";
   				}  

        }
} else {
   if($photo_type=='big'){ $noimg='noexist.jpg'; }
   else { $noimg='noexist1.jpg'; }
   echo "<div style='height:$height;width:$width; overflow:hidden' align='center'><img src='uploded_files/userphoto/$noimg'    border=0></div>";
 }
}