Why isn't this header() working?

[msimonds]

I have this script

<?php
/**
 * @author Mike Simonds
 * @copyright 2007
 */
session_start();

error_reporting(E_ERROR | E_WARNING | E_PARSE | E_NOTICE);
require_once ('./includes/SforcePartnerClient.php');
require_once ('./includes/SforceHeaderOptions.php');
require_once ('./includes/functions_sforce.php');
include ('header.inc');
$errors = null;

/**
 * Checks to see if the user has submitted his
 * username and password through the login form,
 */
if (isset($_POST['login']))
{
    /* Check that all fields were typed in */
    if (!$_POST['user'] || !$_POST['pass'])
    {
        global $errors;
        $errors = ('Please fill in both username and password.');
    }
    else
    {
        /* Spruce up username, check length */
        $_POST['user'] = trim($_POST['user']);

    try
    {
        /* Checks that username and password are correct */
        $result = login($_POST['user'], $_POST['pass']);

        if (isset($result))
        {
            header( "Location: index.php" );
        }
    }
    catch (exception $e)
    {
        print_r($e);
    }
}
}

global $errors;
if (isset($errors))
{
    echo '<p><span style=\"color:#FF0000\">$errors</span></p>';
}
?>

<div id="container">
    <h3>Salesforce.com Login</h3>

<form action="<?=$_SERVER['PHP_SELF']?>" method="post">
  <!--Begin Fieldset Container For Login-->

  <fieldset>
    <legend>Login</legend>

    <div class="reqfield">
      <label id="lbluname" for="username">Username:</label> <input name="user" id="username" class="textbox" type="text" title="Enter your username" />
    </div>

    <div class="reqfield">
      <label id="lblpass" for="password">Password:</label> <input name="pass" id="password" class="textbox" type="password" title="Enter your password" />
    </div>

    <div class="reqfield" style="text-align: center;">
      <br />
      <input name="login" class="submit" value="Login" type="submit" />
    </div>
  </fieldset>
</form>
  </div>

<?php
  include ('footer.inc');
?>

and I am testing the login, but I am getting a header error because of the html in the header.inc, but I thought that if you checked the $result, you could use header() ?

Is there a way around this

TIA,
mike

[msimonds]

I thought that I should include the login() function:

function login($username, $password)
{
    global $errors;
    $wsdl = './includes/partner.wsdl.xml';
    $loginResult = null;
    try
    {
        $client = new SforcePartnerClient();
        $client->createConnection($wsdl);
        $loginResult = $client->login($username, $password);

    $_SESSION['location'] = $client->getLocation();
    $_SESSION['sessionId'] = $client->getSessionId();
    $_SESSION['wsdl'] = $wsdl;

}
catch (exception $e)
{

    $errors = $e->faultstring;
}
return $loginResult;
}

[devinemke]

you cannot output anything to the browser prior to calling [man]header[/man]. you can always control your output using the Output Control Functions.

[atokatim]

i have found that header() does not work unless you put exit; after it.

[Shrike]

That's a misunderstanding. A call to header( 'Location...'); will send a 302 (moved temporarily) status code to the client. It's up to the client whether they agree to it or not. The script doesn't exit just because you used header(), and any code following is executed as normal.

This is perhaps a common misunderstanding because header( 'Location...); is a very common action to take after handling a POST request.