[RESOLVED] Function "extract" issues

riddellchris

I for each row I have in my database I get these three errors repeated each time:

Notice: Undefined index: movie_name in C:\apache\htdocs\movie_review_website\~scp.php on line 57

Warning: extract(): First argument should be an array in C:\apache\htdocs\movie_review_website\~scp.php on line 36

Notice: Undefined variable: people_fullname in C:\apache\htdocs\movie_review_website\~scp.php on line 37

I cannot for the life of me work out the issue, reading manuals has just go me no where, clearly I just don't know enough yet so if you can spot the error in my code (below) I'd be very grateful!

$movie_header =<<<EOD
<h2><center>Movie Review Database</center></h2>
<table width="70%" border="1" cellpadding="2"
cellspacing="2" align="center">
<tr>
<th>Movie Title</th>
<th>Movie Director</th>
<th>Movie Lead Actor</th>
</tr>
EOD;

function get_director() {
global $movie_director;
global $director;

$query_d = 	"SELECT people_fullname " .
					 	"FROM people " .
					 	"WHERE people_id='$movie_director'";
$results_d = mysql_query($query_d)
	or die (mysql_error());
$row_d = mysql_fetch_array($results_d);
extract($row_d);
$director = $people_fullname;

}

function get_leadactor() {
global $movie_leadactor;
global $leadactor;

$query_a =  "SELECT people_fullname " .
						"FROM people " .
						"WHERE people_id = '$movie_leadactor'";
$results_a = mysql_query($query_a)
	or die(mysql_error());
$row_a = mysql_fetch_array($results_a);
extract($row_a);
$leadactor = $people_fullname;

}

$movie_details = '';
while ($row = mysql_fetch_array($result)) {
$movie_id = $row['movie_id'];
$movie_name = $row['movie_name'];
$movie_director = $row['movie_director'];
$movie_leadactor = $row['movie_leadactor'];

//get director's name from people table
get_director();
//get lead actor's name from people table
get_leadactor();

$movie_details .=<<<EOD
<tr>
<td><a href="movie_details.php?movie_id=$movie_id"
title="FInd out more about $movie_name">$movie_name</td>
<td>$director</td>
<td>$leadactor</td>
</tr>
EOD;
}

laserlight

You should indent the code and place it within php forum bbcode tags when posting:

$movie_header =<<<EOD
<h2><center>Movie Review Database</center></h2>
<table width="70%" border="1" cellpadding="2"
cellspacing="2" align="center">
<tr>
<th>Movie Title</th>
<th>Movie Director</th>
<th>Movie Lead Actor</th>
</tr>
EOD;

function get_director() {
    global $movie_director;
    global $director;

$query_d = "SELECT people_fullname " .
           "FROM people " .
           "WHERE people_id='$movie_director'";
$results_d = mysql_query($query_d)
    or die (mysql_error());
$row_d = mysql_fetch_array($results_d);
extract($row_d);
$director = $people_fullname;
}

function get_leadactor() {
    global $movie_leadactor;
    global $leadactor;

$query_a = "SELECT people_fullname " .
           "FROM people " .
           "WHERE people_id='$movie_leadactor'";
$results_a = mysql_query($query_a)
    or die(mysql_error());
$row_a = mysql_fetch_array($results_a);
extract($row_a);
$leadactor = $people_fullname;
}

$movie_details = '';
while ($row = mysql_fetch_array($result)) {
    $movie_id = $row['movie_id'];
    $movie_name = $row['movie_name'];
    $movie_director = $row['movie_director'];
    $movie_leadactor = $row['movie_leadactor'];

//get director's name from people table
get_director();
//get lead actor's name from people table
get_leadactor();

$movie_details .=<<<EOD
<tr>
<td><a href="movie_details.php?movie_id=$movie_id"
title="FInd out more about $movie_name">$movie_name</td>
<td>$director</td>
<td>$leadactor</td>
</tr>
EOD;
}

It looks like $result and $row does not exist.

Incidentally, your use of global variables and extract() is disturbing. A function like get_director() would be better written as:

function get_director($movie_director) {
    $query = "SELECT people_fullname " .
               "FROM people " .
               "WHERE people_id='$movie_director'";
    $result = mysql_query($query)
        or die (mysql_error());
    $row = mysql_fetch_assoc($result);
    return $row['people_fullname'];
}

Of course, the above code assumes that $movie_director need not be escaped with mysql_real_escape_string() (perhaps it was already escaped) and that terminating the script so ungracefully is acceptable. Since only one column from the first row of the result set is used, mysql_result() could be used instead of mysql_fetch_assoc().

riddellchris

Well where do I start! Thanks for that help. Funny/sad thing is that I'm trying to learn from a book so I'm pretty much running through their examples and trying to make them work and make sense of them obviously they aren't that great. What you have written makes a lot more sense to me too, it follows other programming patterns that I have used! I just didn't know that you could to that so thanks a lot!

Sorry about the tabbing issue, and with placing code is there a fast way to do change the colouring because obviously I'm programming in colour but when i copy it across it doesn't come?

There is now/may have always been an issue with my use of EOD. There is an error saying:

Notice: Undefined variable: movie_details in C:\apache\htdocs\movie_review_website\~scp.php on line 61

I think it's because it stops and starts but i tried making it one thing and got no output? Do you know what the issue may be?

Thanks again!

NogDog

Make sure your heredoc string terminators ("EOD;" in your example) have no spaces/tabs before or after them (i.e.: they cannot be indented).

As far as displaying code samples on this forum, use the PHP bbcode tags around your code samples.

riddellchris

Thankyou everyone!