[RESOLVED] Separating Code from Structure in PHP

[ManWithNoName]

... Hi again.

When coming to form processing I end up with a lot of, e.g (a very simple example).

foreach($array as $key => $value)
echo "<option value='$key'> . $value . '</option>";
}

Now, is it possible to separate the HTML structure from the PHP code?

I know that this is a kind of silly question, but it has been echoing in my mind for a while... It just feels that I could have a little bit cleaner code.

In this case the only think that crossed my mind was that I could create a function and pass the arrays/variables through it, returning the results.

Any other thoughts? Suggestions? Opinions?

[Horizon88]

Yes, you could use a function to echo it back, but you'd still have a foreach with html in it. Your form variables and such wouldn't be in the code, it would be:

$results = processForm($formName):
foreach ($results as $key => $value) {
...

So it's technically seperated, some, but ...

[ManWithNoName]

Yeah, I know. It almost feels like a redundant process. But because I have a lot of segments that need to create similar parts (e.g. option tags) a function seems like a good away to go; separating at least some structure/code and reducing the overall size of the file.

I am leaning towards doing that -- if no better ideas presents itself...

[dmacman1962]

Hi MWNN,

I know how you feel. I asked the same question awhile ago, and I believe Leatherback gave me these function for dropdown menus and checkboxes.

makeDropList.php

function makeDropList($name,$list,$selected="")
{
// $name       select name
// $list       array of value, label pair
// $selected   selected value
global $x;
global $label;
foreach($list as $value=>$label)
{
if(($_SESSION[$label] != '') || ($selected == $value)) // Are you sure you stored the label?
{
$options .= '<option selected value="'.$value.'">'.$label.'</option>';
}
else
{
$options .= '<option value="'.$value.'">'.$label.'</option>';
}
}
$dropList = '<select name="'.$name.'" tabindex="'.$x.'">'.$options.'</select>'."\n";
return $dropList;
} 

makeCheckboxList.php

function makeCheckboxList($name,$list,$selected="") {
  global $x;
    while(list($value,$label) = each($list)) {
	if($value['enabled']=='1') {
 $options .= '<input name="'.$name.'" type="checkbox" value="'.$value.'" tabindex="'.$x.'" checked="checked"/>&nbsp;'.$label.'<br />';
} else {
 $options .= '<input name="'.$name.'" type="checkbox" value="'.$value.'" tabindex="'.$x.'" />&nbsp;'.$label.'<br />';
}
 }
 return $options;
}

Then in your form call them this way.

<form>
include('makeDropList.php');
$x='1'; //tabindex value
$choices = array( "" => "Choose one!", "1st choice" => "1st choice", "2nd choice" => "2nd choice"); // default for empty selected
$list = makeDropList('Choice',$choices,$choices);
echo $list;
echo '<br><br>';include('makeCheckboxList.php');
$x='2'; //tabindex value
$choices2 = array( "" => "Pick One!", "A" => "A", "B" => "B"); // default for empty selected
$list2 = makeCheckboxList('Choice2',$choices2,$choices2);
echo $list2;
</form>

These save me a ton of time.

Let me know if they are what you were envisioning.

Enjoy,
Don

[ManWithNoName]

dmacman1962: something like that, yes, my function wouldn't have been as thoroughly done though 😉. This seems to be the best approach as long as there is few discrepancies between the form tags. Thanks dmacman1962 you code will be an excellent frame to work with.

/*********************** But, wait; there is more! /

There is yet another method that just crossed my mind.

One could use DOM to dynamically create any element needed. Using DOM could maybe invoke more use of system resources than needed to create simple forms (when you could just “echo them out”. However, I am no expert, so I do not know if that is a valid argument.

[dmacman1962]

I couldn't say about using DOM, since I never used it.

These functions can be applied from a query (I have a states table I use often, and just include it in my forms).

Have fun.

Don't forget to mark this thread "Resolved" if your question is answered.

Don

[ManWithNoName]

Why you, I feel insulted; I am probably the only one in the forum that uses the "resolved" button 😉.

<<<< ¤ >>>>>

Regarding this thread, I'll wait a while longer so that everybody gets their fair chance of expressing their opinion regarding this issue before I mark it resolved.

[dmacman1962]

MWNN, I was in no way insulting you or attempting to insult you.

Just asking you if it was resolved or not.

Sorry,
Don

[ManWithNoName]

"... I was in no way insulting you or attempting to insult you."

No offence taken. (That is why the smiley came in. You know, to show that I was not taken it seriously)... Gee, now I feel bad.

... However, I will accept your apologize (it is a shame to waste those).