[RESOLVED] uploading files in existing directory fails

mOleCuleZz

Hello,

I have a bit of a problem with uploading files to existing directories on the server.

I have a script that uploads jpegs to specific folders.. it checks first if the folder exists. If it does not it creates that folder and then uploads the jpegs in there.

Now if the folder already exists it does not upload the files. What might be the reason for this ?
The code looks something like this:


if (isset ($_POST['submit'])) {
			$id = $_POST['vid'];
			$ams = $_POST['ams'];
			$root = $_SERVER['DOCUMENT_ROOT'];
			$dirL = $root.'/_lib/photos/'.$id.'/websize/';
			$dirS = $root.'/_lib/photos/'.$id.'/thumbsize/';

		require("gd.php");

		if(isset($_FILES['pix']['name'])){

			require("upload_mult.php");
			if($ams==0) $ams=1;
			$n = $ams;

			foreach ($_FILES['pix']['error'] as $key => $error) {
				if ($error == UPLOAD_ERR_OK) {
					$name = $id.'0'.++$n;

					if(imageResize($_FILES['pix']['tmp_name'][$key], 400, 300)) {

						if(storefileM('pix', $key, $dirL, $name.'.jpg', 768000)) {
							if(imageCrop($dirL.$name.'.jpg', $dirS.$name.'.jpg', 0.41)){
								$sqlInsert = 'INSERT INTO photos ( photo_id , photo_name) VALUES ( "'.$id.'", "'.$name.'");';
								mysql_query($sqlInsert, $db);
							}
						} else {$e = 2; $error = true;}
					} else {$e = 1; $error = true;}

				}
			}
		}
    if($error==true){
	header("Location: uploadfailed.php?error=".$e."");

} else { header("Location: uploadok.php"); }

}
$vid = $_GET['v_id'];
$dir = $_SERVER['DOCUMENT_ROOT'].'/_lib/photos/'.$vid;

if(!is_dir($dir)){
	mkdir($dir);
	mkdir($dir.'/websize');
	mkdir($dir.'/thumbsize');
}

BTW: mkdir is creating the folders using chmod755 and all existing folders have chmod777 which I assigned manually with a script using chmod()

paulnaj

Hi,

I think the problem lies in a PHP script's permissions.

I'm not an expert but as far as I know, PHP runs as a user called 'nobody'. Again, as far as I know, 'nobody' can't set permissions on a folder, or at least some server config may have to be done to allow this.

And if you're running the script on a shared server the chances are you won't be able to do this.

I've had to deal with this problem a few times. What I've ended up doing is this:
1. Manually create a single folder called 'uploads' (or whatever) and chmod it to 0777
2. In the script, always upload the file to this directory (no permissions problems)
3. Then, use FTP 😉 to move the file to the correct location. See the manual entry for FTP ... it's straightforward.

mOleCuleZz

paulnaj wrote:
some server config may have to be done to allow this.

The shared server came with a php.ini file in the root directory. I am able to change settings in here.

Is it something I can change in the php.ini file or is it an apache configuration of some sort ?

paulnaj

Apache I think.

But I've just read the comments at the very bottom of manual entry for mkdir() and it has some possible solutions (including a version of the FTP route).

mOleCuleZz

paulnaj wrote:
Apache I think.

But I've just read the comments at the very bottom of manual entry for mkdir() and it has some possible solutions (including a version of the FTP route).

P.

I saw the FTP route and some solution to making directories.. but I don't have this problem I can create directories with no problem.. it's when I want to upload the files to already existing directories is where it gets stuck. Before I finished this script I manually uploaded directories with images to the server. This is where I'm having this problem.

When I upload a file it creates 2 files 1 normal size image and 1 thumb image.. and these are saved in the "number"/websize folder and "number"/thumbsize folder. This works perfectly with newly created folders.

paulnaj

OK, I see.

I got it the wrong way round. :queasy:

But, the issue still could be to do which user PHP is running under.

When you say existing folders, do you mean ones that were created earlier by a PHP script or ones created in an FTP program?

If it's ones created in FTP, then it will have been created by the FTP 'user', and not 'nobody'. The solution could be then to have a 'initialise_folders.php' script that makes the folders in PHP.

By the way, I check modes in my FTP program too.

mOleCuleZz

paulnaj wrote:
OK, I see.

I got it the wrong way round. :queasy:

But, the issue still could be to do which user PHP is running under.

When you say existing folders, do you mean ones that were created earlier by a PHP script or ones created in an FTP program?

If it's ones created in FTP, then it will have been created by the FTP 'user', and not 'nobody'. The solution could be then to have a 'initialise_folders.php' script that makes the folders in PHP.

P.

By the way, I check modes in my FTP program too.

Yes existing folders being folders created by FTP program.
But I tried with your suggestion using initialize script but not working either..
Might it be because of the fact that I am using sessions with username and password verification when trying to upload file? does that change 'nobody' ?

Probably not but I don't know what to think anymore.. lol

I really thought that ur suggestion would be the solution. :queasy: :queasy:

mOleCuleZz

Silly me... All of this is because I gave the wrong name for the send tag in the form.

<input name="pixL[]" type="file" />

and I was calling

$_FILES['pix']['name']

Problem solved 😃