ip2long

pedroz

I am facing the following problem:

_ I have a file in my server checking the ip's from the visitors working perfectly but I am figuring an error in following code:

$pagesource = file_get_contents('http://myserver/ip.php');
echo $pagesource; //correctly displayed ip: xxx.xxx.xxx.xxx
$ip = explode(":",str_replace(' ', '', $pagesource));
echo $ip[1]; //correctly displayed xxx.xxx.xxx.xxx

echo ip2long($ip[1]); //ERROR! nothing displayed...

I have php 5.2.3 and if I use
$ip[1]="127.0.0.1";
echo ip2long($ip[1]);
It works FINE

What is my problem?

NogDog

Try trimming the IP string (see [man]trim[/man]), as you may have a newline or other white-space character picked up as part of your parsing process. Also, you will want to use [man]sprintf/man or [man]printf/man to output the value, so that it is treated as an unsigned integer. Otherwise, you may get spurious negative values for IP addresses that convert to too large a value for a signed integer:

printf('%u', ip2long($ip[1]));

pedroz

I used trim but it is still not working.

printf('%u', ip2long($ip[1])); = blank 🙁

any other idea?

Weedpacket

Something to look at:

echo $ip[1];

This displays correctly, right? Now what does

echo strlen($ip[1]);

produce? I don't know what your IP is, but you should be able to tell how many characters should be in it.

ip2long() is purely a syntactic function - it just looks for decimal digits (for integers 0 ... 255) with '.' characters between. After that it's just a bit of multiplication and addition. There's not really much there to cause an error unless the input data is somehow faulty.