If Statement help

MitchEvans

Hi Guys,

I have a problem with an IF i'm using.

The current IF works fine

if ($_FILES['imageupload']['type'] == "image/gif" OR $_FILES['imageupload']['type'] == "image/pjpeg" OR $_FILES['imageupload']['type'] == "image/jpeg" AND $_FILES['imageupload']['size']<$max_file_size)
{
Echo "Yes";
}

I also want the statement to test if $member='', so the If needs to check all the above and if $member=''.

I've tried "AND $member=="" but still no luck. I want the word yes to appear if all the above are correct and member = nothing.

Any help cheers

laserlight

The problem you currently face is that OR has a lower precedence than AND, so (a OR b OR c AND d) would be true if a is true or if b is true, or if both c and d are true. Even if d is false, the entire expression could still be true. Grouping with parentheses would solve the problem, but instead of doing so many comparisons with the same value, I would use an array and check to see if the value is in the array:

$allowed_file_types = array('image/gif', 'image/pjpeg', 'image/jpeg');
if (in_array($_FILES['imageupload']['type'], $allowed_file_types)
    && $_FILES['imageupload']['size'] < $max_file_size
    && $member == '')
{
    echo 'Yes';
}

MitchEvans

Thanks for ther rapid response

Unfortunately that doesn't work, I thought it would, i took that extra bracket out of the one you sent me and when i press enter just a blank page.
Seems odd, my other code works fine, just need this $member to check if it's blank.

I tried the below:

if (in_array($_FILES['imageupload']['type'], $allowed_file_types
    && $_FILES['imageupload']['size'] < $max_file_size 
    && $member == '') 
{

laserlight

Unfortunately that doesn't work, I thought it would, i took that extra bracket out of the one you sent me and when i press enter just a blank page.

That bracket (parenthesis) is not "extra". It is the closing parenthesis for the in_array function call. You have display_errors set to Off, or have a very lax error_reporing level. This is not suitable for development as you need to be able to read the error messages for debugging.

MitchEvans

Wow you're right it works with that second bracket, sorry for doubting that.

You're a star thankyou!!!!!

bradgrafelman

Don't forget to mark this thread resolved.