Need help with code trying to validate email address

[adaykin]

I can't seem to figure out why this isn't working, I'm using the eclipse plugin to develop, error message in eclipse says ')' expected in function declaration, right on the 2nd print statement...

<?php
// Check to see if email address is a valid one
$email = $_POST['email'];
if (isset($email) && emailAddressValid($email) = true)
{
   print 'Submission was successful';
}
else
{
	print 'Email must be filled out with a valid email address';
}
// Verify email address has correct format
function emailAddressValid($email)
{
        $qtext = '[^\\x0d\\x22\\x5c\\x80-\\xff]';
        $dtext = '[^\\x0d\\x5b-\\x5d\\x80-\\xff]';
        $atom = '[^\\x00-\\x20\\x22\\x28\\x29\\x2c\\x2e\\x3a-\\x3c'.
            '\\x3e\\x40\\x5b-\\x5d\\x7f-\\xff]+';
        $quoted_pair = '\\x5c[\\x00-\\x7f]';
        $domain_literal = "\\x5b($dtext|$quoted_pair)*\\x5d";
        $quoted_string = "\\x22($qtext|$quoted_pair)*\\x22";
        $domain_ref = $atom;
        $sub_domain = "($domain_ref|$domain_literal)";
        $word = "($atom|$quoted_string)";
        $domain = "$sub_domain(\\x2e$sub_domain)*";
        $local_part = "$word(\\x2e$word)*";
        $addr_spec = "$local_part\\x40$domain";
        return preg_match("!^$addr_spec$!", $email) ? 1 : 0;
}
?>

[dagon]

you have to declare the function before calling it

function emailAddressValid($email) should be above the if in the code

[adaykin]

ok I did that but I am still getting the same error in my browser I was before:

Fatal error: Can't use function return value in write context in C:\xampp\htdocs\xampp\eclipsePHP\contactMe.php on line 50

probably should have mentioned that before 😛

[NogDog]

dagon wrote:

you have to declare the function before calling it

function emailAddressValid($email) should be above the if in the code

Actually, that is not true, unless the function definition is within some sort of conditional block (and thus is not defined unless and until that block is executed at run-time).

[NogDog]

The problem is you used an assignment "=" where you wanted a comparison "==":

if (isset($email) && emailAddressValid($email) [color=red]==[/color] true)

[dagon]

woooooops sorry, thanks for the correction NogDog

[adaykin]

Ok Thanks that worked, got it going now!

[NogDog]

dagon wrote:

woooooops sorry, thanks for the correction NogDog

I always define my functions first, though. It's just feels better that way to me. 😉