[RESOLVED] Help! only getting one result when there sould be 4

[jerrylouise]

Hey all i have a problem, my page sould display 4 results but its only displaying the top most result.

<?php
/// variables ///
$topic = "1";
$title = $_GET['title'];
?>
<table width="100%" border="0" cellpadding="3" cellspacing="0" >
<tr class="page_title"><td width="70%" class="page_title"><?php echo $title ?></td><td width="15%" class="page_title"></td><td width="15%" class="page_title"></td><td></td></tr>
</table>
<table width="100%" border="0" cellpadding="3" cellspacing="0" >
<?php
//// sql connect ////
$sql = "SELECT
post.`id`, 
post.`post-id`, 
post.`username`, 
post.`date`, 
post.`subject`, 
post.`post`, 
post.`lastpost`,
post.`lastposttime`,
COUNT(DISTINCT reply.`id`) AS `replycount`
FROM 
`forum-posts` post 
LEFT JOIN `forum-reply` 
AS 
`reply` 
ON 
post.`id` = reply.`reply-id`
WHERE post.`id` = '$topic' 
GROUP BY reply.`reply-id`
ORDER BY post.`id`";
///start result//
$result = mysql_query($sql) or die("Query failed($sql): " . mysql_error()); 
if(mysql_num_rows($result)) 
{   

		print '<table width="100%" border="0" cellpadding="3" cellspacing="0" >';
		print '<tr class="page_title"><td width="50%">Topic</td><td width="25%">Last Posted By</td><td width="10%">Replies</td><td width="15%">Created</td></tr>'; 
	$i = 0; 
   while($row = mysql_fetch_array($result)) 
   { 
      if($i++ % 2) 
      	{ 
         	print '<tr class="blue">'; 
     	 } 
     			 else 
      					{ 
        					 print '<tr class="wight">'; 
      					}  

	printf("<td><a href=\"forum_topic_view.php?id=%s&catagory=$topic\">%s</a><br />Posted by %s" . "" . "</td><td>%s" . "<br />%s" . "</td><td>%s" . "</td><td>%s" . "</td></tr>", $row["subject"], $row["subject"], $row["username"], $row["lastpost"], $row["lastposttime"], $row["replycount"], $row["date"]);
}   

   print '</table>'; 
} 
else 
{ 
   print '<p class="error">Data error: no records found.</p>'; 
}
?>

[NogDog]

First thing to do would be to echo mysql_num_rows($result) to see if it's a question of the query only returning one row or the following code logic which is wrong. If it's the query, then try printing out $sql to see if it looks correct and is populated with the correct variable values. If it turns out that the query logic is the problem, we'll probably need more info on the table structures/relations, and what exactly you want the query to do.

[jerrylouise]

WHERE post.`id` = '$topic'

i changed this to

WHERE post.`post_id` = $topic

and it now works perfictly, i can't belevie i messed it up with something simple