[RESOLVED] Is there an error with this?

[kostis12345]

I tried to restrict access to anyone but me to my site but it doesn't work and I hope someone could help me.
the code I use is this :

<?php


$ip = $_SERVER['REMOTE_ADDR'];
if (!$ip = "MY.IP.HE.RE")
{
echo "site under maintenance";
}
else
{
	echo "test";
}


?>

I put a valid ip address(i take it from whatismyip.com) but it always shows "test".can anyone tell me why ?

[kostis12345]

I forgot to say,that I have seen this also:

if ($ip != "MY.IP.HE.RE")

instead of

if (!$ip = "MY.IP.HE.RE")

I have tried it but it didn't work

[Kudose]

if (!$ip = "MY.IP.HE.RE") 

Will always return true because $ip = "MY.IP.HE.RE" will always be true. You are using the assignment operator. You are looking for == ... the equivalence operator.

if (!($ip == "MY.IP.HE.RE")) 

if ($ip != "MY.IP.HE.RE")

Works because that checks that the value does not equal MY.IP.HE.RE, although !== is preferred ... I can't recall why though. Maybe someone else will.

[kostis12345]

thanks a lot,it worked 🙂