File Writing Issue

[Poomerio]

Hi there.
I'm writing a forum installation script, and I've hit a snag with fwrite()
The code should write the contents of the variable $towrite into config.php, but config.php always remains blank.

Here's a snippet of the code I've used:

<?php

$dbhost = $_POST['dbhost'];
$dbuser = $_POST['dbuser'];
$dbpass = $_POST['dbpass'];
$dbname = $_POST['dbname'];

if ($dbhost=="" or $dbuser=="" or $dbpass=="" or $dbname=="")
{
header('Location: install.php?step_id=3');
}

//Requires header
require("includes/header.php");

  echo "<div id='starter'>
  <div class='border'>
	<div class='block'>
		<div class='bottom'>
  <h3>Step 3: Writing Config.php</h3>
		</div>
		<ol>
Writing to config.php...
  		</ol>
  		</div>
  	</div>
  </div>";

$fq = @fopen("../config.php","w");

$towrite = "$dbhost = $dbhost;
$dbuser = $dbuser;
$dbpass = $dbpass;
$dbname = $dbname;

$connect = mysql_connect($dbhost,$dbuser,$dbpass,$dbname);
if (!$connect)
  {
\  die('Could not connect ' . mysql_error());
  }";

@fputs($fp,$towrite);
@fclose($fp);

?>

Thanks,
- Poomie

[NogDog]

For the first level of debugging, try taking out all the "@" characters which are suppressing PHP error messages, and see if it tells you anything useful. (I'm guessing it's a permissions problem.) You may also need to add the following lines to ensure error reporting is being output:

ini_set('display_errors', 1);
error_reporting(E_ALL);

[Poomerio]

Right then.
The errors I now get are:

Notice: Undefined variable: connect in C:\apache2triad\htdocs\easybb\install\includes\install_step4.php on line 42
Notice: Undefined variable: fp in C:\apache2triad\htdocs\easybb\install\includes\install_step4.php on line 47
Warning: fputs(): supplied argument is not a valid stream resource in C:\apache2triad\htdocs\easybb\install\includes\install_step4.php on line 47
Notice: Undefined variable: fp in C:\apache2triad\htdocs\easybb\install\includes\install_step4.php on line 48
Warning: fclose(): supplied argument is not a valid stream resource in C:\apache2triad\htdocs\easybb\install\includes\install_step4.php on line 48

The unidentified variable $connect is part of the $towrite variable.

• Poomie

[NogDog]

Your fopen() file handle result is assigned to variable "$fq", but then your reference variable "$fp" later on.

Also, I'm not sure what you intended here:

$towrite = "$dbhost = $dbhost;
$dbuser = $dbuser;
$dbpass = $dbpass;
$dbname = $dbname;

$connect = mysql_connect($dbhost,$dbuser,$dbpass,$dbname);
if (!$connect)
  {
\ die('Could not connect ' . mysql_error());
  }"; 

I suspect what you want is something like:

$towrite = "\$dbhost = $dbhost;
\$dbuser = $dbuser;
\$dbpass = $dbpass;
\$dbname = $dbname;

\$connect = mysql_connect($dbhost,$dbuser,$dbpass,$dbname);
if (!\$connect)
  {
\ die('Could not connect ' . mysql_error());
  }";