switch op not working

[SFDonovan]

I am working on a standalone anonymous question and answer system for work. These damn students never seem to want to ask what they fear might be a stupid question in class, so this will allow them to submit anonymous questions to their course directors.

So far the structure is the following:

comment
comment/index.php
comment/header.php
comment/footer.php
comment/config.php
comment/includes/db.php
comment/includes/mysql.php
comment/includes/function.php
comment/language/lang-english.php

My index.php is where I will have most of my functions such as index(), reply(), comment() ..... etc.

The function.php is where I will do some check_html() stuff.

This is my first standalone application. My problem is my index.php page has the following that doesn't appear to be working at all.

switch($op) {

case "comment":
comment($cid);
break;

case "reply":
reply($cid);
break;

default:
index();
break;
}

index() lists all the comments on the page and there is a reply button at the bottom that would I hope send me to the reply function such as:

OpenTable();
	echo "<form method=\"post\" action=\"" .$_SERVER['PHP_SELF'] ."\">\n";
	echo '<table width="99%" border="0"><tr><td width="500">';
	//formatTimestamp($date);
	echo '<p><b>'.$topic.'</b><br />'._BY." $name "._ON." $time";	
	echo '</p></td></tr><tr><td>'.$comment_text.'</td></tr></table><br /><br />';		
	echo '<input name=\'submit\' type=\'Submit\' value=\'Reply\'>';
	echo '<input name=\'op\' type=\'hidden\' value=\'reply\'>';
	echo '<input name=\'op\' type=\'hidden\' value=\'$cid\'>';
	echo '</form>';	
	echo ' <hr>';
	CloseTable();

The only thing that is happening is my index.php is refreshing.

[maxpup979]

not knowing what index() does, it appears that you have 2 hidden fields in your form, both with the same name. I believe the effect then is that the second op is what is actually passed (in this case $cid)--If the value in $cid is not in your switch, it is going to go to the default. To verify, just output $op before you get into the switch to ensure you are receiving a value you are expecting.

Hope that helps!

[SFDonovan]

My goof. I have found out registered_globals are off as well.

My index.php page has this:

$op = isset($_POST['op']) ? $_POST['op'] : ''; 
switch ($op) { 


case 'comment':
comment($cid);
break;

case 'reply':
reply($cid);
break;

default:
index();
break;
}

My index() function is now this:

function index() {
include_once("header.php");
global $AllowableHTML, $user, $cookie, $anonymous, $db, $language;
$op = ($_POST['op']);
	$result = $db->sql_query('SELECT * FROM comments ORDER BY time');	
	while ($row = $db->sql_fetchrow($result))
	{	
	$cid = $row['cid'];
	$time = $row['time'];
	$name = 'Annonymous';
	$comment_text = stripslashes($row['comment_text']);
	$topic = stripslashes($row['topic']);
	$comment = stripslashes($row['comment']);	
	$reason = intval($row['reason']);
	$titlebar = '<b>title</b>';
	if(empty($name)) $name = $anonymous;
	if(empty($topic)) $topic = '['._NOTOPIC.']';
	echo '<div class="content">';	
	OpenTable();
	//echo "<form action=\"" . reply() . "\" method=\"post\">";
	echo "<form method=\"post\" action=\"" .$_SERVER['PHP_SELF'] ."\">\n";
	echo '<table width="99%" border="0"><tr><td width="500">';
	//formatTimestamp($date);
	echo '<p><b>'.$topic.'</b><br />'._BY." $name "._ON." $time";	
	echo '</p></td></tr><tr><td>'.$comment_text.'</td></tr></table><br /><br />';	
	echo '<input name="submit" type="submit" value="Reply" />';		
	echo '<input name="op" type="hidden" value="reply" />';	
	echo '</form>';	
	echo ' <hr>';
	CloseTable();	
	}
	echo '</div>';
	include("footer.php");
	}

But I think I'm getting somewhere.