PHP error, need help

bloody

I just started a proxy website, everything is set up properly but above my URL box for the proxy, I get an error in text saying:

Warning: Cannot modify header information - headers already sent by (output started at /home/username/domains/mydomain.com/public_html/index.php:13) in /home/username/domains/mydomain.com/public_html/PHProxy.class.php on line 627

Does anyone know how to fix this? I'm not sure what to do.

NogDog

The error message pretty much spells it out: at line 13 of index.php some sort of output was generated. It could be a PHP command such as echo or print, or it could just be any text not within your <?php . . . ?> tags, including spaces or newlines. Then at line 627 of PHProxy.class.php you are trying to do something that modifies headers, such as setcookie(), session_start(), or even header(). Since headers get sent as soon as any output is generated, they can no longer be modified, and thus the error.

bloody

NogDog wrote:
The error message pretty much spells it out: at line 13 of index.php some sort of output was generated. It could be a PHP command such as echo or print, or it could just be any text not within your <?php . . . ?> tags, including spaces or newlines. Then at line 627 of PHProxy.class.php you are trying to do something that modifies headers, such as setcookie(), session_start(), or even header(). Since headers get sent as soon as any output is generated, they can no longer be modified, and thus the error.

On line 13 of my index.php, it is an unordered list, just the <ul> tag. No php tags around it, its just part of the template. I don't understand where the error is there.

And on line 627 of phproxy.class.php, it says

       [QUOTE] $this->flags['include_form']    = $flags{0} == 1 ? 1 : 0;[/QUOTE]

The line before it says

        [QUOTE]setcookie('flags', $flags, time()+(4*7*24*60*60), '', $this->http_host); [/QUOTE]

What should I do?

HalfaBee

The <ul> tag is OUTPUT then at line 626 you are trying to set a COOKIE which has to be done before ANY OUTPUT.

I would assume the script has been designed around php having output_buffering On and you might need to change this in php.ini.

NogDog

Your other alternatives are to either reorganize the code so that the setcookie() gets done before any output is sent, or turn on output buffering at the beginning of the main script via the [man]ob_start/man function, making sure that ob_start() comes before any output.

bloody

I'm not sure how I would be able to do this. The header that is giving me my first error, is in the index. Here is line 13 of index.php that is giving me the first error:

<ul> (line 13)
<li><a href="#">Affiliates</a></li>
<li><a href="#">Sign Up</a></li>
<li><a href="#">Sign In</a></li>
<li><a href="#">News</a></li>
<li><a href="#">Home</a></li>
</ul>

But the second error is coming from my phproxy.class.php. Here is where the other error/errors occur:

        [QUOTE]setcookie('flags', $flags, time()+(4*7*24*60*60), '', $this->http_host); 
        $this->flags['include_form']    = $flags{0} == 1 ? 1 : 0;   [B](line 627)[/B]
        $this->flags['remove_scripts']  = $flags{1} == 1 ? 1 : 0;
        $this->flags['accept_cookies']  = $flags{2} == 1 ? 1 : 0;
        $this->flags['show_images']     = $flags{3} == 1 ? 1 : 0;
        $this->flags['show_referer']    = $flags{4} == 1 ? 1 : 0;
        $this->flags['rotate13']        = $flags{5} == 1 ? 1 : 0;
        $this->flags['base64_encode']   = $flags{6} == 1 ? 1 : 0;
        $this->flags['strip_meta']      = $flags{7} == 1 ? 1 : 0;
        $this->flags['strip_title']     = $flags{8} == 1 ? 1 : 0;
        $this->flags['session_cookies'] = $flags{9} == 1 ? 1 : 0;[/QUOTE]

I don't think I know enough to try to reorganize the code. I'm confused because the header is in another file and its not in php format so I don't know how I would be able to put the setcookie ahead of it.

NogDog

The quick-and-dirty fix is to add the following to the main script file (whichever file is the one you point your browser to (or that is being called by a form action), at the very beginning of the file, with no spaces/newlines or any other text before the opening <?php tag:

<?php
ob_start();
?>
...rest of page follows...

bradgrafelman

As I've mentioned elsewhere... using the output buffering functions when faced with this error message is never a fix - it's just a messy workaround that places unnecessary burden on the server per web request.

The real 'fix' would be to call setcookie() and such before you output anything. Just because the line referenced isn't within PHP tags doesn't mean nothing is being outputted... plain HTML code is outputted as it appears in your script.

Since it looks like you're including the PHProxy.class.php file within index.php, you essentially need to include the file before the HTML code (line 13) in your index.php file.

bloody

Ah, that seems to have done the trick. I think I'm error-free now.