Unexpected T_STRING error

emucat

I know these kind of errors are all over these boards but none of which directly relate to my code. I was wondering if someone could help me. Here's the error:

Parse error: syntax error, unexpected T_STRING in /home/.miwa/edited/reg.php on line 85

Here's the code: (Line bolded is the one that says the error is occuring on

     if ($result) 
                {
                Stop("There are already user with such login. Try another name");
                }
       else 
                {
                password  md5($password);, login  md5($login);

            $query = "INSERT INTO users (login, pswd, email ) VALUES ( '$LoginHash', '$PswdHash', 'no' ) ; ";

           [b] $qresult = mysql_query($query);[/b]

            if ($qresult) Stop("You successfully got registered");
            else echo Stop("Some mistake with writing to DB");
            }
    ?>

Thanks in advance. If I need to paste more of the code let me know.

NogDog

I don't know about the bolded line, but this line is almost certainly not parsing:

password  md5($password);, login  md5($login);

bradgrafelman

What's the meaning of this jumbled mess:

password  md5($password);, login  md5($login);

Also, please use the board's [PHP][/PHP] bbcode tags (not 'code' tags) when posting PHP code - it makes the code easier to read (and spot errors such as syntax errors). You might want to go back and edit your original post and use 'php' tags instead of 'code' tags.

EDIT: Oi, looks like Nog beat me to it. :p

roscor

You can use MD5() within the query which Returns the hash as a 32-character hexadecimal number http://uk3.php.net/manual/en/function.md5.php. Ensure your database will accept the 32 characters. And that it is one way only(can only be checked against and no retrieved and reformatted).

 if ($result) 
                {
                Stop("There are already user with such login. Try another name");
                }
       else 
                {
                 //assume you got these values from earlier script/form
                 $LoginHash = $_POST['login'];
                 $PswdHash = $_POST['pswd'];
                 $email = $_POST['email'];

            $query = "INSERT INTO users (login, pswd, email ) VALUES ( md5('$LoginHash'), md5('$PswdHash'), '$email' )";

            $qresult = mysql_query($query) or die ("Could not run query.");
            }

            if ($qresult){
            // if worked
            die("You successfully got registered");
            }
            else
            {
             // if not submitted
            die("Some mistake with writing to DB");
             }



    ?>

try to keep your value names relevant i.e. $email = $_POST['email']; when you start building the scripts you can get confused with 'no' and such like.