[RESOLVED] What don't I understand about substr...

Jazzy_Girl

Hello, I need help finding out why this isn't pulling my .jpg. I tried it with the .jpg in our out of the image tags but its not about that. The error I get says file_get_contents .jpg cannot be found. But file_get_contents is only supposed to be called when there are files other than jpgs. Please let me know why substr isn't pulling the .jpgs. Thank you very much.

<?php ini_set('error_reporting', 8191); 
ini_set('display_startup_errors', 1);
ini_set('display_errors', 1); 
$test = Array(); 
$test[1]= "some.jpg";   

$test[2] = "<img src='some.jpg'/>"; 
$test[3] = "<img src='some.jpg'/>"; 
$test[4] = "somepage.txt"; 
$testtimer = date("s")%count($test)+1; 
if (in_array(substr($test[$testtimer], -3), array('jpg'))) 
{$get_content = $test[$testtimer]; 
echo $get_content;}   

else {$get_content = file_get_contents($test[$testtimer]); 
echo $get_content;}?>

Weedpacket

The only $test that that substr() has a hope of matching is the first one. For the second and third the last three characters are [font=monospace]'/>[/font]. So it ought to echo "some.jpg" when it's the first element's turn, on other occasions it will read a file called "somepage.txt" and output its content. But half the time it will try to read a file named "<img src='some.jpg'/>" - and I'm going to gues you have no such file.

Jazzy_Girl

Something else seems to be wrong. Anyone know a lot about substr? Its not matching even the first .jpg. It is pulling somepage.txt like it is supposed to.

How can I change substr so that it checks for this as well? ..... jpg'/>? Or just finds a jpg in it.

Please let me know, thank you very much.

NogDog

Could you give me a verbal description of what exactly you are trying to do? I suspect there's an easier way to accomplish it, but I can't quite wrap my mind around that code to figure out for sure what your intent is. (It was a long weekend, so it may just be me being dull. 🙂 )

Jazzy_Girl

Very sorry for the not the usual code, and thanks for taking a peak at it Nog, p.s. you're never dull. I've been working with substr for a couple months to try to find a better way to do this. Because I am really weary of using preg match to scan for certain characters, (it seems so touchy) unless there is absolutely no easier option. I thought if I could get substr going instead of preg match, in the long run I could use it for other php things I need as well. I need the array set up like it is because I have to be able to remove and add numbers easily. I would prefer to use substr or some like function, unless you guys tell me that it definitely will not find jpg in the image tag.

To answer your question, I just need substr to find the jpg inside the image tag. Because when it does, then the code does something (shows the image on the second it is listed on). Apparently the code I am using -3 is incorrect. What is the correct way to find it? The code is not finding the jpg so it is including it in with file_get_contents where it doesn't belong. Please let me know, thanks a lot.

NogDog

The -3 in substr()'s second parameter will grab the last 3 characters of the string, assuming the 3rd "length" parameter is not given. But in your sample data, the "jpg" is not always at the end of the string. For instance, the last 3 characters of $test[2] will be '/>. (What the -3 really means is to start from the string position index that is 3rd from the end.)

Anyway, if I'm understanding your needs correctly, I'd probably do this (yes, with good ol' preg):

$test = Array();
$test[1]= "some.jpg";   

$test[2] = "<img src='some.jpg'/>";
$test[3] = "<img src='some.jpg'/>";
$test[4] = "somepage.txt";
$testtimer = date("s")%count($test)+1;
if(preg_match('#\.jpg($|[\'"])#i', $test[$testtimer]))
{
   $get_content = $test[$testtimer];
   echo $get_content;
}   

else 
{
   $get_content = file_get_contents($test[$testtimer]);
   echo $get_content;
}

All the regex is doing is looking for the (case-insensitive) string ".jpg", where it either appears at the very end of the string or is immediately followed by a single- or double-quote.

Jazzy_Girl

Your just a knight in shining armour, sending you something. Thanks a lot Nog.

Looks like I better just ditch substr and do what I've been avoiding, trying to find out all the specs on preg match.

NogDog

Jazzy Girl wrote:
Your just a knight in shining armour, sending you something. Thanks a lot Nog.

Looks like I better just ditch substr and do what I've been avoiding, trying to find out all the specs on preg match.

Have fun. It's really like learning another (very terse) programming language.