Can you Correct tis...

dethman

Can Someone Correct this please m not that good! There are no errors when I try to use it It dosnt go back to starbaseName.php it dosnt even Change the starbaseName 😕

<?
session_start();
if (isset($_SESSION['id'])) {
 include('common.php');
 include('lib.php');

 $sql = "SELECT `starbaseName` FROM `UserDetails` WHERE `id` = $id";
 if( !($result = $db->sql_query($sql)) ) {
  die('Failed to query database userinfo.');
 }
 if (mysql_num_rows($result) > 0) {
  $row = $db->sql_fetchrow($result);
  $starbaseName = $row['starbaseName'];
 }
  if (isset($_POST['starbaseName'])) {
   $starbaseName = $_POST['starbaseName'];
   $sql = "UPDATE `starbaseName` SET `starbaseName` = '$starbaseName' WHERE `id` = $id";
   if( !($result = $db->sql_query($sql)) ) {
    die('Failed to query database1.'.mysql_error());
   }
   $done = "Starbase ".$starbaseName." Renamed To ".$starbaseName;
 }
header ('Location: starbaseName.php?str='.$done.'!');
}
?>

Scriptmaker

try using double quotes "" in the header line instead of single quotes.

mikell

1.
If isset($_SESSION['id']) is false, your call to header() will never happen.

Add the following right below your call to session_start():

if (!isset($_SESSION['id']))
{
die("id is not set");
}

Save it and run it. If you get the "id is not set" message then there is your answer.

2.
If isset($_POST['starbaseName']) is false then $done will never get set...
So try declaring $done right below your two include statements:
$done = '';

That will ensure that $done has been declared when the script gets to
header ('Location: starbaseName.php?str='.$done.'!');

3.
Also, just so you know, the following isn't going to work like you want it to:
$done = "Starbase ".$starbaseName." Renamed To ".$starbaseName;

Your using the same variable for the old and the new value.

Let us know if you can't figure it out.

halojoy

dethman wrote:
Can Someone Correct this please m not that good!

There are no errors when I try to use it
It dosnt go back to starbaseName.php
it dosnt even Change the starbaseName

Whenever there is a script not working
and some tell: No errors,
I get suspicious.
That maybe they have not:
error_reporting( E_ALL );

For tracking errors when writing php code this should be used.
PHP gives this option for improved DEBUGGING.
It wont tell all types of problems ....... but most of them = very many!
Which could give hints to fix things yourself.

Maybe you already have E_ALL, but just in case ......

I would never do any coding, without ( E_ALL )

<?php

error_reporting( E_ALL ); // DEBUG setting. Turn ON full PHP error_reporting

session_start();
if (isset($_SESSION['id'])) {
// etc
}
//etc

?>

mpb001

"Whenever there is a script not working
and some tell: No errors,
I get suspicious.
That maybe they have not:
error_reporting( E_ALL );

For tracking errors when writing php code this should be used.
PHP gives this option for improved DEBUGGING.
It wont tell all types of problems ....... but most of them = very many!
Which could give hints to fix things yourself.

Maybe you already have E_ALL, but just in case ......"

An improvement on that is you can auto detect whether it is development(internal) or internet by checking if the server ip is local host or part of the private address ranges and then set error reproting accordingly. Also leaving a session based back door to override the detection on the live server is very handy as well so you can see errors if you need to without changing any code/settings.

Intranet stuff would require something less generic.