Help with insert into

bdecock

Hi,

I have one mysql Db with 2 tables consisting each having the same columns.
Now I want to insert the entire record from TBL_CO where DIGIPASS=$digipass
into TBL_DIGIPASS

<html>
<head>
<title>Add New MySQL User</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body>
<?php
if(isset($_POST['add']))
{
include 'library/config.php';
include 'library/opendb.php';

$serial = $_POST['serial'];
$digipass = $serial."I_DIGIPASS"

$query = "INSERT INTO TBL_CAPITRACK SELECT * FROM TBL_CO where DIGIPASS=$digipass";
mysql_query($query) or die('Error, insert query failed');

include 'library/closedb.php';
echo "New digipass added";
}
else
{
?>
<form method="post">
<table width="400" border="0" cellspacing="1" cellpadding="2">
<tr>
<td width="100">Give serial</td>
<td><input name="serial" type="text" id="serial"></td>
</tr>
<tr>
<td width="100"> </td>
<td> </td>
</tr>
<tr>
<td width="100"> </td>
<td><input name="add" type="submit" id="add" value="Add DIGIPASS"></td>
</tr>
</table>
</form>
<?php
}
?>
</body>
</html>

NogDog

And do you have a question for us?

bdecock

oops, forgot 🙂

I'm just wondering if the query defenition is ok since I didn't specify any values but do a select * instead.

NogDog

It's probably safer to specify a column list both for the insert and the select, just to make sure both are in agreement as to the number and sequence of columns. For example:

INSERT INTO table_name (col_1, col_2, . . . col_n)
SELECT (col_1, col_2, . . . col_n) FROM . . .

bdecock

defining the values did indeed solve the problem as did my manager by cancelling the project 🙂