file upload issues

[erron]

hi, no matter what i try i cannot get php to upload a file, can someone please check what im doing wrong?

here is an example of the code:

$uploaddir = 'uploads/'; 
$uploadfile = $uploaddir . basename($_FILES['userfile']['name']); 

echo '
';
if (move_uploaded_file($_FILES['userfile']['tmp_name'], $uploadfile)) {
    echo "File is valid, and was successfully uploaded.\\n";
} else {
    echo "Possible file upload attack!\\n";
}

echo 'Here is some more debugging info:';
print_r($_FILES);

print ""; 

i have the folder CHMOD as 755 and the form file field name is 'userfile'.

please help!

[VBAssassin]

First try running someone elses code that is know to work... just a small code... to prove that the server setup is working correctly... if it is then you know cmod, php.ini etc is correct... and that narrows it down to a problem in your code.

Then you want to print out the directories to make sure they are correct:

print $uploaddir . basename($_FILES['userfile']['name']);

and print out the tmp folder directory, see if that exists, etc.

Eventually you should find the problem exactly and it will make it much easier to fix.

Kind regards,
Scott

[erron]

thanks for help but im still continuing to have problems, here is the new simplified code:

$uploaddir = 'uploads/';
$uploadfile = $uploaddir . basename($_FILES['userfile']['name']);
if (move_uploaded_file($_FILES['userfile']['tmp_name'], $uploadfile)) {
    echo "File is valid, and was successfully uploaded.\n";
} else {
    print $uploaddir . basename($_FILES['userfile']['name']);
}

folder CHMOD at 0755 and all error prints i put in show that the file name is not getting made, i can get the temp name but it doesnt seem to be renaming to the new filename and copying to upload directory.

above print results in just "uploads/" no filename.

i contacted my host who said that their scripts are working fine.

what am i doing wrong? this is starting to frustrate me 🙂

[NogDog]

You will probably need to set the permission on the target save directory to at least 766 so that the web server user (which is not the same as your personal user account on the server) is able to write to that directory.

Also, putting the following at the top of your script may help by outputting any error messages that the PHP parser has for you:

<?php
ini_set('display_errors', 1); // change to 0 once it's ready for production
error_reporting(E_ALL);

[erron]

error gives me: Notice: Undefined index: userfile

made uploads folder CHMOD 777

PHP version: 4.4.6

i beleive there has been an update to the php version and there may be a change im not familiar with. Do i need to add a GET or anything to get the filename? im just stabbing in the dark now 🙂

here is my entire test form:

<form id="form1" name="form1" enctype="multipart/form-data" method="post" action="formtest_process.php">
  uploadfile
    <input type="file" name="userfile" />
	<input name="submit" type="submit" value="submit" />
</form>

here is my entire process php file

<?
ini_set('display_errors', 1); // change to 0 once it's ready for production 
error_reporting(E_ALL); 
$uploaddir = 'uploads/';
$uploadfile = $uploaddir . basename($_FILES['userfile']['name']);
if (move_uploaded_file($_FILES['userfile']['tmp_name'], $uploadfile)) {
    echo "File is valid, and was successfully uploaded.\n";
} else {
    print $uploaddir . basename($_FILES['userfile']['name']);
}
?>

here is my output:

Notice: Undefined index: userfile in /home/fieldsol/public_html/admin/formtest_process.php on line 16

Notice: Undefined index: userfile in /home/fieldsol/public_html/admin/formtest_process.php on line 17

Notice: Undefined index: userfile in /home/fieldsol/public_html/admin/formtest_process.php on line 20
uploads/ 

[VBAssassin]

COuld you post all the code of the file:

formtest_process.php

Kind regards,
Scott

[erron]

thats it above

here it is again:

<?
ini_set('display_errors', 1); // change to 0 once it's ready for production 
error_reporting(E_ALL); 
$uploaddir = 'uploads/';
$uploadfile = $uploaddir . basename($_FILES['userfile']['name']);
if (move_uploaded_file($_FILES['userfile']['tmp_name'], $uploadfile)) {
    echo "File is valid, and was successfully uploaded.\n";
} else {
    print $uploaddir . basename($_FILES['userfile']['name']);
}
?>

[NogDog]

The first index to $FILES needs to be the same as the name of the file-type input field in the form. So for instance you want to refer to:

$_FILES['[color=red]file[/color]']['name']

Or, it might be simpler to just change the name of your file input element to 'userfile' instead of 'file'.

[erron]

NogDog, sorry, mistype in test file, was correct in original file, fixed in test file and still same problem. 🙂

[erron]

ok, all fixed!!

weird one, the folders i was working in was password protected, i removed then reapplied this protection and it now works like a charm.

explain that one!!

thanks for the help guys, much appreciated.