Help with PHP database table

lukeire

Please help with PHP Tables
Please help - I am trying to set up tables using PHP and Oracle. I want the data from Oracle to go into table form using PHP. I have the following code that does return some table headings such as USERID, USERNAME etc. The data from Oracle does not go into the tables though. How do I get the data from Oracle into the table in PHP?

<?php

echo "<pre>";

$db = "*********";
$c1 = oci_connect("somename", "name", $db);

function commit($conn)
{
oci_commit($conn);
echo $conn . " committed\n\n";
}

function select_data($conn)

{
$stmt = oci_parse($conn, "select * from anyname.users");
oci_execute($stmt, OCI_DEFAULT);
echo $conn."----selecting\n\n";

while (oci_fetch($stmt)) {

echo "<table border='3' table width='100%'bordercolor='gray'>";
echo "<tr>
<td align='center'>USERID</td>)
<td align='center'>USERNAME</td>
<td align='center'>USERPASS</td>
<td align='center'>USERMAIL</td>
</tr>";//create row and cells

echo " [" . oci_result($stmt, "USERID") . "] ";
echo " [" . oci_result($stmt, "USERNAME") . "] ";
echo " [" . oci_result($stmt, "USERPASS") . "] ";
echo " [" . oci_result($stmt, "USERMAIL") . "]\n\n";

}

echo $conn . "----done\n\n";
}

select_data($c1); // Results of both inserts are returned
commit($c1); // Commit using c1

echo"</table>";//close table
echo "</pre>";
?>

I am new to PHP but already have pulled significant amounts of hair out trying to get this to work. Any advice would be much appreciated.
Thanks

laserlight

Please indent your code and place them with the php forum bbcode tags.

The problem you have is mainly one of HTML rather than PHP: you need only need to create the table once before the loop, and then create a row on each iteration. Aside from that, $conn should be passed by reference so that it is updated in the caller.

<?php
function commit(&$conn)
{
    oci_commit($conn);
    echo $conn . " committed\n\n";
}

function select_data(&$conn)
{
    $stmt = oci_parse($conn, "select * from anyname.users");
    oci_execute($stmt, OCI_DEFAULT);
    echo $conn."----selecting\n\n";

// Print table header.
echo "<table border='3' table width='100%'bordercolor='gray'>"
    . "<tr>
<td align='center'>USERID</td>
<td align='center'>USERNAME</td>
<td align='center'>USERPASS</td>
<td align='center'>USERMAIL</td>
</tr>\n";

while (oci_fetch($stmt)) {
    echo "<tr>\n"
        . "<td>" . oci_result($stmt, "USERID") . "</td>\n"
        . "<td>" . oci_result($stmt, "USERNAME") . "</td>\n"
        . "<td>" . oci_result($stmt, "USERPASS") . "</td>\n"
        . "<td>" . oci_result($stmt, "USERMAIL") . "</td>\n"
        . "</tr>\n";
}

echo "</table>\n";

echo $conn . "----done\n\n";
}


echo "<pre>";

$db = "*********";
$c1 = oci_connect("somename", "name", $db);

select_data($c1); // Results of both inserts are returned
commit($c1); // Commit using c1

echo "</pre>";
?>

lukeire

Many thanks - apologies for not indenting or doing bbcode tags. I will now try this out although the HTML bit in the first reply has thrown me a bit as I'm kinda new to HTML, PHP and Oracle and was led to believe (by my peers) that all my problems were related to PHP. To be fair my peers aren't that well up either.

Regards

lukeire

Laserlight - thanks very much for solving my problem.

Cheers