improve this

jasondavis

Can this code be improved for performance, it gets the 2 newest mebers of my site

  <?   $sql_latest="SELECT auto_id FROM friend_reg_user ORDER BY auto_id DESC LIMIT 0 , 2";
      $result_latest=executequery($sql_latest);  ?>
                                <tr bgcolor="#EAEAEA"> 
                                  <td colspan="2"><table width="100%" border="0" cellspacing="8" cellpadding="0" class="halfbordergrey">
                                      <tr> 

                              <td width="50%" align="center" valign="top"><?  if($line_latest=mysql_fetch_array($result_latest)){ ?>
									<?=show_user_photo($line_latest[auto_id],$photo_type='small',$user_name='yes') ?> <? } ?></td>
                               <td width="50%" align="center" valign="top"><?  if($line_latest=mysql_fetch_array($result_latest)){ ?>
									<?=show_user_photo($line_latest[auto_id],$photo_type='small',$user_name='yes') ?> <? } ?></td>
                                  </tr>

NogDog

Assuming that auto_id is either the primary key or has an index defined for it in the database table, then I don't see any other obvious way to optimze things.

jasondavis

I just see how this part is ran 2 times


<?  if($line_latest=mysql_fetch_array($result_latest)){ ?>

is there a way to get teh 2 highest auto ids froma table faster?

NogDog

Less code, though not necessarily better performance:

<tr>
<?php
while($line_latest=mysql_fetch_array($result_latest))
{
   echo '<td width="50%" align="center" valign="top">'
        . show_user_photo($line_latest[auto_id], 
                        $photo_type='small', 
                        $user_name='yes')
        . '</td>';
}
?>
</tr>

laserlight

I do not see the need to assign to variables when calling a function, so I would write:

<tr>
<?php
while($line_latest = mysql_fetch_assoc($result_latest))
{
    echo '<td width="50%" align="center" valign="top">'
         . show_user_photo($line_latest['auto_id'], 'small', 'yes')
         . '</td>';
}
?>
</tr>

Oh, and I think it makes sense to just pick one of mysql_fetch_assoc() and mysql_fetch_row() instead of mysql_fetch_array().

NogDog

Heh...I didn't even notice that. The insomnia is catching up with me, I guess. :rolleyes:

jasondavis

Would it be faster to like get the number of rows and assign that to like

$user1 = number of rows

$user2 = number of rows - 1

bradgrafelman

jasondavis wrote:
Would it be faster to like get the number of rows and assign that to like

$user1 = number of rows

$user2 = number of rows - 1

Even if it was faster, this is absolutely not a solution. The number of rows says nothing about the last two users' ID's that exist.

At this point, any optimization you make is probably going to be really small (e.g. small enough to ignore)... if something is running slowly, enable some slow query logging and figure out what it is (if it's a SQL-related issue).