simple optimization

jasondavis

function newfansign() {
	$temp = $_SESSION['info'];
	$sql_friend = "select * from friend_fansign where userid='$temp[auto_id]' and status='Inactive'";
	$result_friend = executeQuery($sql_friend);
	$temp = '';
	if ($line_friend = mysql_fetch_array($result_friend)) {
		return true;
	} else {
		return false;
	}
}

any ideas to optimize this code, it searches my DB for any result of a friend request, also could mysql_fetch_row be used instead of mysql_fetch_array?

laserlight

You could use a SELECT COUNT() instead of a SELECT , and then use [man]mysql_result/man.

function newfansign() {
    $sql = "SELECT COUNT(*) FROM friend_fansign
                WHERE userid='" . $_SESSION['info']['auto_id'] . "'
                    AND status='Inactive'
                LIMIT 1";
    $result = executeQuery($sql);
    return mysql_result($result, 0) != 0;
}

jasondavis

laserlight wrote:

You could use a SELECT COUNT() instead of a SELECT , and then use [man]mysql_result/man.

function newfansign() {
    $sql = "SELECT COUNT(*) FROM friend_fansign
                WHERE userid='" . $_SESSION['info']['auto_id'] . "'
                    AND status='Inactive'
                LIMIT 1";
    $result = executeQuery($sql);
    return mysql_result($result, 0) != 0;
}

so will this line return
return mysql_result($result, 0) != 0;

true or false?

laserlight

You should read the PHP manual concerning the comparison operators.

jasondavis

Thanks that works great I have another for of function which not only check for things but then updates them if they exist

function updatefriendrequest() {
	$temp = $_SESSION['info'];
	$sql_friend = "select * from friend_friend where  friendid='$temp[auto_id]' and alert_message='yes'";
	$result_friend = executeQuery($sql_friend);
	while ($line_friend = mysql_fetch_assoc($result_friend)) {
		$sql_friendupdate = "update friend_friend set alert_message='no' where  friendid='$temp[auto_id]' and autoid='$line_friend[autoid]'";
		executeQuery($sql_friendupdate);
	}
	$temp = '';
}

so in this kind of function could mysql_fetch_assoc be replaced with something faster?

laserlight

This is less on what is the precise PHP function used, and more on the SQL statements. In this case you should be able to run just one SQL statement, e.g.,

function updatefriendrequest() {
    $auto_id = $_SESSION['info']['auto_id'];
    $sql = "UPDATE friend_friend SET alert_message='no'
                WHERE friendid='$auto_id'
                    AND autoid IN (SELECT autoid FROM friend_friend
                                       WHERE friendid='$auto_id'
                                           AND alert_message='yes')";
    executeQuery($sql);
}

halojoy

laserlight wrote:
This is less on what is the precise PHP function used, and more on the SQL statements. In this case you should be able to run just one SQL statement, e.g.,

Yes, this was my thought when reading first post earlier today.
It belongs in the Database forum
... along with all the other MySQL problems normal knowledge people will have.

Just a hint.
Regards 🙂