[RESOLVED] My attempt at creating a login script

Magfersile

Hello all. I'm having difficulties getting a script I wrote to work like I want it to. Of course, it doesn't help matters that I am brand new to PHP coding, but here is my script. Please take a look at it and tell me where I went wrong. . .

<html>
<body>
<?

$con = mysql_connect("localhost","root","");
if (!$con)
{
die('Could not connect: ' . mysql_error());
}
mysql_select_db("game", $con);

$name = $_POST["name"];

$password = $_POST["password"];

$result = mysql_query("SELECT * FROM characters WHERE name = '$name'");

$row = mysql_fetch_array($result);

if ($row['name'] = $name)
echo "Name already exists. Please use a different name.";
else
{
mysql_query("INSERT INTO characters (name, level, xp, stats, password)
VALUES ('$name', '1', '0', '10', '$password');
echo "Character created successfully!";
}

mysql_close($con);
?>
</body>
</html>

When I run the script, it does not return anything to the browser, and nothing is created in the mysql database. The values I am giving the form to return are: 'red' and '123' for the name and password respectively.

halojoy

try echo $name & $password
before the mysql search

well
here it is:

if ($row['name'] == $name)

== for equal

🙂

Horizon88

You should also use the boards builtin tags to format your PHP code. It makes helping you much easier

Magfersile

Welcome.php

<html>
<body>
<?

$con = mysql_connect("localhost","root","123456");
if (!$con)
	{
	die('Could not connect: ' . mysql_error());
	}
mysql_select_db("game", $con);

$name = $_POST["name"];

$password = $_POST["password"];

echo "Name: " . $name . " Password: " . $password;

$result = mysql_query("SELECT * FROM characters WHERE name = '$name'");

$row = mysql_fetch_array($result);

if ($row['name'] == $name)
	echo "Name already exists.  Please use a different name.";
else
	{
	mysql_query("INSERT INTO characters (name, level, xp, stats, 

password)
	VALUES ('$name', '1', '0', '10', '$password');
	echo "Character created successfully!";
	}

mysql_close($con);
?>
</body>
</html>

Ok. I've included the bulletin tags to make it easier to read and re-posted the code with the change that halojoy has suggested. Still, nothing is produced from echoing the $name and $password variables. It seems to me like I may have an error in my html form, so I'm also including the form that accepts the user input. Maybe this will help...

Welcome.html

<html>
<body><form action="welcome.php" method="post">
Name: <input type="text" name="name" />
Password: <input type="password" name="password" />
<input type="submit" value="Submit" />
</form>
</body>
</html>

Horizon88

mysql_query("INSERT INTO characters (name, level, xp, stats,

password)
    VALUES ('$name', '1', '0', '10', '$password');

this is wrong, as the board highlighter shows - you've mismatched your quotes and left off a parens.

mysql_query("INSERT INTO characters (name, level, xp, stats,

password)
    VALUES ('$name', '1', '0', '10', '$password');");

Magfersile

Thank you for posting everyone. It helped me a lot. I finally figured it out and it is working now.