[RESOLVED] Issue embedding HTML in PHP...

sniderman

Hello,
I am having an issue while trying to embed HTML in PHP. I have setup a CRON job to download an XML file from NOAA every so often. I have a small PHP script that parses the XML, and another to format it for display on my webpage.

Here's the rub... I want to use images to display the data. I have created small gifs for the numbers 0 to 9, and want to display those in the place of text. Now, this seems to work with the exception of line 10, which does absolutely nothing as far as I can tell. It isn't displaying my images, or throwing up any errors. If I replace that line with print $y{$x}, it displays the digits in plain text.

I am pretty sure my problem is that I am absolutely lost when it comes to embedding HTML inside PHP tags. Total newbie to PHP here, constructive criticism is most welcome, as is a nudge in the proper direction. Any assistance would be most appreciated.

$y = "";
for ($x=0;
// $weatherArray[temp_f] is the current temperature. i.e. "87"
$x <= strlen($weatherArray[temp_f]);
$y{$x} = $weatherArray[temp_f]{$x},
$x++);

for ($x=0;
$x <= strlen($y);
echo "<img src='images/", $y{$x} +".gif", "' alt='", $y{$x},"' />",
$x++);

NogDog

First thing, unless I'm missing some piece of logic here, the first section of that code seems overly complex, and really not needed in the first place. If all you want to do is assign the value of $weatherArray['temp_f'] to the variable $y, you could just do:

$y = $weatherArray['temp_f'];

That, however, begs the question, "Why bother copying the value of an existing variable to another one?

A cleaner way might be:

$numbers = chunk_split($weatherArray['temp_f'], 1);
foreach($numbers as $digit)
{
   echo "<img src='images/$digit.gif' alt='$digit' />";
}

mikell

First make sure you have error_reporting( E_ALL ); at the top of your script.
That will give you some hints now and then if you're doing something wrong.

I would break that second for loop up like this:
for ($x=0; $x <= strlen($y); $x++){
echo "<img src='images/", $y{$x} +".gif", "' alt='", $y{$x},"' />";
}

And you probably want $x < strlen($y); (not <=). If you turn error reporting
on you should see what I mean.

halojoy

just one little sidenote
that laserlight once told me about
( and he is right in this case)

<?php

// mikell said:
// I would break that second for loop up like this:
// And you probably want $x < strlen($y); (not <=).
// If you turn error reporting on you should see what I mean. 
for ( $x=0; $x <= strlen($y); $x++ ){
	echo "<img src='images/", $y[$x] +".gif", "' alt='", $y[$x],"' />";
}

// halojoy said:
// to adress one character number '2' in a string, we should now use $string[2]
// this old option $string{2}   is now depreciated
// this would give 3rd character as they are numbered 0,1,2,3  ....


?>

halojoy said:
To adress one single character in a string,
we should now use $string[0] $string[2] $string[10] etc. etc.
This old option $string{2} is now depreciated

Not because I have seen it in this topic, ..... but cant be said too often
.. just like this way is very much depreciated: <? :xbones: :mad: :xbones:
You have so little to gain and a lot to lose, by not using
<?php

Anyone too lazy to write 3 extra chars in <?php
should not be writing any php scripts.
Better leave it to somebody clever to do it for them 😃

Regards

sniderman

NogDog, mikell, & halojoy,
I really appreciate you guys taking the time to review this issue and pointing me in the right direction. The script is now doing exactly what I want it to do. Next time any of you venture into Lower Alabama, the beer is on me.