Help with URL Error

amin1982

Hey Guys,

I've tried resolving the following problem for a while now and I haven't been able to find the answer anywhere.

I have recently built a site which is PHP driven.

if you follow this link:

http://www.eliteclubbing.com/eliteparty.php?urlName=thebutteryflylounge you will hopefully see that it works fine!

However if you misspell the URL e.g.

http://www.eliteclubbing.com/eliteparty.php?urlName=thebutteryfl or just leave the urlName i.e. http://www.eliteclubbing.com/eliteparty.php?urlName=

You will receive a blank page.

My code is:

<?php 
require_once(''); 
require_once (''); 
?>
<?php 

$problem = FALSE; 

if (!isset($_GET['urlName'])) {

$urlName = trim($_GET['urlName']);


$url = 'http://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['PHP_SELF']);

if ((substr($url, -1) == '/') OR (substr($url, -1) == '\\') ) {
	$url = substr ($url, 0, -1); 
}

$url .= '/eliteparties.php';

ob_end_clean(); 
header("Location: $url");
exit(); 

} else { 

if (isset($_GET['urlName'])) {

$urlName= trim($_GET['urlName']);

$sql = "SELECT * FROM guestlists WHERE urlName= '$urlName'";

$result = mysql_query($sql, $dbc) or die('Error, query failed');

if (mysql_num_rows($result)) { // Good to go!

$row = mysql_fetch_assoc($result);



?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title><?php echo "{$row['pageTitle']}"; ?></title>

<meta name="description" content="<?php echo "{$row['pageDescription']}"; ?>">
<meta name="keywords" content="<?php echo "{$row['pageKeywords']}"; ?>.">

<meta name="Author" content="Elite Clubbing">
<meta name="Publisher" content="http://www.eliteclubbing.com">
<meta name="copyright" content="Copyright (c) 2007, Elite Clubbing Limited ">
<meta name="Distribution" content="global">
<meta name="Robots" content="INDEX,FOLLOW">
<META NAME="ROBOTS" CONTENT="NOODP">
<meta name="revisit-after" content="1 day">

<!-- RSS FEED -->
<link href="http://www.eliteclubbing.com/eliterss.xml" rel="alternate" type="application/rss+xml" title="Elite Clubbing" />
<!-- RSS FEED -->

<!-- fav icon -->
<link rel="icon" href="http://www.eliteclubbing.com/images/favicon.ico" type="image/x-icon" /> 

<!-- CSS STYLE SHEET -->
<link rel="stylesheet" type="text/css" href=""/>
<!--[if IE]>
<link rel="stylesheet" type="text/css" href="" />
<![endif]-->
<!-- CSS STYLE SHEET -->


</head>

<body>

<!-- start wrapper -->
<div id="wrapper">
<!-- elite logo -->
<div id="header">
</div>
<!-- elite logo -->
<ul class="menu">
<li><a href="http://www.eliteclubbing.com/home.php">Home</a></li>
<li><a href="http://www.eliteclubbing.com/eliteparties.php" class="current">Parties</a></li>
<li><a href="http://www.eliteclubbing.com/photos.php">Photo Gallery</a></li>
<li><a href="http://www.eliteclubbing.com/elitevideogallery.php">Video Gallery</a></li>
<li><a href="http://www.eliteclubbing.com/nightclubs.php" >Night Club Reviews</a></li>
<li><a href="http://www.eliteclubbing.com/membership.php" >Membership</a></li>
<li><a href="http://www.eliteclubbing.com/yourparty.php">Your Party</a></li>
<li><a href="http://www.eliteclubbing.com/elitepress.php">Press</a></li>
<li><a href="http://www.eliteclubbing.com/restaurants.php">Restaurants</a></li>
<li><a href="http://www.eliteclubbing.com/rssfeeds.php">RSS Feeds</a></li>
<li><a href="http://www.eliteclubbing.com/elitelifestyle.php">Lifestyle</a></li>
</ul>
<br style="clear: left" />
<div id="main">
<!-- start main -->
<!-- splits the page into 3 -->
<div id="columnsClubreviews">
<div id="inner">
<div id="leftClubreviews">
<div id="clubsList"> 
<span class="clubsList"> <strong>Elite Clubbing Parties</strong> 
<br />
<br />
<b>Thursday Nights</b>
<br />
<br />
<?
$query = "SELECT * FROM `guestlists` WHERE night='Thursday' AND active='1' ORDER BY title";
$result = mysql_query($query) or die('Error, query failed');
while ($list = mysql_fetch_array($result)) {
echo "<a href ='http://www.eliteclubbing.com/eliteparty.php?urlName={$list['urlName']}' >{$list['title']}</a>
<br>";
}
?>
<br />
<br />
<b>Friday Nights</b>
<br />
<br />
<?
$query = "SELECT * FROM `guestlists` WHERE night='Friday' AND active='1' ORDER BY title";
$result = mysql_query($query) or die('Error, query failed');
while ($list = mysql_fetch_array($result)) {
echo "<a href ='http://www.eliteclubbing.com/eliteparty.php?urlName={$list['urlName']}' >{$list['title']}</a><br>";
}
?>
<br />
<br />
<b>Saturday Nights</b>
<br />
<br />
<?
$query = "SELECT * FROM `guestlists` WHERE night='Saturday' AND active='1' ORDER BY title";
$result = mysql_query($query) or die('Error, query failed');
while ($list = mysql_fetch_array($result)) {
echo "<a href ='http://www.eliteclubbing.com/eliteparty.php?urlName={$list['urlName']}' >{$list['title']}</a>
<br>";
}
?>

</span> 
</div>
</div>
<!-- end left -->
<!-- start content -->
<div id="contentReviews">
<?php

echo "<h1 class='clubname'>{$row['title']}</h1><br><br><br>";

echo "<b>{$row['venue_name']}</b><br>";

echo "<b>{$row['address']}</b><br><br>";

echo "{$row['description']}<br><br>";

echo "<b>When:</b> Every {$row['night']}<br><br>";

echo "<b>Times:</b> {$row['times']}<br><br>";

echo "<b>Dress:</b> {$row['dress']}<br><br>";

echo "<b>Entry:</b> {$row['entry']}<br><br>";

echo "<b>Music:</b> {$row['music']}<br><br>";

if ('' == $row['email'])
{
echo "<b>Guest Lists:</b> Currently Unavailable. For our current nights please <span class='text'><a href='#'>view our events page</a></span> <br>";
}
else
{
echo "<b>Guest Lists:</b> <span class='text'><a href ='mailto:{$row['email']}'>{$row['email']}</a></span> <br>";
} 


?>
<br />
</div>
<!-- end content -->
<div id="rightClubreviews">
<div id="clubimages">
<ul>
<li id="t1"><img class="panelimage" src="<? echo "{$row['image001']}";?>" alt="<? echo "{$row['title']}";?>" width="190" height="126" /></li>
<li id="t1"><img class="panelimage" src="<? echo "{$row['image002']}";?>" alt="<? echo "{$row['title']}";?>" width="190" height="126" /></li>
<li id="t1"><img class="panelimage" src="<? echo "{$row['image003']}";?>" alt="<? echo "{$row['title']}";?>" width="190" height="126" /></li>
<li id="t1"><img class="panelimage" src="<? echo "{$row['image004']}";?>" alt="<? echo "{$row['title']}";?>" width="190" height="126" /></li>
</ul>
</div>
</div>
<div id="googleAds">

</div>
</div>
<!-- end inner -->
</div>
<!-- end columns -->
</div>
<!-- end main -->
<!-- second half of page -->

<div class="clear"></div>
<?php include ("includes/footer.html"); ?>
</div>
<?
}
}
}
?>
<!-- end wrapper -->
</body>
</html>

If i move the final php tags further up the page:

<?
}
}
}
?>

I will see the content of the page that is below these tags.

If you can please help me on this that'll be great. I'm not sure if I need to alter my script or add something new?

Thanks!

halojoy

lets concentrate on the upper part
that is supposed to redirect if no urlName
because if this part does not work, then the rest wont work

1. turn on Full error_reporting( E_ALL );
we have to say this many times a day,
but people seems to not want to use PHP Debugging reporting
while working to setup php application
Stupid!

require_once(''); is useless, doesnt do anything
put in a test echo of $url, and stop script, before header(location) line
just for test ..
This way we do not have to guess, what value it is.

Hopefully we can get info where things go wrong, and so we can solve this.
By put in some small echo, we can track how script is executed

Testing suggestion

<?php

error_reporting( E_ALL ); // FULL php reporting and notices!

$urlName = '':
if(isset($_GET['urlName'])){
    $urlName = trim($_GET['urlName']);
}

if ( empty( $urlName )) {

$url = 'http://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['PHP_SELF']);
if ((substr($url, -1) == '/') OR (substr($url, -1) == '\\') ) {
    $url = substr ($url, 0, -1);
}
$url .= '/eliteparties.php';

echo $url;
exit( '<br>stop' );

header("Location: $url");
exit();
}

//////////////////////////////////////////////////////////////////////////////////////////////////


// To connect to database before this
// would be a waste of time and database/server resources!

// I suppose you would connect to MySQL here
// Where we actually need to use database
require_once( db.connect.php );

// $urlName is not empty
$sql = "SELECT * FROM guestlists WHERE urlName= '$urlName'";
$result = mysql_query($sql, $dbc) or die('Error, query failed');

if (mysql_num_rows($result)) { // Good to go!
    $row = mysql_fetch_assoc($result);
echo 'fetch some result';
}
else{
echo 'no result';
}



?>

mikell

First, just so we are on the same page, isset($_GET['urlName']) is true in all of the below cases:
1. /eliteparty.php?urlName=thebutteryflylounge
2. /eliteparty.php?urlName=thebutteryflyloung
3. /eliteparty.php?urlName=
4. /eliteparty.php?urlName

So in any of these cases, your redirect code is not being executed.
if (!isset($_GET['urlName'])){
//redirect code here
}

Since isset($_GET['urlName']) is true, your select query is run, which searches the guestlist table for whatever $urlName is set to. If you misspell
the url name, or leave it blank, you're not gonna get any results right?

As a result, everything inside the if (mysql_num_rows($result)) block is gonna
get skipped, because mysql_num_rows($result) will be 0.
Note that just about all of your html is inside that block, with the exception of the last 3 lines. (View source on the "empty page" and you will see those last 3 lines.)

If you nest the brackets { with tabs it might help you see whats going on.

What you might want to consider, in addition to what halojoy mentioned, is waiting to decide whether or not to redirect until after you know if the page exists or not.

IE:

$pageExists = 0;
if (isset($_GET['urlName']))
{
//check if page exists...etc
$pageExists = mysql_num_rows($result);
}

if ($pageExists)
{
//output all the html for the page
}
else
{
//redirect