Pagination link problem

[calvin_leonhart]

I'm trying pagination. It works fine, except the 'unhyperlinked' page numbers are 'unhyperlinked' one off.

To see what I mean click here.

I can't seem to fix it. Here is my code:

        $result = mysql_query("SELECT * FROM test");
        $total_entries = mysql_num_rows($result);
        echo "<p><br>";

    if(empty($page)){
            $page = 1;
    }

    $limitvalue = $page * $maxentriestodisplayperpage - ($maxentriestodisplayperpage);

    echo "<table class=\"main\" width=\"$tablewidth%\" border=\"0\"><tr><td></td><td align=\"right\">";

    if($page != 1){
    $pageprev = $page--;

    echo("<a href=\"index.php?page=$pageprev\"></a> ");
}else
    echo(" ");

    $numofpages = $total_entries / $maxentriestodisplayperpage;

for($i = 1; $i <= $numofpages; $i++){

    if($i == $page){
        echo($i." ");
    }else{
        echo("<a href=\"index.php?page=$i\">$i</a> ");
    }

}

if(($total_entries % $maxentriestodisplayperpage) != 0){

    if($i == $page){
        echo($i." ");
    }else{
        echo("<a href=\"index.php?page=$i\">$i</a> ");
    }

}

if(($total_entries - ($maxentriestodisplayperpage * $page)) > 0){

    $pagenext   = $page++;

    echo("<a href=\"index.php?page=$pagenext\"></a>");
}else{
    echo("");
}

mysql_free_result($result);

Thanks. 🙂

[halojoy]

try this

        if($page != 1){
        $pageprev = --$page;

--$page
means: first make $page-1, then make $pageprev = $page
$page--
means: first make $pageprev = $page, then make $page-1

same here

    if(($total_entries - ($maxentriestodisplayperpage * $page)) > 0){

    $pagenext   = ++$page;

it might be you need to change to this instead
$pagenext = ++$page;

[calvin_leonhart]

Hmm, I changed the code and it still does not work. 😕

[halojoy]

hi.

I wrote my own pagination function.
I stole several ideas from you. And added some new ideas.

See my attachement for a ScreenShot.
This function will be alright, if there are not too many pages.
Because it will display all page numbers.

For say less than 30-40 pages it may do well.
Of course details can be changed and added. Like style etc.
I will post function variant in this post
and non-function version in my next post.

Usage:

echo pagin( $pagenumber, $number_of_items, $per_page);

Code with example:

<?php
/// Pagination function
function pagin($currpage, $items, $perpage){
    $p   = $currpage;
    $pmax= ceil($items/$perpage);
    if($p<1||$p>$pmax) $p=1;
    $prv=$p-1;
    $nxt=$p+1;
    $ret ='';
    $ret.= "<table><tr>\n<td style=\"width:2.5em;text-align:right\">";
    if($p!=1)     $ret.="<a href=\"?page=$prv\">Prev</a>";
    else          $ret.="&nbsp;";
    $ret.="</td><td>";
    for($i=1;$i<=$pmax;$i++){
        if($i==$p)$ret.="$i ";
        else      $ret.="<a href=\"?page=$i\">$i</a> ";
    }
    $ret.="</td><td style=\"width:2.5em;text-align:left\">";
    if($p!=$pmax) $ret.="<a href=\"?page=$nxt\">Next</a>";
    else          $ret.="&nbsp;";
    $ret.="</td>\n</tr></table>\n";
    return $ret;
}// END Pagination function
///////////////////////////////////

$page=(isset($_GET['page'])&&ctype_digit($_GET['page']))? $_GET['page']:1;
$items   = 75;
$perpage = 10;

echo pagin($page, $items, $perpage); //Pagination links, top
echo "<hr>\n<p><b>Page $page.</b></p>\n";
// Display Items
$start = 1+$perpage*($page-1);
for($i=$start;$i<($start+$perpage)&&$i<=$items;$i++){
    echo $i.'<br />';
}
echo "\n<p><b>Page $page.</b></p>\n<hr>\n";
echo pagin($page, $items, $perpage); //Pagination links, bottom

?>

[halojoy]

here is the non-function version
with some comments

<?php

$items   = 75;
$perpage = 10;

$page = (isset($_GET['page']) && ctype_digit($_GET['page'])) ? $_GET['page'] : 1;
$pagemax = ceil($items/$perpage);
if($page<1 || $page>$pagemax) $page=1;
$prev=$page-1; $next=$page+1;

// Pagination links, top
echo "<table border=\"0\"><tr><td style=\"width:2.5em;text-align:right\">";
// Prev
if($page!=1) echo("<a href=\"?page=$prev\">Prev</a>");
else         echo("&nbsp;");
echo "</td><td>";
// Page numbers
for($i=1; $i<=$pagemax; $i++){
    if($i==$page) echo("$i ");
    else          echo("<a href=\"?page=$i\">$i</a> ");
}
echo "</td><td style=\"width:2.5em;text-align:left\">";
// Next
if($page!=$pagemax) echo("<a href=\"?page=$next\">Next</a>");
else                echo("&nbsp;");
echo "</td></tr></table>";
// END Pagination

echo "<hr>";
echo "<p><b>Page $page.</b></p>";

// Items
$start = 1+$perpage*($page-1);
for($i=$start;$i<($start+$perpage)&&$i<=$items;$i++){
    echo $i.'<br />';
}

echo "<p><b>Page $page.</b></p>";
echo "<hr>";

// Pagination links, bottom
echo "<table border=\"0\"><tr><td style=\"width:2.5em;text-align:right\">";
// Prev
if($page!=1) echo("<a href=\"?page=$prev\">Prev</a> ");
else         echo("&nbsp;");
echo "</td><td>";
// Page numbers
for($i=1; $i<=$pagemax; $i++){
    if($i==$page) echo("$i ");
    else          echo("<a href=\"?page=$i\">$i</a> ");
}
echo "</td><td style=\"width:2.5em;text-align:left\">";
// Next
if($page!=$pagemax) echo("<a href=\"?page=$next\">Next</a> ");
else                echo("&nbsp;");
echo "</td></tr></table>";

?>