newbie needs help parse syntax error

hypertech

i need immediately help guys, i couldnt login to my site, pls help with this parse error

Parse error: syntax error, unexpected '}' in /home/mysite/public_html/mysite/forum/login.php on line 196

here is the install command:
#
#-----[ OPEN ]------------------------------------------
#
login.php

#
#-----[ FIND ]------------------------------------------
#
if( !$userdata['session_logged_in'] || (isset($HTTP_GET_VARS['admin'])
#
#-----[ IN-LINE FIND ]------------------------------------------
#
&& $userdata['user_level'] == ADMIN
#
#-----[ IN-LINE REPLACE WITH ]------------------------------------------
#
&& ($userdata['user_level'] == ADMIN || in_array($userdata['user_level'], explode(',', $board_config['modcp_levels_used'])))

this is the original login.php file
unedited.txt

and this is my edit login.php file
edited.txt

i really need help. i keep getting the same error

thanks

NogDog

Look at the lines in question (the last line is #196):

	//
	if( !$userdata['session_logged_in'] || (isset($HTTP_GET_VARS['admin']) && ($userdata['user_level'] == ADMIN || in_array($userdata['user_level'], explode(',', $board_config['modcp_levels_used'])))
        }

In your if condition you have 5 opening parentheses, but only 4 closing parentheses. Then on top of that, you have a closing curly brace "}" instead of an opening curly brace "{" to start the block of commands that follow.

hypertech

//
if( !$userdata['session_logged_in'] || (isset($HTTP_GET_VARS['admin']) && ($userdata['user_level'] == ADMIN || in_array($userdata['user_level'], explode(',', $board_config['modcp_levels_used'])))
{

it should be like this instead? sorry, but I'm not really that familiar of this scripts, so pls if u can give me the exact one. I appreciate alot.

thanks

rincewind456

hypertech wrote:
//
if( !$userdata['session_logged_in'] || (isset($HTTP_GET_VARS['admin']) && ($userdata['user_level'] == ADMIN || in_array($userdata['user_level'], explode(',', $board_config['modcp_levels_used'])))
{

it should be like this instead?

No it should be like this

	if( !$userdata['session_logged_in'] || (isset($HTTP_GET_VARS['admin']) && ($userdata['user_level'] == ADMIN || in_array($userdata['user_level'], explode(',', $board_config['modcp_levels_used'])))))
	{

halojoy

sometimes is easier to see what happens
if using several if

for exmple

<?php

if ( a==1 && b==1 ){
    //do with a,b
}

// can be replaced with
if( a==1 ){

if( b==1 ){
    //do with a, b
}

}

?>

NogDog

I believe this is what you are after?

if (
   !$userdata['session_logged_in'] || (
      isset($HTTP_GET_VARS['admin']) && (
         $userdata['user_level'] == ADMIN || 
         in_array (
            $userdata['user_level'], 
            explode(',', $board_config['modcp_levels_used'])
         )
      )
   )
)
{

This is not the only way to format it, but some sort of consistent multi-line, indented format like this makes it easier to read and get the "punctuation" correct for whatever logic you want to implement.

hypertech

hey guys

i really appreciate the help. it works with rincewind script. thanks to all of u. case is solved.

laserlight

Incidentally, use $_GET instead of the deprecated $HTTP_GET_VARS.

dalecosp

... and it's courteous to mark threads "Resolved", as well....

tekky

laserlight wrote:
Incidentally, use $_GET instead of the deprecated $HTTP_GET_VARS.

In his defense, this is an older phpBB that used the deprecated version to maintain a bigger platform market....

My question would be... Why didnt you go back to the phpBB Mods forum where support for these specific things are provided (and likely a patched EasyMod file is available that works as expected)?

Not saying you wouldn't get help here (obviously you did), but... why not go to the source?