$_GET problem in a function

herodesh

Hello.
I have a function that need to read from the database and display infos on a page:
here's the code i'll explain down what i was thinking:

this is the function:

Code:

<?php
function text_areas_populated($pag)
{
  $gs = strtoupper(substr($pag, 0,1)); 
  // get the table first letter. all the fields in the database have an letter to define what table they are in
  //sTitlu_roN, sStire_roN for example.

  echo "Title news Romana<br />";
  echo 	'<input class="titlu" type="text" name="titlu_ro" value="'.$row_get_.$pag['sTitlu_ro'.$gs].'" /><br />';
  /*
  ....
  */
  echo "News Romana<br />";
  echo 	'<textarea name="stire_ro" class="stire">'.$row_get_.$pag['sStire_ro'.$gs].'</textarea><br />';
  /*
  ....
  */
}?>

and this is the calling of the function:

Code:

<?php
$sql_get_news = "SELECT * FROM t_news WHERE nIdN = '".$_GET['id']."'";
$res_get_news = mysql_query($sql_get_news) or die (mysql_error(__LINE__));
$row_get_news = mysql_fetch_array($res_get_news);

echo text_areas_populated ($_GET['pag']); // where page in this case is news

My problem is that nothing is displayed in the input fields.
Can anyone help me with this problem?
Thank you!

halojoy

yourpage.php?id=3&pag=T

try to echo $GET['id'] and $GET['pag'] to begin with

I find this strange in your function

 $gs = strtoupper(substr($pag, 0,1));

  echo     '<input class="titlu" type="text" name="titlu_ro" value="'.$row_get_.$pag['sTitlu_ro'.$gs].'" /><br />';

$row_get_ .... is not defined
$pag ['sTitlu_ro' . $gs] ... is not defined either

what you have, hopefully, is an array
$row_get_news
with one row from table t_news
where nIdN = GET['id']

herodesh

so i have to build a matrix...

bradgrafelman

What you have to do is pass the array of results you got from MySQL, $row_get_news, as a parameter to the text_areas_populate() function. Why? Because the first issue in your script is a scope issue. Example:

<?php
$foo = "Hello world!";

function bar() {
    echo $foo;
}

bar(); // nothing is outputted - $foo is undefined in bar()'s scope
echo $foo; // outputs "Hello World!" since $foo is defined in current scope
?>

The second problem is that you're not using the variable variable notion properly. For variable variable names, you use notation like so:

$foo = 'bar';
$my_bar = 'Hello world!';

echo ${'my_' . $foo}; // outputs $my_bar -- 'Hello world!'

Then again, once you fix the scope issue by passing the result set as a parameter to the function, you shouldn't be using variable variable names at all anyway.