Please help, new to PHP

IbnMuhammad

Hey every one,

I got this problem with my code and would love it if any one could help with this probelm.

Am creating a program that reconises commas in text file (comma delimited code) and i want to implement the same function and loop. This

program should get the file, store it ina array then enter a loop that jumps in to the

function.

here is the txt file:

Take That, Greatest Hits, 2007, 10.99, 35 
50cent, Am Back, 2005, 11.88, 70 
Mike Jone, Never Sing Alone, 2007, 12.99, 30 
Terry Gamble, Alone, 1987, 13.99, 40 
Michael Jackson, Am Bad, 1990, 15.99, 60

The problem is the code below displays this:

Take That
Am Back
2007
13.99
60

It should print all the information in the text file, one after the the other; like this:

Take That
Greatest Hits
2007
10.99
35 
50cent
Am Back
2005
11.88
70 
Mike Jone
Never Sing Alone
2007
12.99
30 
Terry Gamble
Alone
1987
13.99
40 
Michael Jackson
Am Bad
1990
15.99
60

Please help me with my problem. I am very new to programming.

<? 

$filename = "filename.txt"; 
$filepointer = fopen($filename, "r"); 
$myarray = file ($filename); 


for ($mycount = 0; $mycount < count ($myarray);$mycount++) 
{ 

    $aline = $myarray[$mycount]; 

    $cd = getvalue($myarray[0], $mycount); 

    print "$cd" . "<br> \n"; 

} 

function getvalue($file, $mycount) 
{ 

    $intoarray = explode (",", $file); 
    return $intoarray[$mycount]; 

} 
fclose($filepointer); 
?>

The array has this content from a txt file:

Array
(
    [0] => Take That, Greatest Hits, 2007, 10.99, 35

[1] => 50cent, Am Back, 2005, 11.88, 70

[2] => Mike Jone, Never Sing Alone, 2007, 12.99, 30

[3] => Terry Gamble, Alone, 1987, 13.99, 40

[4] => Michael Jackson, Am Bad, 1990, 15.99, 60
)

[ Mod Edit - bpat1434 ] Please use netiquette when posting. There is NO need to shout (use all caps) your subject or any lines in your posts. We have vBCode here for stylization and the creation of emphasis. I have removed your shouting and replaced it with nicer text (kept the same meaning, cleaned up the english a little bit too.)

Piranha

I will give you one link, and it is actually the best help you can get. At least when it comes to how to ask for help.

http://catb.org/~esr/faqs/smart-questions.html#intro

I know that it is the first time you post here, but it is never to early to learn this.

bpat1434

Step through your code with me here. And take the time to read all my notes:

<?

$filename = "filename.txt";
$filepointer = fopen($filename, "r");
$myarray = file ($filename);

/*
So now, $myarray is an array of the text-file lines.  Each line is an array element.  There are count($myarray) (in your example 5) elements.
*/


for ($mycount = 0; $mycount < count ($myarray);$mycount++)
{

/*
Okay, so we're going to make use of a "local" variable $aline to keep track of where we are (and to make things easier), good.
*/
        $aline = $myarray[$mycount];
/*
$aline now contains whatever line we're on.  For the first itteration, it's:
Take That, Greatest Hits, 2007, 10.99, 35
*/

    $cd = getvalue($myarray[0], $mycount);
/*
So here we call your custom function... but wait, what's this?  $myarray[0]?  Let's see what that value is:
$myarray = array(
[0] => Take That, Greatest Hits, 2007, 10.99, 35

[1] => 50cent, Am Back, 2005, 11.88, 70

[2] => Mike Jone, Never Sing Alone, 2007, 12.99, 30

[3] => Terry Gamble, Alone, 1987, 13.99, 40

[4] => Michael Jackson, Am Bad, 1990, 15.99, 60
)

Hmm... so ever time you call this function getvalue, you're passing the same element: $myarray[0] (Take That, Greatest Hits, 2007, 10.99, 35).
*/

    print "$cd" . "<br> \n";
/*
Okay, we're printing the results of the getvalue function.
*/

}

/*
Nothing wrong with this function.  Should work as expected, so long as $mycount is never higher than the highest index of the $intoarray array.
*/
function getvalue($file, $mycount)
{

    $intoarray = explode (",", $file);
    return $intoarray[$mycount];

}
fclose($filepointer);
?>

Do you see where you've gone wrong? You're passing the same element each time to your custom function. Also, you declare a "local" variable ($aline) yet never use it. Why? Perhaps you should replace $myarra[0] with $aline 😉