error_reporting(E_ALL) = nightmare

[jasondavis]

I must show thousands of errors

example of 1

Notice: Use of undefined constant layout - assumed 'layout' in C:\server\www\member\inc\pic.inc.php on line 16

here is line 16 of that file

if($line_user[layout]!=1){

so I dont understand what is wrong with it

Another example

Notice: Undefined variable: newfriendcomment in C:\server\www\member\inc\notifications.inc.php on line 80

here is line 80

<?PHP
 if($newfriendcomment == 1){
?>

and here is where it is set

if(newfriendcomment()){
   $notifications = 1;
   $newfriendcomment = 1;
}

1 more for now

Notice: Undefined index: action in C:\server\www\index.php on line 8

//here is line 8

$page = $_GET['action'];

[laserlight]

Good thing you started, it would be worse when it is millions of errors 😃

If layout is a defined constant whose value is an existing index in the $line_user array, ($line_user[layout]!=1) is perfectly fine. However, you probably want to use the string 'layout' as the index, so you should write what you mean:

if ($line_user['layout'] != 1) {

and here is where it is set

Suppose newfriendcomment() returns false. Now, $notifications and $newfriendcomment do not exist.

As for $_GET['action']: you should check that incoming variables exist using [man]isset[/man] or [man]empty[/man] before actually using them.

[jasondavis]

so just changing

if($line_user[layout]!=1){

//to  this fixes that?

if ($line_user['layout'] != 1) {

//and for $_GET  I changed 

$page = $_GET['action'];

//to this below, is there a better way?

$page = (!empty($_GET['action'])) ? $_GET['action'] : NULL;

[laserlight]

$page = (!empty($GET['action'])) ? $GET['action'] : NULL;

The above is okay, if null is an acceptable value for $page. If not, you should provide a more sensible default.

[jasondavis]

Im not really sure how to fix this one

Notice: Use of undefined constant yes - assumed 'yes' in C:\server\www\config\functions.inc.php on line 250

Notice: Use of undefined constant yes - assumed 'yes' in C:\server\www\config\functions.inc.php on line 251

Notice: Undefined variable: getname in C:\server\www\config\functions.inc.php on line 252

function show_user_photo($user_id, $photo_type = 'big', $user_name = 'yes', $online = 'yes') {
	      $LOCALIP = $_SERVER['REMOTE_ADDR'];
line 250  if($online==yes ){$getonline=',online';}
	      if($user_name==yes ){$getname=',disp_name';}
	      $sql_check = "select auto_id $getonline $getname from friend_reg_user where auto_id='$user_id'";

//rest of function code //////
}

[laserlight]

Look at: $online==yes

What does that mean to you? What are you comparing $online with?

[jasondavis]

So above this code I tried to set it as no like this

$online = 'no';

but that did not work to get rid of error

[laserlight]

No, that is not the problem. Now the problem is a simple syntax error. Read the notice: Use of undefined constant yes - assumed 'yes'.

If you still do not understand, tell me what is the output of this code:

<?php
define('yes', 'no');
echo yes;
?>

[jasondavis]

ok I understand now, so I just change $online==yes to $online=='yes' simple thanks

[halojoy]

jasondavis wrote:

Notice: Use of undefined constant yes - assumed 'yes' in C:\server\www\config\functions.inc.php on line 250
Notice: Use of undefined constant yes - assumed 'yes' in C:\server\www\config\functions.inc.php on line 251
Notice: Undefined variable: getname in C:\server\www\config\functions.inc.php on line 252

Hello.

When you get only Notice:
this still means your script still can run perfectly alright.
When you remove E_ALL, then there will be no notices.

It is good to have it run without Notices,
but it is not required for a script to run without Warning or Error.

But when ever you get Warning or Error
these Notices can be very good help to understand why and what is wrong.

Bottomline:
Notice: .. is not an error .. It is more like a little hint
Warning: .. here you have a real issue, that probably can give an error
Error: .. this is a real error, your script will not work alright

Regards 🙂

[NogDog]

Read up on strings and constants to understand their differences and how they are used. Basically, if a word in your code is not within quotes, does not begin with a "$", and is not a PHP reserved word, then it will be treated as a constant.

Unfortunately, PHP allows the use of undefined constants. It throws a notice (as you have discovered), but it continues processing and automatically defines it at that point as having a value that is the same as its name. At best this is a sloppy way to code, and at worst can lead to very difficult to debug errors -- unless you debug with E_ALL error-reporting so that you can get rid of any such potential problems. 🙂

[MarkR]

It is a good idea to use E_ALL all the time, particularly in development.

It is a better idea to create a custom error handler which screams, shouts, throws its toys out of the pram and stops your page with a huge nasty error as soon as it sees even an E_NOTICE.

Such an error handler should probably dump context information (including a stack trace) to the user, but in development environments only.

In production it could collect the same information but put it on a log instead (giving the user a generic message)

Mark