PHP Date Help

shmuel88

I am trying to write a simple script which will show different content on a page depending on the week and time (it needs to change at 5pm on Friday over the weekend) and I came up with this:

[INDENT]<?php
$day = date("N");
$time = date("H");

if($day = 5) && ($time > 16){
// Friday, at 5
echo(friday)
}
if($day > 5){
// Weekend
echo(Weekend)
}
}else{
// Not Friday or Layer
echo(week)
}
?>[/INDENT]

but I keep getting this error message,
Parse error: syntax error, unexpected T_BOOLEAN_AND in /public_html/test.php on line 5
which I assume is to do with the && but I'm not sure how to fix it.

Thanks

Sam

Nigma_D

looking at this site.

im guessing this should work

if($day == 5 && $time > 16){

edit:
Yea what Nielubie said too...

Nielubie

I think a single "=" assigns data while a double "==" would compare it.

I could be wrong it's been a few months since I last coded.

NogDog

Ah, the old = versus == problem. 🙂 One way to avoid that is to put the literal or constant value on the left side of the operator:

if(5 == $day && 16 < $time) {

Then if you accidentally type a "=" instead of a "==", you'll get a nice parse error saying you can't do that.

Nielubie

Ha, I'm awesome. So after all these months of not programming my brain still remembers some things.. 🙂

halojoy

besides the issue already mentioned,
you should use quotes around words, strings you want to display
also you have to put an semi colon at the end of statements:
Wrong:
echo(friday)
Correct:
echo('friday');

Also you should use 'elseif' in this case for the second test
otherwise your script will not work like you want it to

This may work without errors/notices

<?php

error_reporting( E_ALL ); // debug help of your code

$day  = date("N");
$time = date("H");

if ($day == 5) && ($time > 16){
    // Friday, at 5
    echo('friday');
}
elseif ($day > 5){
    // Weekend
    echo('Weekend');
}
else {
    // Not Friday or Layer
    echo('week');
}

?>

Nigma_D

halojoy wrote:

<?php

error_reporting( E_ALL ); // debug help of your code

$day  = date("N");
$time = date("H");

if ($day == 5) && ($time > 16){
    // Friday, at 5
    echo('friday');
}
elseif ($day > 5){
    // Weekend
    echo('Weekend');
}
else {
    // Not Friday or Layer
    echo('week');
}

?>

ah man...i was wrong AND totaly missed the semi colon`s missing.
thank god its not my work to work with php or i would so be fired right now:bemused:

halojoy

Nigma D wrote:
ah man...i was wrong AND totaly missed the semi colon`s missing.
thank god its not my work to work with php or i would so be fired right now:bemused:

🙂
I am sure you would have noticed, if you had taken the time, to look further.
I guess I have more time at my hands, than most people.
And many eyes will see more than just 2 eyes.
This is the good with posting your code problems here.
🙂

shmuel88

Thanks for the help, only I still get the same error message, only on line 8 on the new code

<?php

error_reporting( E_ALL ); // debug help of your code

$day  = date("N");
$time = date("H");

if ($day == 5) && ($time > 16){
    // Friday, at 5
    echo('friday');
}
elseif ($day > 5){
    // Weekend
    echo('Weekend');
}
else {
    // Not Friday or Layer
    echo('week');
}

?>

on line 8 and when I tried removing the brackets:

if ($day == 5 && $time > 16){

it just shows the message for the week.

Thanks

Sam

future448

if (($day == 5) && ($time > 16)){

NogDog

Are you using PHP 5.1.0 or later? If not, the 'N' format character will not be available for [man]date/man.

halojoy

shmuel88 wrote:
on line 8 and when I tried removing the brackets:
if ($day == 5 && $time > 16){
it just shows the message for the week.

Yes, that is the line you should use. You have corrected my mistake.

If it shows only 'week'
then it is because, (N) the time is not past 16.00 Friday

N	= the day of the week,	1 (for Monday) through 7 (for Sunday)

shmuel88

No it's PHP4, but will using w work instead of N?
Thanks

NogDog

shmuel88 wrote:
No it's PHP4, but will using w work instead of N?
Thanks

Yeah, but it starts with 0 on Sunday. I might do the following to keep things easy to read and maintain:

$day = date('l');  // weekday name (lower-case L)
$hour = date('G'); // hour 0-23
if($day == 'Saturday' or $day == 'Sunday' or ($day == 'Friday' and $hour > 16))
{
   // do weekend stuff
}
else
{
   // do regular weekday stuff
}

shmuel88

Thanks for help everyone... finally got it working 🙂