look for an item in an array... if its found update it

[scrupul0us]

heres my code:

if (isset($_GET['additem']))
{
	$found = FALSE; 

foreach( $_SESSION["cart"] AS $key=>$val )
{
	if ($val["name"] == $_GET['additem']) 
	{
		$_SESSION["cart"][$key]['qty']++;
		echo "Item Updated: ".$_GET['additem']."<br/><br/>";
		$found = TRUE;
	}
}

if ($found == FALSE)
{
array_push($_SESSION["cart"],array("name"=>$_GET['additem'],"qty"=>"1"));
echo "Item Added: ".$_GET['additem']."<br/><br/>";	
}
}

this seems sloppy making a variable to toggle things being $found... is there a better way?

[halojoy]

you need to use one flag
to show after the loop if item was found or not

I have added $match = false;
When an item is found and 'qty' updated, we set
$match=true;
and break out from search loop with
break;

I used some testvalues for $additem.
Script works!

<?php

session_start();
// make a cart, if there is no
if(!isset($_SESSION['cart']))
    $_SESSION['cart'] = array();

$additem = isset($_GET['additem']) ? $_GET['additem'] : false;

$additem = 'blue'; // testitem
$additem = 'red';  // testitem

if($additem !== false){
    $match = false;
    foreach( $_SESSION['cart'] AS $key => $item ){
         if($item['name'] == $additem){
             $_SESSION['cart'][$key]['qty']++;
             echo 'Item Updated: '.$additem."<br/><br/>";
             $match = true;
             break;
         }
    }
    if($match===false){
        array_push($_SESSION['cart'], array('name'=>$additem,'qty'=>1));
        echo 'Item Added: '.$additem."<br/><br/>";
    }    

}

echo '<pre>'.print_r($_SESSION["cart"], true).'</pre>';

[Weedpacket]

halojoy wrote:

I have added $match = false;
When an item is found and 'qty' updated, we set
$match=true;
and break out from search loop with
break;

So you've added a break and changed the name of the flag variable.

Are the names that are used to identify items unique? If they are, can they be used as identifiers in the array instead of an (arbitrary) key?

if(isset($_GET['additem'])
{
	if(isset($_SESSION['cart'][$_GET['additem']]))
	{
		$_SESSION['cart'][$_GET['additem']]['qty']++;
        echo "Item Updated: ".$_GET['additem']."<br/><br/>";
	}
	else
	{
		$_SESSION['cart'][$_GET['additem']] = array('qty'=>1);
        echo "Item Added: ".$_GET['additem']."<br/><br/>";
	}
}

If qty is the only thing being stored, then it doesn't need to be stored as a one-element array, but directly:

if(isset($_GET['additem'])
{
	if(isset($_SESSION['cart'][$_GET['additem']]))
	{
		$_SESSION['cart'][$_GET['additem']]++;
        echo "Item Updated: ".$_GET['additem']."<br/><br/>";
	}
	else
	{
		$_SESSION['cart'][$_GET['additem']] = 1;
        echo "Item Added: ".$_GET['additem']."<br/><br/>";
	}
}

Note throughout this that there is nothing to check that $_GET['additem'] is legitimate.