[RESOLVED] upload validation images

[snapbackz]

I was wondering if this is a secure way to check for a image file?

$target_path = "/home/path/to/uploadfolder/";
$target_path = $target_path . basename( $_FILES['picture']['name']); 


if(!empty($_FILES['picture']['tmp_name'])){	
	$types = array('image/gif', 'image/jpg', 'image/jpeg', 'image/png', 'image/bmp');

if(in_array($_FILES['picture']["type"], $types))
{

	if(move_uploaded_file($_FILES['picture']['tmp_name'], $target_path)){
                 //it's valid and moved
}

}

}

[NogDog]

Since the type value in the $_FILES array comes from the client, no, it is not a safe way to validate the file type. Not all clients will provide a value even when a valid file is uploaded, while a hacker with even minimal skills will be able to spoof it.

Probably your best bet would be to use the [man]getimagesize/man function to get the image type, assuming you have the GD library installed and enabled and it supports all of the image types you want to allow.

[snapbackz]

$target_path = "/home/path/to/uploadfolder/";
$target_path = $target_path . basename( $_FILES['picture']['name']); 

if(!empty($_FILES['picture']['tmp_name'])){	
	$types = array('image/gif', 'image/jpg', 'image/jpeg', 'image/png', 'image/bmp', 'image/JPG', 'image/pjpeg', 'image/GIF');

$size = getimagesize($_FILES['picture']['tmp_name']);

if(in_array($size['mime'], $types))
{

	if(move_uploaded_file($_FILES['picture']['tmp_name'], $target_path)){

	if(move_uploaded_file($_FILES['picture']['tmp_name'], $target_path)){
                 //it's valid and moved
}

}

}

How's that look then?

[NogDog]

If you wanted, you could condense it down to:

$target_path = "/home/path/to/uploadfolder/";
$target_path = $target_path . basename( $_FILES['picture']['name']);

if(!empty($_FILES['picture']['tmp_name'])) {
   $size = getimagesize($_FILES['picture']['tmp_name']);
   if($size[2] & imagetypes()) {  // note use of bitwise "&" operator, not "&&"
      if(move_uploaded_file($_FILES['picture']['tmp_name'], $target_path)) {
         //it's valid and moved
      }
   }
   else {
      // invalid file type -- not a recognized image type
   }
}

[snapbackz]

ahh, very cool. Thanks, learned a lot!