Function problem....If not testing correct

wilburburns

function cleanupformat($roundval)
{
	if($roundval == $Detail_RS1['bwlimit'])
		{
		echo "This works";
		}
		else
		{
		echo $Detail_RS1['bwlimit']; // This line fails also
		echo $roundval;
		echo "Failed";
		}
}

Ok, the above code is always failing. However, if I echo $Detail_RS1['bwlimit'] outside of this function, I return the same value as $roundval from the function.

Any help appreciated..

Cliff

laserlight

Perhaps you want to pass $Detail_RS1 to the function?

wilburburns

I am later on in the page with, or at least I think I am.

<?php cleanupformat($Detail_RS1['bwlimit']); ?>

From the database query,

$Detail_RS1['bwlimit']

returns a value of 41000

From the Function

$roundval

returns a value of 41000

However, the If statement is failing every time.

By changing my IF statement to the following I get the correct results, but this is hardcoding a value instead of reading from the Database.

if($roundval == 41000)

laserlight

You are using $Detail_RS1['bwlimit'] in the function, but passing it as an argument such that, in the function, it is $roundval. $Detail_RS1['bwlimit'] does not exist in the function.

To better illustrate this, try:

function cleanupformat($roundval)
{
    echo '$roundval = "' . $roundval . '"<br />'
        . '$Detail_RS1[\'bwlimit\'] = "' . $Detail_RS1['bwlimit'] . '"<br />';
    if($roundval == $Detail_RS1['bwlimit'])
    {
        echo "This works";
    }
    else
    {
        echo "Failed";
    }
}

Also, remember to set error_reporting to E_ALL in php.ini and set display_errors to On.

wilburburns

Ahhh, Ok. I see what you mean now.

Although, I should have posted this in the Newbie Forum, I don't know how to pass $Detail_RS1 to the Function.

ARRGGHHHH

Cliff

laserlight

Well, what is the function supposed to do?

wilburburns

this is a basic outline of what I am trying to do.

I have 3 different values from different columns in a table. The Formatting for each column is different. I want to use this function to test which column the data came from and format the output accordingly.

Here's the complete formatting code for the first column.

function cleanupformat($roundval)
{
	if($roundval == $row_DetailRS1['bwlimit'])
		{
		$bw= round(number_format(($roundval/10000) ,1 , ".",""))*10;
		echo $bw ."gb";
		}
		else
		{
		echo "Failed";
		}
        if($roundval == $row_DetailRS1['quota'])
                { Other Formating }
        if($roundval == $row_DetailRS1['amount'])
                { Other Formating }

}

*Note, I realize that the $row_DetailRS1['bwlimit'] is different from what I have been posting. However, this is the correct variable. My initial posts had the typographical error.

Is there a better way to handle this?

Cliff

wilburburns

OK, If place

global $row_DetailRS1;

into my Function this works.

Is this the way you would recommend doing this laserlight?

I have been reading about global variables all day, but it wasn't sinking in..

Cliff

Weedpacket

wilburburns wrote:
Is this the way you would recommend doing this laserlight?

I wouldn't, personally. I'd pass $row_DetailRS1['bwlimit'] into the function.

And the way I'd do that would be the same way that I'm passing $roundval into the function.

function cleanupformat($bwlimit, $roundval)
{
   if($roundval==$bwlimit)
  {
   // .... succeed
  }
  else
  {
  // .... fail
  }
}

<?php cleanupformat($Detail_RS1['bwlimit'], $roundval); ?>

wilburburns

Weedpacket wrote:
I wouldn't, personally. I'd pass $row_DetailRS1['bwlimit'] into the function.

And the way I'd do that would be the same way that I'm passing $roundval into the function.
function cleanupformat($bwlimit, $roundval)
{
   if($roundval==$bwlimit)
  {
   // .... succeed
  }
  else
  {
  // .... fail
  }
}
<?php cleanupformat($Detail_RS1['bwlimit'], $roundval); ?> 

OK, I think I see what you are doing, but I don't think this will work for me. Or I could still be lost.

$roundval is not given a value (Actually, I believe it is a Null value "0") when being passed into the function. Therefore, when doing my test "IF" , it does not "fail", but returns a value of "0".

Do you mean that I should use the following code?

<?php cleanupformat($row_DetailRS1['bwlimit'], /*$roundval*/$row_DetailRS1['bwlimit']); ?>

While this works for the first "if" statement, I don't believe this will work for the other "if" statements, because I am never really testing what $roundval is.

In all reality, I don't really need this function at all. For the First "If" Statement, I could use this single line to get the format I am looking for.

<?php round(number_format(($row_DetailRS1['bwlimit']/10000) ,1 , ".",""))*10; ?>

However, I am trying to use this as a learning experience, because I have several ideas in my head where re-useable Code in the form of a Function should be a huge benefit.

Thanks,
Cliff