Ternary Operator issues

[noobyphpchick]

Hi
Well i've tried out tenuary expressions and think i understand them, they are just shorthand if's aren't they, they don't seem to be working with my code, can anyone see where ive gone wrong, the options are not appearing at all in the drop down, and ive played around with the syntax and can get them to appear but they don't keep selected. really appreciate your advice 🙂
<p>
<label for="gender">Gender:</label>
<input type=radio checked name="gender" value= "male">Male
<input type=radio name="gender" value="female" >Female
<font size="2" color="red"><?php print "$gendermessage" ?></font><p>

<p>
<label for="exercise">Weekly Exercise:</label>
<select name ="exercise">
<option value ="$POST[exercise]"></option>
<option selected></option>
<option".(isset($POST[exercise]) && $POST[exercise] == ' '? ' selected ' : ' ')."value=" "> </option>
<option".(isset($POST[exercise]) && $POST[exercise] == '0'? ' selected ' : ' ')."value="0">0</option>
<option".(isset($POST[exercise]) && $POST[exercise] == '2'? ' selected ' : ' ')."value="2">2</option>
<option".(isset($POST[exercise]) && $POST[exercise] == '3'? ' selected ' : ' ')."value="3">3</option>
<option".(isset($POST[exercise]) && $POST[exercise] == '4'? ' selected ' : ' ')."value="4">4</option>
<option".(isset($POST[exercise]) && $POST[exercise] == '5'? ' selected ' : ' ')."value="5">5</option>
<option".(isset($POST[exercise]) && $POST[exercise] == '6'? ' selected ' : ' ')."value="6">6</option>
<option".(isset($POST[exercise]) && $POST[exercise] == '7'? ' selected ' : ' ')."value="7">7</option>
<option".(isset($POST[exercise]) && $_POST[exercise] == '8'? ' selected ' : ' ')."value="8">8</option>
</select> hours
<font size="2" color="red"><?php print "$exmessage" ?></font><p>

[wilku]

You have forgotten about <?php in options. Besides you can make your life easier:

<select name ="exercise">
<?php
 $options = array('',0,2,3,4,5,6,7,8);
 foreach ($options as $option)
 {
  echo '<option value="'.$option.'"';
  if (isset($_POST['excercise'])&&$_POST['excercise']==$option) echo ' selected';
  echo '>'.$option.'</option>';
?>
 </select> hours

[bpat1434]

noobyphpchick: please open separate threads for separate issues so things don't get "lost".... I've created a new topic for you.

[YAOMK]

If you are doing inline php, try this:

<option  value="7" <?php (isset($_POST[exercise]) && $_POST[exercise] == '7')? ' selected ':null ?>>7</option>

When I suggested the ternary operator I did so for text fields and radio buttons, I did so because it keeps the condition in one line, making the code more compact. I didn't test the above code, but it should give you an idea

EDIT: bpat1434 I didn't realize the split as I was posting when you decided to split the thread, please allocate this comment to the respective new thread, thank you.

[noobyphpchick]

oops sorry bpat1434 for the change of subject in the one post won't happen again.

I have some weird problems now, the code that wilku posted- array one works well but the drop down list only shows the last option but when you choose this it does work and keep the selection after submit, ive googled for hours on this one but have had no luck as yet.

In the inline php code the options are there but the error message does not print when it should and the selected option does not keep the selection in the actual selection box but will print the selected value next to the box if i add print $_POST[exercise]. ive fiddled the code around but just made it worse lol

anyone have any ideas?
thanks for all this help🙂

[noobyphpchick]

a shameless bump
but also found some similar code which almost works- can anyone help me tweak it?
the problem is the drop down starts at 0 not at " " so the drop down is always on a selected valid selection so it doesn't get caught by the validation.
how can you make the drop down start on a space before the options, is it possible to add space to an array?

heres the code

<select name="exercise" size="1">
<option value=""></option>
<? foreach(array(0,1,2,3,4,5,6,7,8) AS $value) {?>
<option value="<?=$value?>"<?=($exercise==$value)?' selected="selected"':''?>><?=$value?></option>
<? }?>
</select>

[bpat1434]

You need to add a empty array element to your array() declaration:

<? foreach(array('',0,1,2,3,4,5,6,7,8) AS $value) {?>

[noobyphpchick]

Thanks🙂
I have managed to get it working with

$options = array('',0,2,3,4,5,6,7,8);
foreach ($options as $option)
{
    echo '<option value="' . $option . '"' . (isset($_POST['exercise']) && $_POST['exercise'] == $option ? ' selected' : '') . '>' . $option . '</option>';
}

it works ok, but if you don't make a selection first time on submit it will select 0 for you, can't work out why but am very pleased it keeps the value through the rest of the validation.
Got worse probs now anyway- is this normal to think your finished and then bang you found another bug!
thanks for you help 🙂

[bpat1434]

Thinking you're finished, then finding another bug .... well it's a never-ending cycle. You're never done!!! 🙂