settype returns 1

[herschen]

I have a variable that is passed from a form to a php file to be processed. Anytime I try to convert this variable from a string to an integer (using settype, or just letting MySQL convert it), the value it returns is 1. How can I fix this, please?

Right now, I'm using a function that I borrowed from Dreamweaver...it has the same behavior.

<?php require_once('../Connections/connProperties.php'); ?>
<?php

if (!function_exists("GetSQLValueString")) {
function GetSQLValueString($theValue, $theType, $theDefinedValue = "", $theNotDefinedValue = "") 
{
  $theValue = get_magic_quotes_gpc() ? stripslashes($theValue) : $theValue;

  $theValue = function_exists("mysql_real_escape_string") ? mysql_real_escape_string($theValue) : mysql_escape_string($theValue);

  switch ($theType) {
    case "text":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;    

    case "long":
    case "int":
      $theValue = ($theValue != "") ? intval($theValue) : "NULL";
      break;
    case "double":
      $theValue = ($theValue != "") ? "'" . doubleval($theValue) . "'" : "NULL";
      break;
    case "date":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;
    case "defined":
      $theValue = ($theValue != "") ? $theDefinedValue : $theNotDefinedValue;
      break;
  }
  return $theValue;
}
}

   $num_files = $_POST['total_images'];
   $error = 0;

   for ($i = 1; $i <= $num_files; $i++) {
	  for ($num = 1; $num <= $num_files; $num++) {
	    if ($_POST['new_picorder'.$num] == $_POST['new_picorder'.$i]) {
		     $error++;
		   }
	   }
	}
for ($i = 1; $i <= $num_files; $i++) {
	   if ($error == $num_files) {
	      	     $updateSQL = sprintf("UPDATE propertiesimages SET picorder = %s WHERE propertyid=%s AND picorder = %s",
                       GetSQLValueString($_POST['new_picorder'.$i], "text"),
					   GetSQLValueString($_POST['propertyid'], "int"),
					   GetSQLValueString($_POST['old_picorder'.$i], "text"));

				   mysql_select_db($database_connProperties, $connProperties);
                   $Result1 = mysql_query($updateSQL, $connProperties) or die(mysql_error());  

	} else {
	  echo "You cannot have images with the same order number. Please click the back button and adjust";
	  break; 
	}
	}	

?>

[bpat1434]

Okay, why not just define the propertyid in the sprintf statement to be a digit using %d instead of a string %s.......

I don't see your use of settype here. I see intval(), but not settype. Where are you using it? And settype should return 1 (or bool true) when it successfully changes the variable to whatever type. You don't want to capture the output as the new variable, just know the variable's type changed.

[herschen]

I believe that switching %s to %d was important...but the problem I described still exists. And please let me clarify, I tried using settype to convert $_POST['new_picorder'.$i] to see what value it returned before it was inserted into the sprintf function. Sorry that wasn't clear in my first post.

I am stumped. I am passing old_picorder and propertyid as hidden form fields. propertyid originally comes from a URL parameter and old_picorder comes from the table that I am updating. I know that these two fields are being passed correctly in the query since only the rows where 'propertyid' = 36 are being updated (and all the rows--not just those where 'picorder' = 1--are being updated).

When I print $_POST['new_picorder'.$i] to the screen before settype, it prints correctly. After it has been converted to an integer (regardless of the method), it always becomes '1.'

I'm posting both the form and the php script below (The HTML may appear incomplete as I omitted the uneditable template info). Thank you for your help.

<?php require_once('../Connections/connProperties.php'); ?>
<?php
if (!function_exists("GetSQLValueString")) {
function GetSQLValueString($theValue, $theType, $theDefinedValue = "", $theNotDefinedValue = "") 
{
  $theValue = get_magic_quotes_gpc() ? stripslashes($theValue) : $theValue;

  $theValue = function_exists("mysql_real_escape_string") ? mysql_real_escape_string($theValue) : mysql_escape_string($theValue);

  switch ($theType) {
    case "text":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;    

    case "long":
    case "int":
      $theValue = ($theValue != "") ? intval($theValue) : "NULL";
      break;
    case "double":
      $theValue = ($theValue != "") ? "'" . doubleval($theValue) . "'" : "NULL";
      break;
    case "date":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;
    case "defined":
      $theValue = ($theValue != "") ? $theDefinedValue : $theNotDefinedValue;
      break;
  }
  return $theValue;
}
}

$colname_rsImages = "-1";
if (isset($_GET['propertyid'])) {
  $colname_rsImages = $_GET['propertyid'];
}
mysql_select_db($database_connProperties, $connProperties);
$query_rsImages = sprintf("SELECT * FROM propertiesimages WHERE propertyid = %s ORDER BY picorder", GetSQLValueString($colname_rsImages, "int"));
$rsImages = mysql_query($query_rsImages, $connProperties) or die(mysql_error());
$row_rsImages = mysql_fetch_assoc($rsImages);
$totalRows_rsImages = mysql_num_rows($rsImages);



?>

<form method="post" action="update_images_process.php" name="update_image" method="post">
                              <table width="100%" border="0">
                                <tr>
                                  <td width="35%">&nbsp;</td>
                                  <td width="65%">Order to view images (first 5 are the main images):</td>
                                </tr> </table>
                              <?php do { ?>
                                <table width="100%" border="0">
                                  <tr>
                                    <td width="35%"><img src="<?php echo $row_rsImages['path']; ?>" width="200" height="150" /></td>
                                    <td width="65%"><label>
                                      <?php echo "<input name=\"new_picorder" . $row_rsImages['picorder'] . "\" type=\"text\" id=\"new_picorder" . $row_rsImages['picorder'] . "\" size=\"2\" />"?>
									  <?php echo "<input name=\"old_picorder". $row_rsImages['picorder'] . "\" type=\"hidden\" id=\"old_picorder". $row_rsImages['picorder'] . "\" value=\"". $row_rsImages['picorder']."\">" ?>

                                </label><?php echo $row_rsImages['picorder'];
								$total_images = $row_rsImages['picorder'];?></td>
                              </tr>
                            </table>
                            <?php } while ($row_rsImages = mysql_fetch_assoc($rsImages)); ?>
                            <?php echo "<input name=\"total_images\" type=\"hidden\" id=\"total_images\" value=\"$total_images\">
							<input name=\"propertyid\" type=\"hidden\" id=\"propertyid\" value=\"$colname_rsImages\">
							<input type=\"submit\" name=\"update_images_now\" value=\"Update Now!\">" ?>
                            </form>

<?php require_once('../Connections/connProperties.php'); ?>
<?php

if (!function_exists("GetSQLValueString")) {
function GetSQLValueString($theValue, $theType, $theDefinedValue = "", $theNotDefinedValue = "") 
{
  $theValue = get_magic_quotes_gpc() ? stripslashes($theValue) : $theValue;

  $theValue = function_exists("mysql_real_escape_string") ? mysql_real_escape_string($theValue) : mysql_escape_string($theValue);

  switch ($theType) {
    case "text":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;    

    case "long":
    case "int":
      $theValue = ($theValue != "") ? intval($theValue) : "NULL";
      break;
    case "double":
      $theValue = ($theValue != "") ? "'" . doubleval($theValue) . "'" : "NULL";
      break;
    case "date":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;
    case "defined":
      $theValue = ($theValue != "") ? $theDefinedValue : $theNotDefinedValue;
      break;
  }
  return $theValue;
}
}

   $num_files = $_POST['total_images'];
   $error = 0;

   for ($i = 1; $i <= $num_files; $i++) {
	  for ($num = 1; $num <= $num_files; $num++) {
	    if ($_POST['new_picorder'.$num] == $_POST['new_picorder'.$i]) {
		     $error++;
		   }
	   }
	}
for ($i = 1; $i <= $num_files; $i++) {
	   if ($error == $num_files) {
	      	     $updateSQL = sprintf("UPDATE propertiesimages SET picorder = %d WHERE propertyid=%d AND picorder = %d",
                       GetSQLValueString($_POST['new_picorder'.$i], "int"),
					   GetSQLValueString($_POST['propertyid'], "int"),
					   GetSQLValueString($_POST['old_picorder'.$i], "int"));

				   mysql_select_db($database_connProperties, $connProperties);
                   $Result1 = mysql_query($updateSQL, $connProperties) or die(mysql_error());  

	} else {
	  echo "You cannot have images with the same order number. Please click the back button and adjust";
	  break; 
	}
	}	

?>

[herschen]

I changed my syntax and stopped trying to convert new_picorder to an integer, converted the database column 'picorder' to a VARCHAR and I still had the same problem. However when I added echo $new_picorder . "<br>"; to the syntax below, the correct numbers printed to the screen.

for ($i = 1; $i <= $num_files; $i++) {
	   if ($error == $num_files) {
	   $new_picorder = $_POST['new_picorder'.$i];
	   $propertyid = $_POST['propertyid'];
	   $old_picorder = $_POST['old_picorder'.$i];
	             mysql_select_db($database_connProperties, $connProperties);
	      	     $updateSQL = "UPDATE propertiesimages SET picorder='$new_picorder' WHERE propertyid='$propertyid' AND picorder='$old_picorder'";



                   $Result1 = mysql_query($updateSQL, $connProperties) or die(mysql_error());

[bpat1434]

Okay, I'm still not seeing where you're using settype.... I see you use type-casting with the (int) but not settype the function.

Now, what are you supplying as the "$new_picorder" variable and what do you expect the result to be? Is there truly working code that works as you expect, or are you just assuming Dreamweaver made correct code?

[herschen]

I am not using settype. I tried to make this as clear as possible in my second response. Sorry. I used it as a test, to see what happened when I tried converting the string in $_POST['new_picorder'.$i] to an integer.

So here's the deal: I have four form fields that I am passing from my form to this script: total_images (the total amount of images being updated), propertyid (the property for which the images are being updated), old_picorder (the old order in which these images would be displayed), and new_picorder (the new order).

My first for loop makes sure there are no duplicate numbers in new_picorder and the second loop should insert these new numbers into the picorder column of my database (only for the specified propertyid).

Obviously the first two numbers are being inserted correctly because:

a) the 'propertyid' that I am testing (36) is the only one that gets modified in the database. If this form field reverted to 1 when being inserted into the database, 'propertyid' 1 would have been modified.

b) all the values in the database with 'propertyid' 36 get updated, not just the first one. If 'old_picorder' reverted to 1 when being inserted into the database, only the row with the 'picorder' value 1 would be updated.

c) I changed the value being inserted into the database to old_picorder. The update worked perfectly (albeit with the wrong numbers).

Please tell me: what is the difference between old_picorder and new_picorder? Why does one work fine and the other doesn't?

[bpat1434]

Okay, so now you're not type-casting anything? You're just inserting strings?

[herschen]

That pretty much sums it up. I've tried to make this script as simple as possible to deduce what is causing this problem.

I do nothing to the POST variable 'new_picorder' (or any other POST variable), and I have converted the column 'picorder' to VARCHAR. And when I insert the variable 'new_picorder' into the database it always inserts '1.' So here's why I think the problem lies with the variable 'new_picorder.' It won't insert into the database correctly (even now that it's text being inserted into a VARCHAR column), anytime I try to alter it in any way it converts its value to '1' and the same does not happen with the other POST values. It might be noted that the other POST values come from a URL parameter and the mySQL database, whereas 'new_picorder' is a text form field.

Again, thank you for your patience.

[bpat1434]

Okay, so how about some sample data. What is old_picorder and what is new_picorder when you submit the form (before you type-cast or anything)?

[herschen]

I'm using 'propertyid' 36 (because it is a fake property that I created to test this). There are 6 pictures with 'propertyid' 36. When I want to update this property I use the URL parameter "update_images.php?propertyid=36" and the form is in the loop do...while ($row_rsImages = mysql_fetch_assoc($rsImages)); so the form repeats itself until there is a text field for every 'propertyid' 36 image. As you can see from the below code the value of $total_images and 'old_picorder' come from the database, and $propertyid is passed from the URL parameter. 'new_picorder' is a text field (and is new_picorder1, 2, 3...6).

The problem lies somewhere in the do...while loop or in the script's for loop because I used Dreamweaver's "Record Update Wizard" in a new file and just had it update all instances of 'picorder' with 'propertyid' 36. This process did what it was supposed to do, changing every 'picorder' value to what I had inputted (2). I've attached this script and also my SQL data. Thank you

From the Dreamweaver Update Wizard:

$updateSQL = sprintf("UPDATE propertiesimages SET picorder=%s WHERE propertyid=%s",
                       GetSQLValueString($_POST['picorder'], "text"),
                       GetSQLValueString($_POST['propertyid'], "int"));

  mysql_select_db($database_connProperties, $connProperties);
  $Result1 = mysql_query($updateSQL, $connProperties) or die(mysql_error());

new_picorder1, 2, 3...

<?php echo "<input name=\"new_picorder" . $row_rsImages['picorder'] . "\" type=\"text\" id=\"new_picorder" . $row_rsImages['picorder'] . "\" size=\"2\" />"
                                                                         echo "<input name=\"old_picorder". $row_rsImages['picorder'] . "\" type=\"hidden\" id=\"old_picorder". $row_rsImages['picorder'] . "\" value=\"". $row_rsImages['picorder']."\">" ?>

<?php $total_images = $row_rsImages['picorder'];?>
<?php echo "<input name=\"total_images\" type=\"hidden\" id=\"total_images\" value=\"$total_images\">
                                                               <input name=\"propertyid\" type=\"hidden\" id=\"propertyid\" value=\"$colname_rsImages\">

old_picorder1 = 1 new_picorder1 = 2
old_picorder2 = 2 new_picorder2 = 3
old_picorder3 = 3 new_picorder3 = 4
old_picorder4 = 4 new_picorder4 = 5
old_picorder5 = 5 new_picorder5 = 6
old_picorder6 = 6 new_picorder6 = 1

[bpat1434]

Okay, thanks for the files. I'm going to go test it now, see if I see anything out of the ordinary (which from first glance, I think I do).

[herschen]

Somebody told me that it was a scripting problem and I needed to use AJAX with PHP and MySQL to get this to work. AndI just found this post: http://www.thescripts.com/forum/thread2162.html
Maybe I should be using the foreach() function. Thanks for all of your time.

[bpat1434]

Yes, you should be using a foreach. What I had thought you were doing was using a CSV inside a database to define the "order" of such pictures. But if you're doing one row per order per picture, then you need to loop through the POSTed results and for each one perform the following query:

UPDATE `table` 
SET `picorder`='%d' 
WHERE `picorder`='%d' 
  AND `propertyid`='%d'

The picorder in the WHERE clause is the old picorder, and the picorder in the SET clause is the new picorder.

Hope that helps.

[herschen]

This has been resolved. I finally figured out what was wrong. I had the query updating 'picorder.' when it looped through a second and third time, there would be two instances of the same picorder, so it would update both rows and give me the wrong number.

[bradgrafelman]

Don't forget to mark this thread resolved.