Urgent HELP NEEDED!!

mkkay

This is the code i use to obtain images of a car on my site, however I moved servers to a php4 server and now when i click on the photos link the site just refreshes. Please help. How do i make it work?

{
		$MyImages = explode("|", $a1[image]);

	$ShowInfo .= "<table valign=top align=center width=\"100%\" height=50>\n<tr>\n\t<td align=center valign=top width=\"100%\" height=50>";

	while(list(,$v) = each($MyImages))
	{
		$ShowInfo .= "<a href=\'info.php?id=$_GET[id]&i=$_GET[i]&f=$v\'><img src=\'cars_images/$v\' width=50 height=50 border=0></a>&nbsp;&nbsp;&nbsp;\n\n\t";
	}

	$ShowInfo .= "</table><hr size=1 width=\"95%\" color=#336699><br>";


	if(!empty($f))
	{
		$ShowInfo .= "<center><img src=\'cars_images/$f\'></center><br>";
	}
	else
	{
		$ShowInfo .= "<center><img src=\'cars_images/$MyImages[0]\'></center><br>";
	}

}
else
{
	$ShowInfo .= "<br><center><img src=\'no_image.gif\'></center>";
}

}

wilku

do not escape single quotes inside double quotes string - it's not needed. Also for the sake of html "purity" make up your mind whether you want to write tag attributes within single quotes or double quotes (no quotes at all will work but it's against rules).
example:

$ShowInfo .= "<a href='info.php?id=$_GET[id]&i=$_GET[i]&f=$v'><img src='cars_images/$v' width='50' height='50' border='0'></a>&nbsp;&nbsp;&nbsp;\n\n\t";
//or
$ShowInfo .= "<a href=\"info.php?id=$_GET[id]&i=$_GET[i]&f=$v\"><img src=\"cars_images/$v\" width=\"50\" height=\"50\" border=\"0\"></a>&nbsp;&nbsp;&nbsp;\n\n\t";

NogDog

Just to clarify, no quotes around an HTML attribute value is legal, as long as there are no spaces in that value. in XML and XHTML, the quotes are required regardless of whether or not there are any spaces within the value. I agree that when writing HTML, I prefer to quote every attribute value for consistency, readability, and just incase something changes at some point that would insert a space into the value (or to keep life simple if I need to convert the document to XHTML at some point).