[RESOLVED] problem with if loop

[saco721]

Hi,

I am having problems with script containing an if loop, it produces no errors, but total_number never changes. Here is the script:

<?php

error_reporting(E_ALL);

session_start();

$_SESSION['total_number'] = 3; // store session data

$test1 = "myfile.pdf";

if ($_SESSION['total_number'] > 0){

echo ("<td><font face = \"Verdana\" size = \"2\"><a href=\"samofile.php?arg1=$test1\">Click to download.</a></font></td>");

echo "Downloads left = ". $_SESSION['total_number'];//retrieve data

$_SESSION['total_number']--;
}
else
{
echo ("downloads complete");
}

?>

Any help would be greatly appreciated!
Thanks

[NogDog]

You are initializing the session value to 3 every time the script is run, so the fact that you decrement it by one won't matter the next time that the script is called.

Also, please make use of the PHP bbcode tag when posting code sample here.

[saco721]

Hi! - thanks for the response.

How do I make $_SESSION['total_number'] run only once so the decrement works?

I have tried moving the $SESSION['total_number'] declaration into a new set of php tags at the top of the script.I now have 2 sets of php tags in the same script, one to declare the $SESSION['total_number'] and one for the if statement, but I still get the same problem.

I have also tried using a while loop, It decrements ok, but gets stuck in an infinate loop once the downloads complete section is displayed.

Please help

Thanks for your time!

[bradmasterx]

if you are still looking for help read on:

<?php


error_reporting(E_ALL);

session_start();

$download_session=$_SESSION['total_number'];

if(!$download_session){

$download_session = 3; // store session data

}
$test1 = "myfile.pdf";

if ($_SESSION['total_number'] > 0){

echo ("<td><font face = \"Verdana\" size = \"2\"><a
href=\"samofile.php?arg1=$test1\">Click to download.</a></font></td>");

echo "Downloads left = $download_session";//retrieve data

$download_session--;

}

else

{

echo "downloads complete, you have $download_session more credits.";

}

?>

[saco721]

Hi!,

thanks very much for the example, but It throws errors, and I still have the same problem as the $download_session variable still doesn't change when the script executes. I did a cut and paste on the code so Im sure its the same as yours. The error message I get is:

Warning: session_start() [function.session-start]: Cannot send session cache limiter - headers already sent (output started at /homepages/4/d142124103/htdocs/test_query3.php:2) in /homepages/4/d142124103/htdocs/test_query3.php on line 7

does the script run ok on your machine?

thanks!

[bradgrafelman]

Get rid of whatever's echo'ing data on line 2 of the script.

Also, there are some errors in the script posted above in that modifying $download_session does not change the session data in any way. I've never seen the need to duplicate variables, so I'd probably just do something along the lines of:

<?php
session_start();

if(!isset($_SESSION['total_number']))
    $_SESSION['total_number'] = 3;

just like you did in your original code snippet.

[saco721]

Hi!,

thank you very much,

problem solved.