for instead of foreach

willg

Hi, I have the following code whcich works, but consumes too much memory. In order to reduce memory, I want to change the "foreach" statement to a "for" statement, but I do not knwohow. Any ideas? If not, any other waus to reduce memory uptake?

The array is $web

foreach ($web as $key => $val)
{

$data = file_get_contents("$val");

preg_match("@Code\=(.*?)\</p\>@", $data, $outcode);
$code = preg_replace("@\<(.*?)\>@", "", $outcode[1]);

preg_match("@Class\:(.*?)\<br\s/\>@", $data, $outclass);
$class = preg_replace("@\<(.*?)\>@", "", $outclass[1]);

preg_match("@http\://(.*?)\"\>@", $data, $outid);
$id = $outid[1];

$web[$key] = $code."|".$id."|".$class."|".$val."\r\n";

}

Weedpacket

I don't see how changing the foreach to a for would reduce memory.

If you want to do that, consider reading files line by line ([man]fgets[/man]) instead of all at once; then you only need storage for one line at a time.

willg

Hi,

I'm told that "for" or maybe "array_walk" is more memory efficient than "foreach" but I do not know this myself and do not know how to code that.

Just wondered if anyone knew a more efficient way to do the above code in terms of memory? Anyone any ideas?

NogDog

I'm not aware of any memory use issues with foreach versus for loops. Before you spend time on that aspect, I would suggest you address these questions first:

What evidence do you have that the script uses too much memory?
Assuming that it does, in fact, use too much; have you done any profiling/debugging to determine what part(s) of the script is using excessive memory?