[RESOLVED] Cant figure out what's wrong with this script...

Wales

I get this error: Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource

Error for this line: $count=mysql_num_rows($result);

Can't seem to figure out what is wrong...


// value sent from form 
$email_to=$_POST['email_to'];

// table name 
$tbl_name=members; 

// retrieve password from table where e-mail = $email_to(admin@mysite.com) 
$sql="SELECT password FROM $tbl_name WHERE email='$email_to'";
$result=mysql_query($sql);

// if found this e-mail address, row must be 1 row 
// keep value in variable name "$count" 
ERROR FOR THIS LINE     $count=mysql_num_rows($result);

// compare if $count =1 row
if($count==1){

$rows=mysql_fetch_array($result);

// keep password in $your_password
$your_password=$rows['password'];


// ---------------- SEND MAIL FORM ---------------- 

// send e-mail to ...
$to=$email_to; 

// Your subject 
$subject="Your password here"; 

// From 
$header="from: your name <your email>"; 

// Your message 
$messages= "Your password for login to our website \r\n";
$messages.="Your password is $your_password \r\n";
$messages.="more message... \r\n";

// send email 
$sentmail = mail($to,$subject,$messages,$header); 

}

// else if $count not equal 1 
else {
echo "Not found your email in our database";
} 

// if your email succesfully sent 
if($sentmail){
echo "Your Password Has Been Sent To Your Email Address.";
}
else {
echo "Cannot send password to your e-mail address";
}

jkurrle

Did you make your database connection before running the query? Try replacing this line:

$result=mysql_query($sql);

with this line:

$result=mysql_query($sql)
  or die("error selecting from table \"$tbl_name\" - ".mysql_error());

and see if we can get something more interesting...

Wales

Got the following error:
Parse error: parse error, unexpected T_LOGICAL_OR

jkurrle

Odd. The syntax looks correct to me on that line. I use it all the time. Return it to it's original line for now.

Basically, what your error message is saying is that $result isn't a correct product from your query. This can happen for a number of reasons. First, did you connect to your server and database correctly before running the query? Here's an example:

$query="SELECT password FROM $tbl_name WHERE email='$email_to'";

$connection=mysql_connect("servername","login_id","password")
  or die("Connection to Database server failed - ".mysql_error());
$db=mysql_select_db("database",$connection)
  or die("Cannot select database - ".mysql_error());

$result=mysql_query($query)
  or die("Select from table $tbl_name had errors - ".mysql_error());

mysql_close($connection);

If you don't connect to your server and select your database first, your query will not be able to return a valid result.

I hope this points you in the right direction.

Wales

For some reason when I do that it works, but when I just do a require_once to my connecting to database file it gives me the error. Thanks for the help

Kellimus

Well, require_once would only create a short-term connection to the database, wouldn't it...?

I use include(), and include a seperate .php file with the database connection information when doing database connection

jkurrle

Kellimus has the right idea. Create a file called DB_Connect.php, and in it, create a function like this:

function Connect_To_DB($database)
{
$connection=mysql_connect("server","login_id","password")
  or die("Error connecting to MySQL server - ".mysql_error());
$db=mysql_select_db($database)
  or die("Error selecting database $database - ".mysql_error());
return($connection);
}

You should store this file outside of your HTML root, so if you site gets hacked, they don't have your database credentials.

To use this code correctly, do something like this:

include("../../DB_Connect.php");

$query="select * from sometable";

$connection=Connect_To_DB("database_name");
$result=mysql_query($query)
  or die("Select from table sometable had errors - ".mysql_error());
mysql_close($connection);

while($row=mysql_fetch_array($result,MYSQL_ASSOC))
  {
  extract($row);
  //do something with all your extracted variables...
  }

Hope this gives you some ideas...